From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE3482C9D for ; Mon, 4 May 2026 13:46:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777902366; cv=none; b=u19W+/x2BU2wHyP4Rut+HgscsCcnsGi5qX/nRfOVxffOU8ANbIQ149L9lr941GOXregxf8zpQVDHcUyHH+AW5NMfufVjP6bT4KNtpiuXr8VANU3T6slWa8kfOUqa9n/YZaBab3gC5JWYexXiRAuzgpDmoHNSjwHkDKUH8bbphuE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777902366; c=relaxed/simple; bh=A2Kpz/bYRNMo3xwXI5Xybf+gUVzqTmb83C93LElGNyo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BlDGOUawainGMGxLyjGWLKHBYNMRTYbdhX/L2IJrJl985CYAUz333xWJLqMquSngURpJNa2lnYK55eWIdtVH9BWb/P4fIwjnJWQHKoNLzltzz6XSpxe4KBl6KmNrhZo73d8z0KkIDwdcZ14IYhpetaUvzSy05u1mTV7RgDkzlKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UonJb0B1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UonJb0B1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F696C2BCB8; Mon, 4 May 2026 13:46:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777902366; bh=A2Kpz/bYRNMo3xwXI5Xybf+gUVzqTmb83C93LElGNyo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UonJb0B1TRkrcXg6tizQ7VvGa/iQ5fa0HgkmFBizZEuYlV7Si6ldbqQSSPxuwVLgh aXrT1fK9D1jC5Hui30t2I3Plnic1NIFcqpoHhRZcgZiNyeKoHD7doe0YOssaac/PZD zXKd3gadcV3bhiCGXofh5LL8+tu+LqKZkhS2WTxwR+eAw6ySY8hJ2DKOs6Gni++9I7 Vb2SoKqV+Bwrp/2zPw9HQI/pI0pGrTXQEO6KaYov/0S8UvZMddi8fXQwp0RDkSFPC5 WhoKiQMSJ3rZGGbDiffZWQYC9u+YzUBEiRNT8TsKdias98u5QvSUhImK7PRydL6Fc4 5OoSxDmoiCVNg== Date: Mon, 4 May 2026 15:46:01 +0200 From: Mike Rapoport To: Pratyush Yadav Cc: Pasha Tatashin , Michal Clapinski , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memblock tests: define MIGRATE_CMA Message-ID: References: <20260504102742.3833159-1-pratyush@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260504102742.3833159-1-pratyush@kernel.org> On Mon, May 04, 2026 at 12:27:40PM +0200, Pratyush Yadav wrote: > From: "Pratyush Yadav (Google)" > > kho_scratch_migratetype(), defined in include/linux/memblock.h uses enum > migratetype. This breaks build for memblock tests with: > > ./linux/memblock.h:634:73: error: parameter 2 (‘mt’) has incomplete type > 634 | enum migratetype mt) > > Fix it by defining enum migratetype and MIGRATE_CMA. As is the case with > the other headers in tools/testing/memblock, do not bring in the whole > thing, only what is needed. > > Reported-by: Mike Rapoport > Closes: https://lore.kernel.org/linux-mm/afcdDm4aAJvNaQqH@kernel.org/ > Signed-off-by: Pratyush Yadav (Google) > --- > > Notes: > I didn't add a Fixes here since the commit hash for the deferred series > isn't stable yet. Anyway, I think we should fold this into "kho: fix > deferred initialization of scratch areas". So random bisects don't land > on a broken test. I applied it to next as a separate patch for now. > tools/testing/memblock/linux/mmzone.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/testing/memblock/linux/mmzone.h b/tools/testing/memblock/linux/mmzone.h > index bb682659a12d..8d934ff5b080 100644 > --- a/tools/testing/memblock/linux/mmzone.h > +++ b/tools/testing/memblock/linux/mmzone.h > @@ -35,4 +35,8 @@ typedef struct pglist_data { > > } pg_data_t; > > +enum migratetype { > + MIGRATE_CMA, > +}; > + > #endif > > base-commit: 74d1099bb4edfca3ce6edc61dbacbed96720034c > -- > 2.54.0.545.g6539524ca2-goog > -- Sincerely yours, Mike.