From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A92D20DD51; Mon, 4 May 2026 13:56:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777903002; cv=none; b=P3QQ3+drHrdudV7crOOxc8aFzKnRRwp1D4gQQ0KKeqqC9zhYWP11+x9H3DniWV53TYc2LyZEHD0JDUyQJRVwPUb89PtOSxuDcxEj0MaEeSNaxB1Fa1zILBngggr5MicaY8Tz2F08ci2R5AzAYQN+VvI12jrnMJGwicgqZOHNOJM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777903002; c=relaxed/simple; bh=nHyGMukKa/aeCIQK+8Djjqek/gwXo0Hm9P2kwKVLVcA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JNHAEhCtuoYvm/SltKlzKfXMBH52R0D1B4/up8SNQqaLhu0rt5g206U0Fo7iJdOOjfsoH3RSrNOBUdEzRkmqvJrf2MnQmHv1My8Iwqpsane9IUQLdigakfNIRPpf8PCzapQp+MtpdY1r33/aspg1pMwDPA/eNLRaVG9LPbV4D7o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Mnble04x; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Mnble04x" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777903001; x=1809439001; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=nHyGMukKa/aeCIQK+8Djjqek/gwXo0Hm9P2kwKVLVcA=; b=Mnble04xEK+j4zvEspObuxiKDXpauRuVKuWss7h5ymBPTCkHR5lfOhLc xar0iKBLNu9bwJd2iVoP2gxe/mOyvzx/ur7iLp0B5UjX/3w+0/QYLqqZ5 CYL4+aVX9+ZltIriOGFOmxwep/6ubUiYJfNItNRekWskN+zpBx5eWOYwX YehUfbOxrYO+pTTmLJjqhTJnnnx875z9Shy+QkGXueMFTZo7qmbBYfnTj HZbMZHDBHnusO+is6v6SGhp+j17RY/cZFtPHTL/5rHo46F+KTlYb0Mheb VpU/Nkgb196F8BVkpJ34U7mZ5hOawQgsvh1oNFl0guwJnuNxLdyeocING A==; X-CSE-ConnectionGUID: bMCgukcWSHuFytnnfKS56A== X-CSE-MsgGUID: sJBkSUz2SdqlPublUAeBnw== X-IronPort-AV: E=McAfee;i="6800,10657,11776"; a="90216768" X-IronPort-AV: E=Sophos;i="6.23,215,1770624000"; d="scan'208";a="90216768" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2026 06:56:41 -0700 X-CSE-ConnectionGUID: /Ya7LkBfSl2CfdHF1899Xw== X-CSE-MsgGUID: AuR+nXGDSJ+u4VDQY8w3FA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,215,1770624000"; d="scan'208";a="232369344" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa007.fm.intel.com with ESMTP; 04 May 2026 06:56:39 -0700 Received: by black.igk.intel.com (Postfix, from userid 1003) id 2DF4D98; Mon, 04 May 2026 15:56:38 +0200 (CEST) Date: Mon, 4 May 2026 15:56:38 +0200 From: Andy Shevchenko To: Thorsten Blum Cc: Olivia Mackall , Herbert Xu , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] hwrng: core - use MAX to simplify RNG_BUFFER_SIZE Message-ID: References: <20260430110047.248825-5-thorsten.blum@linux.dev> <20260430110047.248825-7-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260430110047.248825-7-thorsten.blum@linux.dev> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Apr 30, 2026 at 01:00:50PM +0200, Thorsten Blum wrote: > Replace the open-coded variant with MAX(). Hmm... While this patch is correct the very similar is being used outside of hwrng. Can we perhaps have a common definition somewhere near to SMP_CACHE_BYTES? -- With Best Regards, Andy Shevchenko