From: Mark Brown <broonie@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
KancyJoe <kancy2333@outlook.com>
Subject: Re: [PATCH v3 2/2] regulator: add SGM3804 Dual Output driver
Date: Mon, 4 May 2026 23:05:06 +0900 [thread overview]
Message-ID: <afinkq34soN5MWOm@sirena.co.uk> (raw)
In-Reply-To: <20260504-topic-sm8650-ayaneo-pocket-s2-sgm3804-v3-2-c4783443890b@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
On Mon, May 04, 2026 at 02:44:06PM +0200, Neil Armstrong wrote:
> obj-$(CONFIG_REGULATOR_SUN20I) += sun20i-regulator.o
> +obj-$(CONFIG_REGULATOR_SGM3804) += sgm3804-regulator.o
The sorting is off here (and in Kconfig).
> +err:
> + gpiod_set_value(ctx->gpios[rdev_get_id(rdev)], 0);
> + return ret;
A stray gpiod_set_value() here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-05-04 14:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 12:44 [PATCH v3 0/2] regulator: add support for SGM3804 Dual Output driver Neil Armstrong
2026-05-04 12:44 ` [PATCH v3 1/2] regulator: dt-bindings: document the SGM3804 Dual Output regulator Neil Armstrong
2026-05-04 13:22 ` Neil Armstrong
2026-05-05 7:51 ` Krzysztof Kozlowski
2026-05-04 13:24 ` Rob Herring (Arm)
2026-05-04 12:44 ` [PATCH v3 2/2] regulator: add SGM3804 Dual Output driver Neil Armstrong
2026-05-04 14:05 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afinkq34soN5MWOm@sirena.co.uk \
--to=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kancy2333@outlook.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox