From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDD9235A3AD for ; Mon, 4 May 2026 14:11:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777903911; cv=none; b=tRy3soofdjkZ4h1PVoGXSf+mh5VIs67WoYipIfW+tPduWTgaBfoLCThqqAhGTkPvim01KIEHBdkzs+l7FmpCYUhvW4x6CzbfYrkT5Na0mYhqgrL2eG2xmcH5b3u94OytJprP+hh9bgFRPlesinIx6hVS86nH2PsrNuTXTi74em4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777903911; c=relaxed/simple; bh=qfUUxyqNvH4WRBEWd6FZlyAuj2KoJoTwTcg+2ylS410=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gHKM+nqtPZZrpL7Ho1oG47nAboIksM6P6CHVw4QKScwwlLMEwKnJXuqOeuyMfEHa/UiT6VAK/Y9R9ntgolDehtUc0CnPvvnPsLsdzhpIBFh+EyBnFKGooUVqJ6Ji8p3wLXHu+NfVNot8s10XELaI0uh8RLBRQzerqzljbWhDS/s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=S6wqbypN; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="S6wqbypN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777903910; x=1809439910; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=qfUUxyqNvH4WRBEWd6FZlyAuj2KoJoTwTcg+2ylS410=; b=S6wqbypNYAAxgkLmuWtYOtyzJPVlU1jq+nBPcjrfvCf/9ob7FseK5x4J YEB26BKSHKRLjbTXxbGMTZ8511wb9KPCXF4zqb6bHacgqoynrMGoU9iiG hmwMl2K7fs2Jb3BKmvJ0rth0gkdsKqnHX6MlZTn4+3CdpXQCK9E4WvIAb qHECmyNE5FI5lVGEe/T6R5bxaV4d/y3qx3Zp/msWaWdN/PGY0KYaxnvr4 1S9JaLShqIRY5z2JoUtNBZmJfDC4s+wCz0DU7rMDrQk9MoM8JWqEPcpuD 0XklRUfLtNvFMBtdRzH7wCjp3cEYF69FEH0/f2fMRpXodeDxiW8lzXIqg g==; X-CSE-ConnectionGUID: ZyoSRXmARi6tY94TR26qiw== X-CSE-MsgGUID: 1HfEr/+CSlOg1GA89Tilwg== X-IronPort-AV: E=McAfee;i="6800,10657,11776"; a="77777969" X-IronPort-AV: E=Sophos;i="6.23,215,1770624000"; d="scan'208";a="77777969" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2026 07:11:49 -0700 X-CSE-ConnectionGUID: K0RCBe14QrC+pdKVhP/TYQ== X-CSE-MsgGUID: Gga4zDuXSSaLQRj8vC7rGQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,215,1770624000"; d="scan'208";a="240511967" Received: from ettammin-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.245.198]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2026 07:11:47 -0700 Date: Mon, 4 May 2026 17:11:44 +0300 From: Andy Shevchenko To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Andrew Morton , Petr Mladek , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] vsprintf: Only export no_hash_pointers to test module Message-ID: References: <20260504-restricted-pointers-kunit-test-v2-0-19e8b1c0fbeb@linutronix.de> <20260504-restricted-pointers-kunit-test-v2-1-19e8b1c0fbeb@linutronix.de> <20260504135014-f477a0fe-1af6-4a85-9259-3056a13c0d1f@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260504135014-f477a0fe-1af6-4a85-9259-3056a13c0d1f@linutronix.de> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, May 04, 2026 at 01:53:47PM +0200, Thomas Weißschuh wrote: > On Mon, May 04, 2026 at 01:57:31PM +0300, Andy Shevchenko wrote: > > On Mon, May 04, 2026 at 12:43:40PM +0200, Thomas Weißschuh wrote: ... > > > -EXPORT_SYMBOL_GPL(no_hash_pointers); > > > > > +#if IS_MODULE(CONFIG_PRINTF_KUNIT_TEST) > > > +EXPORT_SYMBOL_FOR_MODULES(no_hash_pointers, "printf_kunit"); > > > +#endif > > > > But do we need that ugly ifdeffery? the infrastructure should handle that. > > Where does the generic infrastructure take the kconfig option into account? Nowhere, but my point that it's taken care of at run-time. > > (Also, if I build a module separately after the kernel, it won't work.) > > Only if it was not enabled when the kernel was built. > > But if people are unhappy with the ifdeffery, I'm fine with dropping it. > It is not a hard requirement at all. I think it's unnecessary to have. But I'm not a maintainer of this code. -- With Best Regards, Andy Shevchenko