From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C86361F5821 for ; Mon, 4 May 2026 17:00:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777914057; cv=none; b=JDLJ3hmmtgr8uxEZbDPkJB44WITxvyyWw5+G6Ms6XZLQ/TqL0pX0xEPoqNCgOgEeVHJZmfMBc8gQ1FYQ7izkvZWaJQhGuQbNn0L86QzD3V708RAGYmfnRfeSwAbXEuWg32hZYTa11Jcn9vL9rrxGRxPqcG6GkhhDenTyb2eJcAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777914057; c=relaxed/simple; bh=SvYuwhoj+MC168s8WF3aTNPzHTkFNFVNcEfomso5Z2o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F+n+OV8/tcmGpIl4zCHQV5i7EFms4JnM0gvJZcdRKYSqB6iltctSnQnSTw/PbCALhpAIi5gHYTrLUZYcWup18b+maQ46uMqGJnMJ1SEMHRwuyqNLLUMWBXKA6CtLXiHHZ8AizwOa+j8cHx0c76anWTz83O/Ar3dHwuPqooQU1tE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nOKZRrjo; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nOKZRrjo" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-2bdd40d3c61so5432224eec.1 for ; Mon, 04 May 2026 10:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777914056; x=1778518856; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2PGmmr1OFx7Ef94Mvp1XVRRtzp0lP2gGW1M3Ai8Oq7U=; b=nOKZRrjouj9Z5KU5NC8oAQ4xO2YXGRJr6wh8adt3FXLhtwD53n2iGA3/48Htv/yGyU o9cWfA1Jw/qmqseqR6bf1u6rSFulZdehBxtSwTohbTHBgotNoZ1vJTpDaTToi6UQ2T5l MawUK0fW8EtfGASyeyigKEeJ/7SAY/KUIWiWq7MKpJl8Uqo7HXKF3Flti0a0kv8JbIh5 7MhT+d+cEX3MoNdKmdri6jALpFzWe/XWYg1ZuN1sKQZ4skhmAFNNGbb/lrtVqwFBelw+ WuMkNLrY27C4pnVvAL/XdvMX0A8jkf6oIgTUmEqC6c0Rm6UBuLz5OWdsrZ52QU6pXjri kHYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777914056; x=1778518856; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2PGmmr1OFx7Ef94Mvp1XVRRtzp0lP2gGW1M3Ai8Oq7U=; b=GwW1HFJ7rp+cBZ1fh23iA6D4e397bRS1xahQzV3VpcNpvMTT9yHnTcc3jm9tIQWpzn AQzpe/YLGEwI+igGJxqoM2xdolu9JUkLRkMUkGZK55i3Y/pN4tfYY1EK9yWQ0tjmo2tO HFtkis2a38PWmEppXUfIkiWK2dMn3guuWaKGliaIuOJYr871Lw0UnGCTFinwyNSlGjdR kewFYWIUJq2eP3tD1uQP+E9jCtWVNlrcOoGS8M7PrAGAeoRHyUzD99Nod58TIC/judbB suNM1rIzQiU9J13ewYp08+qLHLAjWgAZmH0HgxPlHcu8cbbGeR2aZOUoPXZiKQ+VBTka wFow== X-Forwarded-Encrypted: i=1; AFNElJ/Wdvegr9a9hAHqU+v8O2wzd28nuXutuXyZj38OxM49oOBkPgKbJ2LtMHLSyM0FmqPwUPVagVXSsAiVqhM=@vger.kernel.org X-Gm-Message-State: AOJu0YyvdxEPmWWFVSgiND1/cK736r4I3xZTPwCXXIygxXUMYcQ4IBps DJEp+lbUlEkIBnCR2/DjLm5D4FBNiP7fd9zNoftcHxLZsNULXIvWIjEp X-Gm-Gg: AeBDiesx/8waXGySbpIemXp757Um5OSFASOsPa08l+2hU63FsRm2xf6k2hNqUT+Gr72 Y+HDStE348t308p7K4wNwPkYs0UScelAMG6rDfKqUXPO7E6cW+tU8zoUKVf+dihc1Ffgia8MX/W 1PLbxMz3FAKC21yKND3MT+E0hTGexLP8hBUvH4Ui/GVpkyCkZ13E1/bx+Bqq4tRc1K8N0hAYn4v xdU19LK4TK8tTaMPrrfV+k9lOYEGDLkF8EroZ4A2rCpdOmsSeX6YPLbK0PAf2dbepP5pobwgecz 9CN2azu60ylducjJIpmaoefC5Xa7kruEz5TaFZLW1Rpv2NLQ1sy7PHDZ0Nm5asjxoCfTu8ApV0l rRYMeeoQN2n7ggmRAOqPycea0iAWpz1sVcpkVeCqi7SDE5LhfC/8s49PmjZpo5ktwNsGHtf2mVo eYJ+6IZXCi+bm0eL9XRX4hQva22QaAB4/3ct3v6hzihRFpqeoUSrrFcpw4ctahWLHdjMLgzKdhD /KVqNvfp6ebVA== X-Received: by 2002:a05:7300:fb96:b0:2de:cc07:e8b with SMTP id 5a478bee46e88-2efb8aa1d96mr5274059eec.1.1777914055733; Mon, 04 May 2026 10:00:55 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:5b87:9b19:32e2:2981]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ee3889cf53sm21498060eec.5.2026.05.04.10.00.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 10:00:54 -0700 (PDT) Date: Mon, 4 May 2026 10:00:38 -0700 From: Dmitry Torokhov To: Ricardo Ribalda Cc: Nick Dyer , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH] Input: atmel_mxt_ts - Set byte_offset as signed Message-ID: References: <20260504-fix-sparse-v1-1-1071137cd280@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260504-fix-sparse-v1-1-1071137cd280@chromium.org> On Mon, May 04, 2026 at 10:55:03AM +0000, Ricardo Ribalda wrote: > The calculations done to obtain byte_offset can result into a negative > number, fix its type. > > This patch fixes the following sparse error: > > drivers/input/touchscreen/atmel_mxt_ts.c:1481:44: warning: unsigned value that used to be signed checked against zero? > drivers/input/touchscreen/atmel_mxt_ts.c:1479:49: signed value source > > Signed-off-by: Ricardo Ribalda Applied, thank you. -- Dmitry