From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010058.outbound.protection.outlook.com [52.101.61.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41D8432570D for ; Tue, 5 May 2026 09:22:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.58 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777972937; cv=fail; b=QcRqARu6atRebITyFnw00jX/AmsKILtzT8J9mj4lWBuHMUtUU/ip8xOAQw21kgwtGrO5blw508BpAXbXdhRAyqr6EnDTIMYy8pS4776K9ujoM6zSncrkGrOa5DaUZkprIPKt002sk2Yitm/dHKgDSXinSLmnk1nJjWfgZxBvc6U= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777972937; c=relaxed/simple; bh=aLee8qE9Mnq9pWwEqOhIDySMr4FJGS//cHkijO/oiDw=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=bwAgR6hzhoT7mqKYYcczCKiF8WtDhKje1KT9FkegT9gEqBZ747D4PvEiZLXZXEv+02qgn8CFCrS/LtEES7JfhiVRp0pE05VRrvPgnGwqGGviWJDbjIRjupciqEb41ok2606NzARqKVFt0HukAD1I1X9bHV2dNyAPhkitglof8zk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=PZA3oZf1; arc=fail smtp.client-ip=52.101.61.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="PZA3oZf1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kTCOVr0Lv7AiOeKVtSz1vwA6WNkvuPkDXfpATccSMF+v917f2dVdRySIa5uKMDUVY9CjCjhxr1wxCSEUhgerq8dF/VNl9ApwvxypeD+dYomO5eKTc4Aj7dYGmxyN57gFhSsAsaCIXg/W0Nf5ChW3wtXWIbmfRYKgx4OVVDLg8R7oT7QVaWCpNBVjCCRdPoJrxMwANQ6QJkmjuewpwoTspB49DyZej0pOoXbJF2VCA6A3HE5NwIDmWCusrw5KVyvKYbMquFRFJWdFQTzuJM0Mn2rOmfUhjZSbIUgrMh4aRM356fyRyyHzQQ52mh4G+tUTEVhDhvK2TxLNhol4FYTS7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dLgCeIUUQezw7X9WUbzAYC+xVBMz8TRDalp0h00TtBU=; b=FgSTASttBT2qpZ98MnExYNVFBnjDlzLad8SU5+YQ/nKKEbaplUo0f3n3K6eD+lf+V3LPU+WuoWg99XDViOOMXI7cyHiJBP3kdgSsUbLp8jd33i5++VroqT9eFSRXNz23uhymOGMhzwB4UJZsZJtCVnNdUI4rOhoOEUsTYCjE78pQdgEo5z9SwmPnqZTXk7C9CyTZqq5tkac3c9EoCaFWRcAFKNYP5A7WflGgcJ3eeWpxLaPLIg65VYm13ipvBotiIsudSrQdYCASWXhPxULmWb62MAPknJBaaDg3NM18HroNWM91hFvxL+ooOhfHvolB345lKSnuobuIpSrQwhxxzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dLgCeIUUQezw7X9WUbzAYC+xVBMz8TRDalp0h00TtBU=; b=PZA3oZf15RzwClQEo5/ON+SkSBv3zDda88FKcU44CwTfHZLSyF6/F8jg61zBHTxCRyRNvjBLyNZYTZQ3cbkJfko/K8ihJ6gsH03kll3DxsypbLixhyf7lE0TJVMj2VrKlnbBkm4lkjye7quaRzmh5Qu+v0ratlWWXVvSpEhfCp0+4y5gGy0dZZP475AVWR2YwMC9ofMvhIZlqcTqS965SaElN/HN5b89rXRKsqGSGXA8jeEJXvugnFBCrx6Nu7Us6RMrAsTfDyYS0V5lQ1UBhn1f1w29b+spqg6o7FPRH7MAVS8YSiJT+Qw/MVPF9iryHOMbgNipoPDn/3TLXkP1cA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by SJ1PR12MB6027.namprd12.prod.outlook.com (2603:10b6:a03:48a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.27; Tue, 5 May 2026 09:22:09 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%5]) with mapi id 15.20.9870.023; Tue, 5 May 2026 09:22:09 +0000 Date: Tue, 5 May 2026 11:22:06 +0200 From: Andrea Righi To: Dietmar Eggemann Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , Christian Loehle , Koba Ko , Felix Abecassis , Balbir Singh , Joel Fernandes , Shrikanth Hegde , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] sched/fair: Drop redundant RCU read lock in NOHZ kick path Message-ID: References: <20260428144352.3575863-1-arighi@nvidia.com> <20260428144352.3575863-2-arighi@nvidia.com> <4b4aadb2-a159-4ed9-852e-8aeb53d798ab@arm.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4b4aadb2-a159-4ed9-852e-8aeb53d798ab@arm.com> X-ClientProxiedBy: MI1P293CA0019.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:3::16) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|SJ1PR12MB6027:EE_ X-MS-Office365-Filtering-Correlation-Id: cde22e4c-40ed-43f7-1234-08deaa87c888 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: FUEGDiHxlQjzQHMTiOZZmMkxJmY6D1bqdGpfomEupmpKTT87gQgCPEd0kmyGKT2gSte1nL3twWNCeZ/DBtovhQthInR5heaHgkvOe7QAKAzsjqHiqs+OBokVp3NEP+4Sza7liTVpLHYheblYwUcMVK03pQI2OK79UoLJaXNGw+aIkCI8+fq+aLIPYKC+8BEvteIEqFMkIzXtHx4SALv0IkKOwpJ4meoX2lBEP9XPIG9mHsq9GABpLDSOb5REyQbY7C6MobnWXavXQOV6qPZD6lBoNMgQCIVqWlf3FzvgRBBCpfbes5tdmBiMSc+UTel0JAG7Q4e88kbG7S5eH6H0eLSdFDPysbiIPB+vRdOOR3+ckEpTOrlZxHzaOQMFMYWj/jml5P+yx7SkQ3pVQ7jHDvtKCo4Kp+XpskFI2G8X9wYJNZsPL9QAQxqPGCQZFhTDKocUxRnlZNW6lhJBwPeupzVmB8ZISsMNVE5H9+Q95DIg+AfhOA7iji/u15s5gKxb4M5sK5gnb3Y2NP/Ce39eFR2vMS8zZEzanwt216DxAEy1dqviR7ZO8FbFkDawFusTTBGvYyQEDol7NzEQOrpkaYmHFOAeCF3srkk/VyT0wbd0L/p6//5KrMZhs3PRo1hO1+tQYbErO5ZpmIVl+f0VT1oErUV+7iNVyyjLgcO0JKxXNfE7bh5RL3K1VzzO6yCC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yRniKR8fRbjdh/C7n+KKC+qLyjPrfC4soCcc8ZqQ+ZOBPY9YgwwGkY9CGKNm?= =?us-ascii?Q?WYnDTQumpRVNxCgoglID7GcJwtp9IOmBqmotf4bIzHX1N9Pl2WWmnN5vHMzl?= =?us-ascii?Q?L9dW21F2bqj2SvmJz9JzeN62sJBS6Kgbzbg0ymCMtcJaRDNbaGZDNVfZp39g?= =?us-ascii?Q?R4foZ6cyeSsj4+aJOU7sPJG21Q2f1S79GQmYz9kPJeTMvJehNMoDC4LGeGDg?= =?us-ascii?Q?XJUrCKmZxcYZvzr1XnbkLtrsILNN0M+mYji3WfyRPDCtWC9ayJny4GQY5esF?= =?us-ascii?Q?xG/U/j/xRxTLH35s1Gjq0MoYJW60qpeh2g3Tua3KtXMoyIvywXKegUQ0SyFX?= =?us-ascii?Q?aZQrKm15aST6hUUK3FPi10Sulqz9k7RCDQI01taGg3s70F607qTmGCh40juR?= =?us-ascii?Q?z0QyNnYOVZyLKd5dEAoLUeY89w4jFdSOytcE8h/EgaLlNWve8s+tflxVRmII?= =?us-ascii?Q?MhIR2J5v4W4LQv4//UrmieqWoyzEceMSIb2mTH2wePWAuvHxhWXhsMAGvNnT?= =?us-ascii?Q?bV7ml9FfmP1POn6pF+A2+yiggyn1Wv3Z5p0LG3rV9ZLCKzPtn+UVTBDl6tRJ?= =?us-ascii?Q?NIoKIhrtroC6P9OH4Bq4A3wdr69PzeDYF7F45sT0jmEEOxgbwxQwfImSiQIN?= =?us-ascii?Q?hP1GQ3f9vu4/nSCoHrK/RInbrswIzmXrHjEEQSEjRMD4rVYZoeXTF6BeiFAI?= =?us-ascii?Q?6A/2d2/widstpa59gp8/IQurZ5ktQdWq7Ih1zhnl/soFmHWnK8iiHxdSS2o3?= =?us-ascii?Q?zonYjKWvwdUlduMi/94yl49eP2LOL4SdMuzg4Zise4FUjXkM9YXdsvCh3dwy?= =?us-ascii?Q?2NmCWfibMFb7mKdBNa09HBXtfZ3dn8A98VuVqO2X6nOLpu6ZNGFmREsRhBzl?= =?us-ascii?Q?gVXdhOZXO9dPEzUOeELv00gIruj+xKCAYCbrVZ4UOA4j8KC7YAgPMFr33kW4?= =?us-ascii?Q?1mpN1UdgXE/yJEfyEapYMIpmw2m+WR23dCGVetXibilsmgfPjE+Yzuq2bgQj?= =?us-ascii?Q?3XSjck2U5ZAzCRLq58yneLFWQzgMNBa/OoCAL+HxXWw5h1w3uyERXOxzvsUc?= =?us-ascii?Q?oFOV+RJwZRQ+8dINh6u/QZJ7GPLdpN1TxD99IjnQg715jndW/OeiTcgwOue1?= =?us-ascii?Q?M6NYkeApkXKP80XetS40YdKDIhLlapn2wYqwl1G6drsOz2JdY52vPRjvGXGd?= =?us-ascii?Q?zL08P1klY8esYAtaoLDIL6FxgNsY/8VxgMsXCY1b4s+nClEkp0cADkUMXMVf?= =?us-ascii?Q?AcldQqoAu3BKFORv3OmzUrioR2iRFZ+eUfZ7++zFvXSZsAapFMEpv9O9A4C6?= =?us-ascii?Q?ze/B1HW99SVMa7ozPJNlwOexd1C6YINueRb061fEIt9TyWYU3L/0NpAAdUQ3?= =?us-ascii?Q?W19BQ/1SEOYf8n7MPv/Hk+/OHDmWmz+F/N7BZlKTbMNL4oZ9w3D8xcltMWsQ?= =?us-ascii?Q?/k+SiaB96JCBn2QA5bteVxezd3bToxr5kG7cu5RoQLWOntpy/XsVj2muAcj+?= =?us-ascii?Q?Pw/2LQZE/Nilrkk/FB7vj8YRohsq85/yvtXdZmYO53MKT6jSfoAocOAyYKRw?= =?us-ascii?Q?LLaFLUqgpkxhXSz1KJRG11VQsQg7az4XYT7oRgWJcASKAdLMCP/C6BSO+4eG?= =?us-ascii?Q?cZniuAghbQuH9RtaelRS7eEfoPuChUj/FNGJ9hSWQB932vkE7MGk17YP3CNa?= =?us-ascii?Q?kE+uNVpYxRVIxGnnfHOrNFoi8KcSYzGu22fCv9ETbgMyU+n6MHU49by23/8o?= =?us-ascii?Q?w1bAilBwHQ=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: cde22e4c-40ed-43f7-1234-08deaa87c888 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2026 09:22:09.6874 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JzmAspP4Ahrt6BZ/gp6hsyS4EWMZH83bxnGmK656uyfY0nQiMsnJoDv1uSINd12veGy1OOvhtJ1fk2HvORNXPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6027 Hi Dietmar, On Tue, May 05, 2026 at 11:15:12AM +0200, Dietmar Eggemann wrote: > On 28.04.26 16:41, Andrea Righi wrote: > > [...] > > > @@ -12799,10 +12795,10 @@ static void nohz_balancer_kick(struct rq *rq) > > * > > * Skip the LLC logic because it's not relevant in that case. > > */ > > - goto unlock; > > + goto out; > > } > > > > - sds = rcu_dereference_all(per_cpu(sd_llc_shared, cpu)); > > + sds = rcu_dereference_all(per_cpu(sd_balance_shared, cpu)); > > nit: sd_balance_shared is only defined in 2/5. Ah, good catch! Apparently I forgot to test-build each individual patch, I'll fix this. Thanks, -Andrea