From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 886FA31F989 for ; Tue, 5 May 2026 09:28:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777973337; cv=none; b=rFTCC2Ljp0VIzpxz6NlDtslyfGu/YHAJ+dRSbJF1Evq0ly9v/KP80N7CaS7SLE1N+PiCrWnkBbiM0WCRln7CX8tyqPTUGFXopyuSZB2ynvx145XIMoBFOaLLnukS6gkYsHmVmVCaJS4WLLtJUx1ahrV+lHI3wg/yQ/hETUpziGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777973337; c=relaxed/simple; bh=IJWwEB3+34NsbiEAKwrGRCgD+marV4XSEhQguafryis=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DW5oC8LCgxwTRDEKIqup39VdXZLcpgZRDGT+0wxh5d67rmeHgDTiYbUL6Z9zgtGlnpZIJqY3ZiMuwpZpowFtmOwZtgq5/AwJCATClqpa5LFmw+iTJLlhSyNC1sKUjhAJFJbSWNdJpx5KNnWlcL6/NYUV7unzlM/US/YhvqsW3Is= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lHGaWEC8; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lHGaWEC8" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-67c2d57a5ceso4200329a12.3 for ; Tue, 05 May 2026 02:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777973335; x=1778578135; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=afa3+8lQ/dFRvaJ7aUrtsIA844bD/GltVTCqRXI/BJQ=; b=lHGaWEC8iNYuOPncmZ7bqA1MQXWHT+E7mOW3mZ79eshk5ixjaSEO2Vw1BMLtl7x34q h8Z1wwhxIyX7RWHVwWMvPbxnqrD7e5pGUowwB8ioi34ZKBxqq+wbRn3+r3k6LT7+Zrrf zCxilDMlPGpYsf0w1aDP4cqnGdMydLUizGoTDRyRWf/P+vUrspk10l+2gP2/OVpNxBwE tyhZbeT5a1Kh3JTSe5BNU1MDipknVlbS9pxLSCpOJu0jwoWEMF4gTqBVIcTooGHOnYQC 3YTk5GYuqyTGBTniZd5v/D/xlI4FDYzSktbXJFOdxWAFpeVuMgnE4Rp9OElvusEF578D Km2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777973335; x=1778578135; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=afa3+8lQ/dFRvaJ7aUrtsIA844bD/GltVTCqRXI/BJQ=; b=ClYjv47OQy4MtrNg++mS328P24xX4LhI4wSBWCEnirXi5gqSm9Yc4T+OAx+rVO0Vw2 959ibBvBLQmtpZ3x+BtaaOZG0QFu3YFQ0+GulCeHVJkDRQINiHi2SUpZihj8ZF5mf7y6 3wdZQj6cphZEfqkHnDKX0BCI1/r2em0w1ZFUUFUikVsqF54166TMSKWbFuXgLq8pEKdE /jWOhs9AXO6j4BHmqf+GFlHBEZcbvYHXHMq/5UKbFeLcoLNLAhhB3SysTkwPUZvQ5R9Y ExRmNxUlt/MD+sltqTgIML+DntaBcE7uvQKOYz1j7Ybe9s/LBZBHBPTFiFU/PjauQFfL aUpw== X-Forwarded-Encrypted: i=1; AFNElJ+qa0blz0W1QuY9rMxU21J2BEYN3JtdoyOrfZmbd+fDSyX3kX8iakxQckD2HJ5OlTYhai8ko7JnNjLBd7c=@vger.kernel.org X-Gm-Message-State: AOJu0YxU0/+YGBe0F4zRnsXmh+DWdZ5VhsxzgqjFxm+4sAtzmEf8IZsl TTc6Ny5vKrVDd9mKlNQgQLZBi/r1AMzy0n4Fawi/vLrXuobPjiYWr+tZ X-Gm-Gg: AeBDievro8sLPCKkrcH//hNIs57T4D6DatNxwpgwJrakxDmhkR9D+tS6oWqeH6bAZ9v dBIIKVVGsylow8QTRCcZoHnjCVwN78ZBSiw+nFHtum26s8LPqrLyTLoIdPSs0IU6cKRFVjgRMM/ gProyPBsRt/ek6hSnbv5VrnfqFZWnxvhQel2y7+BIwkW8lxr8c7Q6phc/3jM89i9MJHLniw2jJ4 vdpiPyDv0smWtxXV+YSJaIp5NGLCUqgVjTWbETZRh5cjr1i4uC7M1C0skC4SYGxv9fD1kVTjt55 EIdKt9CYOr7/1YmK9JDhiu1IURN3S29cswbF1xITRqPxmMKyNMiG9xZqsp3MVAw6yF0gnedX51l 5CxwzebjsaGC8hZ2GTfhFSUokHecP3J6d6KXFk1XNwwaU7EovJUJXol5EQi08sfUkcb3qwH8oZV QSTTBPrCae9qp27SjGWgFJe7Y= X-Received: by 2002:a05:6402:7c1:b0:676:9c6d:7448 with SMTP id 4fb4d7f45d1cf-67c1b0aa7demr4298401a12.22.1777973334601; Tue, 05 May 2026 02:28:54 -0700 (PDT) Received: from pc ([196.235.252.38]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-67cd90e1aaesm241812a12.3.2026.05.05.02.28.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 02:28:54 -0700 (PDT) Date: Tue, 5 May 2026 10:28:51 +0100 From: Salah Triki To: Andy Shevchenko Cc: Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: humidity: ens210: Fix missing I2C functionality checks Message-ID: References: <20260505090247.74555-1-salah.triki@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, May 05, 2026 at 12:07:04PM +0300, Andy Shevchenko wrote: > On Tue, May 05, 2026 at 10:02:47AM +0100, Salah Triki wrote: > > The ENS210 driver uses both `i2c_smbus_read_byte_data()` and > > `i2c_smbus_read_word_data()` during the read and probe phases. > > However, `i2c_check_functionality()` was only checking for block reads > > and simple byte writes, which could lead to hardware interface > > incompatibilities or errors on certain adapters that do not natively > > support SMBus word or byte data transactions. > > > > Add `I2C_FUNC_SMBUS_READ_BYTE_DATA` and `I2C_FUNC_SMBUS_READ_WORD_DATA` > > to the functionality check mask to ensure the adapter supports the > > required operations before communication begins. > > Can we rather modify the driver to use SW emulation for these cases? > > -- > With Best Regards, > Andy Shevchenko > > I'll update the probe function to check for I2C_FUNC_SMBUS_EMUL instead of the individual functions. Thanks for the suggestion. Best regards -- Salah Triki