From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4389E3B4EB0 for ; Tue, 5 May 2026 05:50:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777960223; cv=none; b=OQNKzBi61G+9jWkNWiuconr8CU9tDMXOT8ZKs+sdOBRDOZ3RHugpN1sa8bP2co+X9zrHwfH6yg0cEJR8O3Bb7n6JEnFGRC8SRAsQSzLO3gzuSesiriOztzND7L9U4l6Twp8W+rHg02OvVkRkwowbQ9tqPkywObx2rFtCNmp8LiU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777960223; c=relaxed/simple; bh=dlmm44Hqa9ETXT5CHHTAWtjIfp1hGtu/fICwb/PQUq4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lbiGgy3AAc7BHiOblJ/lBGgQbP5eRWVNPntOn/2E0N8Vt3CX8pYdtGtIMHb0+/u/xnpOOrym4O4+rwxudTCRmMdXXnVLaDjoD/J8XVi6HG+LknEt/IxeVcy66zSU9ME2SF2XH4ERN1t9EQHW29XyD9SU8lfsqoElnwdoUnUkmrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=APIyvlDc; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="APIyvlDc" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-bc23bebd345so282731966b.1 for ; Mon, 04 May 2026 22:50:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1777960220; x=1778565020; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YSIwPUlXrh+GDSDYQrzlL8vhBa2M1GIP++a3LvbYsq8=; b=APIyvlDcjyjjZiA4La/wmozUUP+OLjXW7FEnxI8NwltUDtTyi0Tx5r6FuQT00CuQ9u a7tSSI+PFqV4eacxHJW4OWuXK06Z9QQ9SYa9CZCwemkJzuOxJIlsp1su6Z1ri2UeHhkh M8es3IbUkDg2zmUl1MPcpzgEO2likerTyCcEx2hXXfW6swg1lXCa2Qs3MYwWcUMJHa97 jJWZk2KdLkQZ9F0ZF5ZnjBiJwaejk0w8CYSAcj+KI1QjyYHqqu7NFpwhxydff5O1Tx4/ eYdmtzTCuBet3w1loR1RzupT4R1XXQeWekEplYCvzUfbowhZKHOtiB7iXOz7pM57aVfs 5OAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777960220; x=1778565020; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YSIwPUlXrh+GDSDYQrzlL8vhBa2M1GIP++a3LvbYsq8=; b=WsJ/cqk3igV6WAcq+jfQdrsUGuxdQUywbewVekeo/pHuqG6u3YAD8ynPcRygd7J3yp Ig6Xy4AabahN1HsdakDu8Z9NYsShijJqwvzknenpeLQIVPTI2RX782Tj8pX3DzuK9c/x t1WTY6GqlR3iunx8G8VjJ1y73MXi19hf2qZw19/lpuRoTo9Myml9DNbn+6TR947MHHCf VcmYw3RXbMrCkglvV7hgLuYtf8gOAuR+Nsm7sJqQzgGg2mu1kbxJ65LH/pKx3nkV/8TO pbCJGj3IM5ozOawpGPoKjPOQox+0sPY32aeKgRoLWoC/fsdG3YYWbJK7DAD44RWd050A EcZg== X-Forwarded-Encrypted: i=1; AFNElJ+TL/0oczpCoofJDGxDbA97hWJYTajqretJOCcYJtRw988gilLfQlbCO2kHka8235Tb5P2EPkjqDBZH61Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yzgi2Zr8Q7zAoQwNal44MULhaPPdmfcPZuynA+a4LcW7cz5ZCzo BnABWqJX7IwopXNdg0XQKUYvI43kXIzUEtmEngD+1RnHMFynjdnMZ+ZbPXG9UK7u6Cs= X-Gm-Gg: AeBDieu52fbUiomSAbj8SA43FjGUgFy8NP8i5BKC1l46NHHodaBQeGu7crQzap1CzaR exy9oCCDRAKWX9d0nE7PGy1CJ19nCDf8tgcBN2fQ9MhVWwmMbgshP3iWFDXJr3CRoqj0Xi9mARZ 5UqA5dQuO7ToSxj5QJ35tVAvKunbYLXPlo9UZWbDsNJAaOU7gyDuKEKPvdvzBB5VHCqM9Sqcjrr vRxZWq17OsOjD6/u58SUfQBrXErap5Ewf+U7DrNL+N4vLgyqxt1SLp3I+qxCx82LH1vpUMxJQP2 7mxF1DOF+J64oxgHxe608ag6rjx+PiriExWsHE5xX5J/cQArNOFzRy1k03B4oUrJ9ioSHJGvFSw GAlaRJ60aqvjd+eDIAx9h756ftP3KdufEErqP85/ZYI0ing7f1RMirXkdzfrEkUTWcxsX7PwDWb H8ASctWFaJ8XG/APk9SBHDBj8scjVo9Efm1lGtPb4= X-Received: by 2002:a17:907:c70f:b0:bbf:bab5:ecd9 with SMTP id a640c23a62f3a-bc3d1662488mr116346966b.15.1777960219676; Mon, 04 May 2026 22:50:19 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-bc421629cd6sm27128166b.38.2026.05.04.22.50.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 22:50:18 -0700 (PDT) Date: Tue, 5 May 2026 07:50:16 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Frank Li Cc: Alexandre Belloni , Markus Schneider-Pargmann , Adrian Hunter , Jarkko Nikula , linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i3c: Consistently define pci_device_ids using named initializers Message-ID: References: <20260504143324.2122737-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kwrj645nikwsrwf7" Content-Disposition: inline In-Reply-To: --kwrj645nikwsrwf7 Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] i3c: Consistently define pci_device_ids using named initializers MIME-Version: 1.0 On Mon, May 04, 2026 at 04:42:26PM -0400, Frank Li wrote: > On Mon, May 04, 2026 at 04:33:15PM +0200, Uwe Kleine-K=F6nig (The Capable= Hub) wrote: > > The .driver_data member of the various struct pci_device_id arrays were > > initialized by list expressions. This isn't easily readable if you're > > not into PCI. Using named initializers is more explicit and thus easier > > to parse. > > > > This change doesn't introduce changes to the compiled pci_device_id > > arrays. Tested on x86 and arm64. > > > > Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) > > --- > > Hello, > > > > The secret plan is to make struct pci_device_id::driver_data an > > anonymous union (similar to > > https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@baylib= re.com/) > > and that requires named initializers. But IMHO it's also a nice cleanup > > on its own. > > > > The anonymous union will allow changes like the following: > > > > - { PCI_VDEVICE(INTEL, 0x4d7c), .driver_data =3D (kernel_ulong_t)&intel= _mi_1_info }, > > + { PCI_VDEVICE(INTEL, 0x4d7c), .driver_data_ptr =3D &intel_mi_1_info }, >=20 > I think it is good. Can you directly change to to > { PCI_VDEVICE(INTEL, 0x4d7c), .driver_data_ptr =3D &intel_mi_1_info } >=20 > I think use anonymous union {.driver_data; .driver_data_ptr} don't impact > the current drivers. I cannot because pci_device_id with the union cannot be initialized using { PCI_VDEVICE(INTEL, 0x4d7c), (kernel_ulong_t)&intel_mi_1_info }, That's why all drivers must be adapted first to use named initializers. Best regards Uwe --kwrj645nikwsrwf7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmn5hRYACgkQj4D7WH0S /k54SAf/YUfmS/bahkAtbcQF2rt1c0OO5xZkAuZchAlANs04rLI+WiOk9KmOd/Sw RvKZp+2C+eQAPnbzkR7IRnfJ8jz9/zIaKHYCeIZGGHhF8vJmospejGIiyp2ak5RO y9t+oHnWOcZw5AWYkcotZXEimXIam0P6mrR2nUx0ru/0whmiocKct09gW3GW9YRd K0jeQ9K9YpCFTcTRNCpTGP6tZ4yq3zR2VF+8lhUnuXigm53WE3tuJtKHmqM0zM5p gkwFJ0RtbBO4bf1ulrrMKgDqz2ehlN8nwUyBfnVvGcrLXCva46c4aH29oVF6tuDz LmjiguzDbbq2aDpktzBgzfor1eeO7Q== =hAGU -----END PGP SIGNATURE----- --kwrj645nikwsrwf7--