From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA3AA30F816 for ; Tue, 5 May 2026 09:10:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777972222; cv=none; b=CAIQ7psC8DcmUedmn2CvmUbToSILKU6NFCN/cjH/XsFZNUp3Cxfl5OdVroOSzRnPRtq2mC7whXcwW+5kdX9JZZea12lPw4OnnOGuy9URQlAnIrEAHTJ+YgteKj/qJTUAO8Gud8WOzQQm2RhZfzWOSQ5qWzde778Y3V9Hm6+jelM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777972222; c=relaxed/simple; bh=cRfHUAFGg57jog7PQsYBRdjiL7fC9Xj6KJYDTyDSrds=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=STTBHdaKBVrieZYBG3OKdW20fEmq/NIVX+EnjEotm+LSo30M0dx4bqu933+t/j0IhUchz3AZh/1c/Vnc0NFu65vlFPNinjfQNQmQGAl9gRXRZCTfJKNuEI70zc+2Ch5laRyZuitw5Nid4J01BshU3rb0iBZFcM/S3/ErP4QzvMI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=A0jRbu6+; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="A0jRbu6+" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-48d144d3428so6639715e9.3 for ; Tue, 05 May 2026 02:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777972219; x=1778577019; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=TV+dGkVQMRpG1tcF9GVXKJzex3tlmHkPz/lBk9KZDnc=; b=A0jRbu6+pPWzFS86kaDV13qbO63j0SSpWSf2CX2N22KmsOYqQ8COCXD3yQf1HzuiYx WxFI5DNMThTA51oCC6q/LP1mFJ+U/H53/FMVUJwcvMIBLk7ELuwJc06zYmSG1s2TEyoV ist3GW6FUH9ov6gAiPBHlInxWzoMGk2SY13G29KgvCpVSydgtAeQTTZK+7bD3UhxRqbv TzKxrqyeY3WH/cDuHgp+iydE4ROR0gSOzTLCuciRFeqL+ZhFnq46lB8BI3lWCWACTHyS oaBwGZh3v7gdJeiq2GdH75IBHHFQrnsB110o8hSN1C4YNOHhzHs+T1WFPWdB987TgQTJ L4mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777972219; x=1778577019; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TV+dGkVQMRpG1tcF9GVXKJzex3tlmHkPz/lBk9KZDnc=; b=VkNu7pvCknsh1nJEZ7w4SkYHUIYLv6Z5Vr2uPXyRIFQKl4WsfM/7WbjPZ21mBhkTgb 3dKApCszkiOOmvoA3kgiBsmsb++4xD3G1Oi7gH1KUR3Ka547CnZrRMG51VapXQqsXrfm U9MRDm/wQ4c+InXcoRYvxCDJdvjw+GRmrQqBRYEyLsEiQH2X7T/7kqeWTL5gUYUI2EtG DXoNuKWGCYWRlK7i739sNTN8FBc8qHM/SqiCBA1nxQZq8tCjzSQVcq+ppTFx5vLhqDGM ehmRHOg8ARMjHS0DaqzCd+92IThMR0R9Cm5QeMNHnNkKKbuHymYxJf7w6pxc7/eK9G+D lhCA== X-Forwarded-Encrypted: i=1; AFNElJ/0CuceX1hl+UoADEg8UoZMFxexhWU2UDSXOLCifHeAS10/Vf0R38c6q8uD7rWJTIUAoWQbz8hVroIaCY0=@vger.kernel.org X-Gm-Message-State: AOJu0YxtRBec/wegRDrZOiQhyByf79gn58x6A02Sth1SPVZkiXcDn6hz ThznTSyEcgocAjtxxbkizJ79pCw7iz7OJvpk0dAc/8kowxlxOuMb0v0NasJpre7oVtyoJH/3jum kG21EaOjeV/MrXa/12Q== X-Received: from wmd22.prod.google.com ([2002:a05:600c:6056:b0:489:1c31:2982]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3549:b0:48a:93d2:60d2 with SMTP id 5b1f17b1804b1-48a980fd5d4mr203597665e9.0.1777972218974; Tue, 05 May 2026 02:10:18 -0700 (PDT) Date: Tue, 5 May 2026 09:10:17 +0000 In-Reply-To: <20260504165858.4882730b@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260504-binder-netlink-v4-0-601b41cd25b2@google.com> <20260504-binder-netlink-v4-2-601b41cd25b2@google.com> <20260504165858.4882730b@kernel.org> Message-ID: Subject: Re: [PATCH v4 2/4] ynl_gen: generate Rust files from yaml files From: Alice Ryhl To: Jakub Kicinski Cc: Carlos Llamas , Greg Kroah-Hartman , Andrew Lunn , Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Matthew Maurer , Miguel Ojeda , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Christian Brauner , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Mon, May 04, 2026 at 04:58:58PM -0700, Jakub Kicinski wrote: > On Mon, 04 May 2026 09:04:55 +0000 Alice Ryhl wrote: > > tools/net/ynl/pyynl/ynl_gen_c.py | 139 ++++++++++++++++++++++++++++++++++++++- > > No. Rust. In. This. File. > > Just commit the artifacts. I truly hope that this is the only Netlink > family we will have in Rust. There's no reason to react like this. I have not ignored your concern. Last time we discussed this, the discussion ended on splitting the file into ynl_gen_c.py and ynl_gen_rust.py, which you did not reply to, and I actually spent some time working on that. However, I felt the change was non-trivial and I wanted to discuss whether that was the correct way forward before spending more time on it. Therefore, I kept this patch as-is for now and noted why it was non-trivial (sharing of CodeWriter) in the commit message, until we could discuss further. I think you are probably right that just comitting the artifacts is the simplest way forward for now. Especially since Donald is apparently working on splitting up the file for strace [1]. On the off-chance that a second Netlink family is ever added, hopefully Donald's work has already completed and we can easily add this support in a new file when the time comes. I guess another way forward is to commit a copy of the python script with the Rust support to drivers/android/binder/ and I can run it manually if the Binder yaml file is ever updated. Alice [1]: https://lore.kernel.org/r/CAD4GDZxGo6p9A07rKAW4MZNdFOYrMVzjkYNjwTqKfFcqKkzU1g@mail.gmail.com