From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from h7.fbrelay.privateemail.com (h7.fbrelay.privateemail.com [162.0.218.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95A8738AC79 for ; Tue, 5 May 2026 11:41:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.0.218.230 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777981319; cv=none; b=Q9sGpJKz4+dLRnTygMXPxIgFPOPR7Hd0vmRpa/DHjNzpEMZSBUMfl+DUUTP2b3WEJQvSBOIpUp8nS/CLqLq+vFpks+IWWalJf+vRWs9WP2Le6r1w/NvgPV8x4cbmNjty0jgnhV3A49Wsqvazg5Vt8LmTfOUqBc6fPuoIOvF4dPw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777981319; c=relaxed/simple; bh=nr1MRaMpPLxwlshYlc8bSpHtR83qoACx1MLDgQqk6Ds=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sr3mgB2+y+PSvci7uzsLJqUwBKkmpz0I1aIpCtoRdmtw8F7+VI2i5jQqlhKa0d8NDDzNK9gLnMEVGBuGjCqy5/RBfTQDyx2SfodWTzRjmENnqewKJgKIHgzrXv/obCszt53HPosypudiGLJErsJU+j/tqv5ZCfexMH/VZp1vFTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=effective-light.com; spf=pass smtp.mailfrom=effective-light.com; arc=none smtp.client-ip=162.0.218.230 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=effective-light.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=effective-light.com Received: from MTA-05-3.privateemail.com (mta-05.privateemail.com [198.54.127.60]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by h7.fbrelay.privateemail.com (Postfix) with ESMTPSA id 4g8xSF5Zvqz2xF3 for ; Tue, 5 May 2026 07:41:49 -0400 (EDT) Received: from hal-station.localdomain (bras-base-toroon4332w-grc-26-174-91-51-28.dsl.bell.ca [174.91.51.28]) by mta-05.privateemail.com (Postfix) with ESMTPA id 4g8xRR3Lb7z3hhTf; Tue, 5 May 2026 07:41:07 -0400 (EDT) Date: Tue, 5 May 2026 07:41:03 -0400 From: Hamza Mahfooz To: Mario Limonciello Cc: dri-devel@lists.freedesktop.org, Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Alex Hung , Ray Wu , Wayne Lin , Aurabindo Pillai , Timur =?iso-8859-1?Q?Krist=F3f?= , "Mario Limonciello (AMD)" , Ivan Lipski , Chenyu Chen , Matthew Schwartz , Yussuf Khalil , Tom Chung , Roman Li , Colin Ian King , Charlene Liu , Kees Cook , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/2] drm/atomic: attempt full modeset on page flip timeout Message-ID: References: <20260501203552.749080-1-someguy@effective-light.com> <5dd93e29-a076-491b-9861-e08a0204c77d@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5dd93e29-a076-491b-9861-e08a0204c77d@amd.com> On Mon, May 04, 2026 at 04:50:21PM -0500, Mario Limonciello wrote: > Do you actually need to set all 3 of these to true? > > I would think you only need: > > crtc_state->mode_changed = true; > According to my testing `mode_changed` on it's own is sufficient for amdgpu and the documentation [1] seems to suggest that it should be fine more broadly. Though, it doesn't seem harmful to set all of them just for safe measure. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/drm/drm_crtc.h?h=v7.1-rc2#n118