From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 04BE534677D; Tue, 5 May 2026 14:36:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777991773; cv=none; b=qqcmcnmZLw/RYMBWm5Z1oHK7ULl9wxwnbHg+/sjNjMSGi6JxM3vMmXuEQjPjNATFDRqEmgnNZqBAoXSr14CAk90bk31+7170ZciJCD0z9l9U35KptfM9KeEpkg35tcT8CquLZd/JcdPRmyRClVhkHkRklUj2fT+5Z+kKyR+O10E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777991773; c=relaxed/simple; bh=0T3MKaQLW28GaOTl2D9yp1TlQr7cPQv8Jr8lznjVrUg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C8mOFoZtzjGpCPt1whe4lNSZWuZ/2KupCmcap0O9JhjX8eLSB0zllv1lIXDemtLhyP4ugvqbLd/Vv2L+rhs8U6y4iEKFtsRaGSdfKixZs/re6aVpUPiSC2SeqqihgCcMz0toYaqIqiUkt36gxxVsogZM2OWzlTZMp9jlI0BIwHc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=RVWDs8Ot; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="RVWDs8Ot" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E304C293B; Tue, 5 May 2026 07:36:05 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B30BB3F763; Tue, 5 May 2026 07:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1777991771; bh=0T3MKaQLW28GaOTl2D9yp1TlQr7cPQv8Jr8lznjVrUg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RVWDs8OtvKs83ItvR0uvQRZRFHjQgeKCGanXHI1nFmSP2G72mJ7/PVKzpR4BbavsE i3cYIfnOy35P9b1FxKO9dC6VhkpJXReXScZQrbAAWh8pSBemE6fDVkfFW0xjzarhSJ rSs7G8mZ1nlDQlh4Ll3AJ0HMRaz5TcZNhaHVy4NE= Date: Tue, 5 May 2026 15:36:00 +0100 From: Cristian Marussi To: Geert Uytterhoeven Cc: Cristian Marussi , sudeep.holla@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, linux-clk@vger.kernel.org, linux-renesas-soc@vger.kernel.org, philip.radford@arm.com, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, etienne.carriere@foss.st.com, peng.fan@oss.nxp.com, michal.simek@amd.com, kuninori.morimoto.gx@renesas.com, marek.vasut+renesas@gmail.com, Peng Fan Subject: Re: [PATCH v3 04/15] firmware: arm_scmi: Simplify clock rates exposed interface Message-ID: References: <20260428201522.903875-1-cristian.marussi@arm.com> <20260428201522.903875-5-cristian.marussi@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, May 05, 2026 at 02:17:45PM +0200, Geert Uytterhoeven wrote: > Hi Cristian, Sudeep, Hi Geert, Thanks for having a look. > > On Tue, 28 Apr 2026 at 22:16, Cristian Marussi wrote: > > Introduce a new internal struct scmi_clock_desc so as to be able to hide, > > in the future, some of the needlessly public fields currently kept inside > > scmi_clock_info, while keeping exposed only the two new min_rate and > > max_rate fields for each clock. > > > > No functional change. > > > > Reviewed-by: Peng Fan > > Signed-off-by: Cristian Marussi > > Thanks for your patch, which is now commit 83fd9d34b6b75be5 ("firmware: > arm_scmi: Simplify clock rates exposed interface") in scmi/for-linux-next. > > > --- a/drivers/firmware/arm_scmi/clock.c > > +++ b/drivers/firmware/arm_scmi/clock.c > > > @@ -457,14 +466,14 @@ iter_clk_describe_update_state(struct scmi_iterator_state *st, > > flags = le32_to_cpu(r->num_rates_flags); > > st->num_remaining = NUM_REMAINING(flags); > > st->num_returned = NUM_RETURNED(flags); > > - p->clk->rate_discrete = RATE_DISCRETE(flags); > > This removes the last setter of scmi_clock_info.rate_discrete. > However, it is still used until the next commit cd73d1bfaa8d34bb > ("clk: scmi: Use new simplified per-clock rate properties"). > V2 did now have this issue, as the patches were ordered differently > in that series. > > After both commits, there are no more users of > scmi_clock_info.rate_discrete, so it can be removed. Indeed.... good catch, rate_discerte has been moved to scmi_clock_rates so the old public scmi_clock_info.rate_discrete is stale and no more updated...I will remove it. Thanks, Cristian