From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C620A347536 for ; Tue, 5 May 2026 15:03:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777993393; cv=none; b=CDsyMEQ7yhJKZMwqWkKxVouLNNwCn/VidbngC64LdmeMRZUDnzPKhY3qDd/NgY0BuL/eGGTpH90smO0HsW/iFy+ddMe6uY//9prnauQ+2FYeRua/20Xy8a/E182zbZubmEyYdWEOR+pQgKAzV/R7JAU4tKSq36id8LyDApEl4RY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777993393; c=relaxed/simple; bh=A9wpaSBbR1ublzL/Sy2zUllnDSEWVh69TzLmMcbXZ9A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nMm6VLOafNfSIUzvzrINjuEXquvpV7avE/Z5oK+tDuK8gU/HjpocURSzHxEIOv/D2TjoGyc9U6/eOqoGLUwI4vY2lEBFYvy5NVjlRxGXdTq0BIcoIYNaptgb5yGXMD12q0hgyAA6f1fGFP0WGDx0XYP7zMxQoThUjCECiYir7Ww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OsHsKd8r; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OsHsKd8r" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ad21f437eeso33340025ad.0 for ; Tue, 05 May 2026 08:03:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777993391; x=1778598191; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UKYwXEKBkfxrwukpDctwnP55c5ugAMD8+9dw4QCucpc=; b=OsHsKd8rK5oIhfHwRZbAUsyG9x1n8Qa724mT5Cj8TJHExm2iYXMRQaT5D1Z77hDyTI xA4cM1J85Eabfc1x8G8kOucgIS5NLfQLIfFzDZuHZmGvelW+kQzEXIZ/p7RjLRVhWVb6 H+GoFgOgt8N/IosJ7YGaivt8IaSVi67n4at9NhoTVeDxF8jLcQFBrm0dI85pTeGD8xw8 73jZP3RRLPr2uciV9Yuwyr6g7XVzgEEs8iLJbJRzRNnQ3/gpE1WzT3EClnD3GOt0xpY9 e72MJQ1xsCVfrVBPtlB8w+J232SS/XyBASUgjkrQtX7pdbRZFl489eRAQQ4x954YnNvr lsUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777993391; x=1778598191; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UKYwXEKBkfxrwukpDctwnP55c5ugAMD8+9dw4QCucpc=; b=M6cJX/vs96fJ4FVQulh5KGfQE47ykIA613tRmvv7gTxCaYMb15I+eEIPERFYJoOyBH 6xc5gmIHYH7pLCBU6Jgv/WJIz9OAqWzgtNZ1E3fL9zy9NHTpIemDsJCGTiwrKk7/YZQ0 exgkoEm/O1sa0yWWgX0pBVRNOu21OMT89h3UTuat9Xg+3G0EPPtA7PWi/5oHwgkBzw+m pbxmJLilQqbaVK5Kvh3qoxzT86jYT5UMnZSck6sVnh8bD5nf76cU1lNq0DtQ3jhXJ/2N j0yndhdwcR8fMqEoqUViJoatjaot8m+jWmn6Ea8XboXhRMD8Ac29vp8B50T1HeeRWTEo SVpA== X-Forwarded-Encrypted: i=1; AFNElJ80YMirxvQPEYseerWTjFVHsHAJJMJCgH3bm0/R3yUuyWbSmtNYtwbafWQ7joF/DNFOWkuAMrCbKQQ7Dn4=@vger.kernel.org X-Gm-Message-State: AOJu0YywJcLMV2Y+f5NLng4YaiB4bkIVaYPxMu9DsOOBuBKZSC3bzanC 4xbu5AswYl/toGrGsLp5Wb6nCjTnq0yqCMmz1LXQd0aTRvaFu6DbJx6T9qnUkA== X-Gm-Gg: AeBDies70Vdkg0aa41YuE8Ox9g1vhXNS+gykJREQMNKvPSWMJOEzz5L+wdqj6gARcN7 xarwGUTsDsgwQpagMvnZpVXgTwfAtQ9Z4WjGAbHupK//WOg/W+w+cfqG5RAR4KDelgatH28unlJ fH+UxA/iwxFzVem4gXbJUKrtEE+DursfTJylydka7jodUd0PeyLxevRzOGVHFYCP7VYmhydGmSD LGW2GuUirOpO5jnQBbmSVi7RFXFB6apA6miLZo/Y3ro1TvtHHGu6I3iMBK9irem6y4SFF05lnWt 8O80M5H0uD0EaTvP44tPZyjbfr90t+AoHJBwr/4TH8bnX+JLlANMXEXN7ds2xyuwsNCA6R7FRdr SzwPgcmapO8XHu8Vmd/w1mxnDTm9LcrNXIahxprT/n0w7P6xt7tHboDhmP1FtY+DMSI0TmDn6Hl WOLIRcVRLK00VNb3QcODKUDTwzbaDutRrr7CEKsxjaWojsM69JgaINsenLlxU5q2+MOLCJgl+KI AI= X-Received: by 2002:a17:903:3c47:b0:2ae:47b0:dc80 with SMTP id d9443c01a7336-2ba4d7aadebmr32397605ad.11.1777993389459; Tue, 05 May 2026 08:03:09 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:94ef:a6f3:2c96:2d58]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae366c7sm143554025ad.55.2026.05.05.08.03.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 08:03:08 -0700 (PDT) Date: Tue, 5 May 2026 08:03:03 -0700 From: Dmitry Torokhov To: Ricardo Ribalda Cc: Nick Dyer , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/3] Input: atmel_mxt_ts - fix boundary check in mxt_prepare_cfg_mem Message-ID: References: <20260504185448.4055973-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Ricardo, On Tue, May 05, 2026 at 11:08:15AM +0200, Ricardo Ribalda wrote: > HI Dmitry > > FWIW this patch looks correct to me... Thank you for looking this over. > > Reviewed-by: Ricardo Ribalda > > But there are a couple of things that look weird. > > 1) The patch line (1503) does not seem to match your tree > https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git/tree/drivers/input/touchscreen/atmel_mxt_ts.c#n1503 Yeah, I have an unrelated path in my queue that affects line offsets, > > 2) The sscanf just before this check has two conversions (val and > offset), but you only check for ret != 1. Should't it be ret !=2? or I > am missing something? "%n" format specifier does not increment number of successfully parsed elements returned by sscanf(). It kind of makes sense although may look surprising. Thanks. -- Dmitry