Re: [PATCH v4 08/14] clk: sunxi-ng: a523: add system mod clocks

[Paul Kocialkowski <paulk@sys-base.io>]

[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]

Hi Andre,

On Fri 07 Mar 25, 00:26, Andre Przywara wrote:
> Add the clocks driving some core system related subsystems of the SoC:
> the "CE" crypto engine, the high speed timers, the DRAM and the associated
> MBUS clock, and the PCIe clock.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
>  drivers/clk/sunxi-ng/ccu-sun55i-a523.c | 135 +++++++++++++++++++++++++
>  1 file changed, 135 insertions(+)
> 
> diff --git a/drivers/clk/sunxi-ng/ccu-sun55i-a523.c b/drivers/clk/sunxi-ng/ccu-sun55i-a523.c
> index 17a4ffc0b7f52..c59f3f789d052 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun55i-a523.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun55i-a523.c

[...]

> +static const struct clk_parent_data hstimer_parents[] = {
> +	{ .fw_name = "hosc" },
> +	{ .fw_name = "iosc" },
> +	{ .fw_name = "losc" },
> +	{ .hw = &pll_periph0_200M_clk.hw },
> +};
> +static SUNXI_CCU_MP_DATA_WITH_MUX_GATE(hstimer0_clk, "hstimer0",
> +				       hstimer_parents, 0x730,
> +				       0, 0,	/* M */

I was looking at the A523 ccu code and see lots of
SUNXI_CCU_MP_DATA_WITH_MUX_GATE with no M.

Was there a particular reason for not using SUNXI_CCU_M_DATA_WITH_MUX_GATE
instead? It would surely be less confusing.

One difference would be that the ops end up as ccu_div_ops instead of
ccu_mp_ops. Do you need ccu_mp_ops for some reason?

Thanks,

Paul

-- 
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expert in multimedia, graphics and embedded hardware support with Linux.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]