From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64F784921AE for ; Tue, 5 May 2026 16:39:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777999153; cv=none; b=PUSyQEWgqy2kQxyX+IcJOxbwf4mLcUlva2ylKqDAVpUl0GhLo5RELv9U/SK/bxYMbBvbEuddSqWjylSZd2EZ7dVVhTjz8uy/8lurpGLoJfVMsR6SNosFnpVGBa2tTtlKvE7wtBuXnI0kRZK6SzxlbzAaNI3LedrTaCiXrpFkWcQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777999153; c=relaxed/simple; bh=xyEx4G2wKir++EItxT2osj5+hfVEdh42Mr6R7Zl3tOI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jLx2ukil7lvUHp0hnfu5/4XEfBtPCR2MESRrbmmQLi0kZ05d3Fs4kUqA0ccB9WlQf1+iNXB/Bssb+zZCdXOdazB+4zl1ehyZInyksbw8sL4yJxMKIksEW5va8RrCG/CK/Yi3KVdX1O30bFHuRMRwM7uaoL1FkzVPYVTkjU4Eli0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=M+F8y2Fs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VuMFEPFL; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="M+F8y2Fs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VuMFEPFL" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 645Cn1tb3187637 for ; Tue, 5 May 2026 16:39:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=kcvBYxHAlvNI6sLP0AoxikyR e9LehpKzs6txgD8Qv9A=; b=M+F8y2Fs4/hg36XqYjUZ2aG/CZNEeOdd7UKhLo9j 8Y0UqL088LknMkhUQRRyzARuoO+oNdGh9YxrOOAxY/U7s1HsLB3jq8q8b572Tqb5 2J2XraWuZBz9LdfA9uEUNIDzVwbtTmdX/TNaSRaMM6PHAW6gsR0T2etdCqgyjR9W OtKYqNDll3aDE4gWGrusBKXkSTVYtXtVbLt7Z4gD7cN8n6QH/CpYQCimZn7DQWrF m3GQg+lAgKMKOaKN63Lthabq8F8NRozdfQsqR4fdsT1/DalMjesfDByXRSWYZ8Ws d0ZxdzHiQipQdq+w9AFeL3epabsWRpQeHSAmWpEXG/tBww== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dybkkaaqs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 16:39:08 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2aad5fec175so73832965ad.2 for ; Tue, 05 May 2026 09:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777999148; x=1778603948; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kcvBYxHAlvNI6sLP0AoxikyRe9LehpKzs6txgD8Qv9A=; b=VuMFEPFLEnWQfKlZNxTOy21MJ4cTuCEYI+jFFeGNEuyLcV61JFa2+/bg5tns4qzngr +V438+52M4/+U12YdSyhzaytn22IZ3Ca5TNE089SIsSAMs4YicVY1RGxrW5ki5xmbdMZ P5BHwB+e3rXSdElDvbIYTJtmC5ixF6zRKor+UYDFWgBRY951cUmuDXnSEAGHZbdNVOSk y0fOQY39aHi3gpRKiC0JWq271Ps1eER2XrDly2dZ60B79naNbPkMJ0QdOndwIY4I8CjS EDA2SliByOW6fQpnoY6tBsUSjmS1kSa+xcu9JPyrpzsG0QCWT/modDBSGCppXq2yKveV S1Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777999148; x=1778603948; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kcvBYxHAlvNI6sLP0AoxikyRe9LehpKzs6txgD8Qv9A=; b=q0mE00DjMy1fFMCB/mU8nI5aPVK0dMUUgXvmFNmiYL3xe1rHmOyGSe6Y89cDcHUSHT /se6bwHGR3SiWi6Tm2nAAqUy0gPUuCqeE9C/kEF5Rc4Um+IzCa2a8f8xNhVrRORYvzKf yZO6pCRuMb7+l01zxhCGyFK4db3a3Tc2qC+GmZFQa/aZw1xi6q+pC2uQ030+LjKqup/t ApectUrGVikwtJ328a6EG+fye16AeoF8/XzCVgR5gck+Bkw/97qa0aRM0XulDoriqWDH o/FSLHgS9zVl06n5dIA5k15zB+APcJsuRCdZLQ+AlfZbXbCeAF7FKllmzfG6QzhYW9dJ y1dg== X-Forwarded-Encrypted: i=1; AFNElJ9VkWqUs0x7yttYqkpFVQI1iWvcharlYzkv1V1ATwpdkACVXWKl5i0mPgmaFzWRS5+NdwL/IkLS7In4Qw4=@vger.kernel.org X-Gm-Message-State: AOJu0YxNy2W4EtOK4ObNmGrhAtjgzs+qlV6fbSxTI560+pOYlvZLqWvH Tbqp0vUbMG3RSVhxior+UfOlKa8NYLMz94yL6dxCb8RyVUwKPaNgRHhaCwBcdDu8SQoxXDOUDYL 4TKekINk0cai+6UO5jCAvJ76auFV4yztiTVPnXpz9Gg5r+zGpe0wWECEKHBjjY9lqe98= X-Gm-Gg: AeBDietOtM4wErIoy3NDXMcVZp5oolDl9o7fNS98vkF8w4rZvW8nNZQBo4HTC4b77uw YNUBszC8q/8q+XixKKB348ldiICKsp3lxIfJkydhqbtKk8YW+AVcfgXcMBgcGfc9I25nN52UrA5 h0gG1lhx42i9J+nzqjrZ/drFAaVRyNzZ+90pVwtm/xvMn/zd80Scuo8dVdwMDWPX1zN2qzOpJTN 3vZ3yh7gyEUt9WuHlep+XlZf0+f7eLyZc9/dXjzVEpGLMR55mM9PROo3bVnPICYLS+UKW1NGqAf 2nUwILmZz3IMTxYfhxjyT3iivamTkLnwdb8lWyYQSN0cz4kbq0J12kV/KQiZz5dTuraJGKbxK4h TdwzCOsOK2d3SAPghjU2GELCTjVGJ89eGU1sJR+UaRu1T0g== X-Received: by 2002:a17:902:ebd1:b0:2b9:eb6a:68b5 with SMTP id d9443c01a7336-2b9f28348efmr149463615ad.38.1777999147955; Tue, 05 May 2026 09:39:07 -0700 (PDT) X-Received: by 2002:a17:902:ebd1:b0:2b9:eb6a:68b5 with SMTP id d9443c01a7336-2b9f28348efmr149462845ad.38.1777999147261; Tue, 05 May 2026 09:39:07 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae15fb6sm148392135ad.43.2026.05.05.09.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 09:39:06 -0700 (PDT) Date: Tue, 5 May 2026 22:08:51 +0530 From: Mohd Ayaan Anwar To: Alex Elder Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com, rmk+kernel@armlinux.org.uk, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, Daniel Thompson , a0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org, boon.khai.ng@altera.com, chenchuangyu@xiaomi.com, chenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org, hkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com, julianbraha@gmail.com, livelycarpet87@gmail.com, matthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc, prabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com, rohan.g.thomas@altera.com, sdf@fomichev.me, siyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com, wens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 10/12] net: stmmac: tc956x: add TC956x/QPS615 support Message-ID: References: <20260501155421.3329862-1-elder@riscstar.com> <20260501155421.3329862-11-elder@riscstar.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260501155421.3329862-11-elder@riscstar.com> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDE2MCBTYWx0ZWRfX3B/CSYdtY1yW yQyBUxE6gqMxF7QT2uin4R8SuLgeN9Z80zB1VLCP+IWSfq8sBvRFG4AFQDjBg/sygnVj0SfWOw5 Tn4v8Cmqq53F1etY/6oXdl7Sskou6Y60R9fJgDBbOsvPvYLXS9mXpRF3lcLzkYRh/0VWAJtZGEF FMeXjy1p1YQdplyBfkUd/8mQC87SLBpo8e7Oa3EfhK2aZ7Q6inMD3sGe1bQ02+IafIjVD1wZSLS HjlSJvs4uFGyeSTGCrw1hlIrQi6ea9S1/8A2jBFwLVP2sNNU/FbqdyKxTTxr0hkfiaDHIZ2oeI4 pcUI7m79HBmHSiqVBVTQSSmHo6X37Ub+VvTphtEpX4gd3t2zY5K8LfWyYTjm/UHuZwhKaKq3pry nzW/FqKV4Q8DY77rEBuaHyvHA2aBevcyLICCnH5LuNb9cBpwwDfYXiUbpP/Acdu0W4Z6hop0ioD 6CD1mbkH603kOn99pCQ== X-Authority-Analysis: v=2.4 cv=SPBykuvH c=1 sm=1 tr=0 ts=69fa1d2c cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=YOnX06L-6IeA1UCcW-kA:9 a=CjuIK1q_8ugA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: TMmh6Fwkx3lzpftqhMLj-LgwDmYERkGP X-Proofpoint-ORIG-GUID: TMmh6Fwkx3lzpftqhMLj-LgwDmYERkGP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-05_02,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050160 Hi Alex, On Fri, May 01, 2026 at 10:54:18AM -0500, Alex Elder wrote: > + /* > + * TX956x has 8 TX queues but only #0 to #3 work for general IP traffic. Minor typo in the comment: I think you meant TC956X instead of TX956X? > + > + for (i = 0; i < td->plat->rx_queues_to_use; i++) { > + res->rx_irq[i] = irq_create_mapping(irq_domain, HWIRQ_RX0 + i); > + if (!res->tx_irq[i]) Typo: res->rx_irq instead of res->tx_irq. PS: I was able to successfully test this series out on a Rb3Gen2 board. Ayaan