From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from h7.fbrelay.privateemail.com (h7.fbrelay.privateemail.com [162.0.218.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B55E35CB76 for ; Tue, 5 May 2026 18:13:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.0.218.230 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778004816; cv=none; b=OIURJWAPsNh5veryKv1d6HbFfoDFcGUwwhqGv16EOhH7MbuZe+Mcl7QBWirAM54ed5i2wEiHodRXF997DKRN7X6fvBMKfhEoic6MB0NIJ1d7tUIFg1TftzYttv8SQpUmRNRi6biTuEdH9kcqdQ91qetnUf4Bpngmy5s2mo96T/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778004816; c=relaxed/simple; bh=C05YLSuSc4gdWzJTSMCjpFXnVQB5UiN2s9lGL3ppFyI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rPT+C6I3hy7QMatBYXaguKs4HACmJC+MnRLQgjuCKE/b+UqgRKfwx77iUvU1QXnYH6NtVTiMgFY9y2WL0AuAEAi0dNRmvLfu7YqF5CHZmgrHR+t2UAsdZnpXX4+R1mKAxOLmB2O5BgiJKtIoN8GyCaGXRs6VJTz9FW69TMG7EXM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=effective-light.com; spf=pass smtp.mailfrom=effective-light.com; arc=none smtp.client-ip=162.0.218.230 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=effective-light.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=effective-light.com Received: from MTA-11-3.privateemail.com (mta-11.privateemail.com [198.54.118.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by h7.fbrelay.privateemail.com (Postfix) with ESMTPSA id 4g968F3GBnz2xK6 for ; Tue, 5 May 2026 14:13:33 -0400 (EDT) Received: from mta-11.privateemail.com (localhost [127.0.0.1]) by mta-11.privateemail.com (Postfix) with ESMTP id 4g96846HKYz3hhTh; Tue, 5 May 2026 14:13:24 -0400 (EDT) Received: from hal-station.localdomain (bras-base-toroon4332w-grc-26-174-91-51-28.dsl.bell.ca [174.91.51.28]) by mta-11.privateemail.com (Postfix) with ESMTPA; Tue, 5 May 2026 14:12:50 -0400 (EDT) Date: Tue, 5 May 2026 14:12:47 -0400 From: Hamza Mahfooz To: Mario Limonciello Cc: dri-devel@lists.freedesktop.org, Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Alex Hung , Ray Wu , Wayne Lin , Aurabindo Pillai , Timur =?iso-8859-1?Q?Krist=F3f?= , "Mario Limonciello (AMD)" , Ivan Lipski , Chenyu Chen , Matthew Schwartz , Yussuf Khalil , Tom Chung , Roman Li , Colin Ian King , Charlene Liu , Kees Cook , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/2] drm/atomic: attempt full modeset on page flip timeout Message-ID: References: <20260501203552.749080-1-someguy@effective-light.com> <5dd93e29-a076-491b-9861-e08a0204c77d@amd.com> <8de14305-b4bd-43eb-9025-f9d210ee125b@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8de14305-b4bd-43eb-9025-f9d210ee125b@amd.com> X-Virus-Scanned: ClamAV using ClamSMTP On Tue, May 05, 2026 at 10:32:57AM -0500, Mario Limonciello wrote: > > > On 5/5/26 06:41, Hamza Mahfooz wrote: > > On Mon, May 04, 2026 at 04:50:21PM -0500, Mario Limonciello wrote: > > > Do you actually need to set all 3 of these to true? > > > > > > I would think you only need: > > > > > > crtc_state->mode_changed = true; > > > > > > > According to my testing `mode_changed` on it's own is sufficient for > > amdgpu and the documentation [1] seems to suggest that it should be fine > > more broadly. Though, it doesn't seem harmful to set all of them just > > for safe measure. > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/drm/drm_crtc.h?h=v7.1-rc2#n118 > > My main concern was it's safe right now, but what if future changes to > atomic control flow mean it executes more code paths than needed; or worse > unexpected code paths. Point taken, I'll respin this with them removed.