From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1E9D72627; Wed, 6 May 2026 02:50:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778035804; cv=none; b=AxLfiGiVK1WOpL4nd0HtJ9Vk+AQqDF68tZHQXNJWPka0GMZ0BP8u8mwc/2y9aCDlYxvRi5D4tp/anVutu5aZ2Q2dy1VGqGBKLMQXPpTunq1V9+wAdXw6aDj+Kd5FEXIOBfdvcF2hrJCpggt95PgG8c0e4hLV6RahKmVl0//oJ2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778035804; c=relaxed/simple; bh=9Zp6weps/5i0bic4zLcKMfZvfoo875xrUuifN3/il+U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ipqloIpled+jSGMTQOoYjWeb4/UAhExXr9xTXfBMQ0COvBM8gDq2b6sUe3ud/FAnp1qW06nt4VQqCLpcNCS5MqmIFCjds02j1kiXMjGBpWFYYkSRAhhDK8ZrfXBcFJHiHr1l7IKhVSSlKjNBDj0fdDvryG7+XGk9pZ1npk/JFlg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BFSVwFmu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BFSVwFmu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7820C2BCB4; Wed, 6 May 2026 02:50:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778035804; bh=9Zp6weps/5i0bic4zLcKMfZvfoo875xrUuifN3/il+U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BFSVwFmuFDrQZSHs0jRdNiiat100r3VhPb+RdSmbPZaeyzbXt3kjIc5204csi3fmv 8DmvceFufkt0gK0cBt2vTmWAducwVcTkbB0cfPVXqDS3jvgw2kDv6M1M9OaVAdNz6V YsIti6u8JHQxWeOJBLabNU67GtpsDY0kIoLnxiQyXT68PfBn1uQcKjV32oTtDcrW/N VvWyRoPAhsu3Y5iRq9BcNdXMtAUYnj8rN4QeXp1ONTbwV/JI9R3RXLTW1xaKut/4G/ OggD4wSBMLUGEFNFp9NrZiGdyg6oWSKpdQ3IOeKA1s+Aa9S4+XDRJoSLz2MqpsBMLN 4fIb61GXo4wZA== Date: Wed, 6 May 2026 02:49:59 +0000 From: Tzung-Bi Shih To: Krzysztof Kozlowski Cc: Lee Jones , Pavel Machek , William Zhang , Anand Gore , Kursad Oney , Florian Fainelli , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Broadcom internal kernel review list , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Benson Leung , Guenter Roeck , linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev Subject: Re: [PATCH] leds: Move MODULE_DEVICE_TABLE next to the table itself Message-ID: References: <20260505102846.186219-2-krzysztof.kozlowski@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260505102846.186219-2-krzysztof.kozlowski@oss.qualcomm.com> On Tue, May 05, 2026 at 12:28:45PM +0200, Krzysztof Kozlowski wrote: > By convention MODULE_DEVICE_TABLE() immediately follows the ID table it > exports, because this is easier to read and verify. It also makes more > sense since #ifdef for ACPI or OF could hide both of them. > > Most of the privers already have this correctly placed, so adjust ^ d > the missing ones. No functional impact. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/leds/blink/leds-bcm63138.c | 2 +- > drivers/leds/leds-cros_ec.c | 2 +- For leds-cros_ec.c, Reviewed-by: Tzung-Bi Shih