From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFB5D3CF695; Wed, 6 May 2026 07:45:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778053510; cv=none; b=XRbrw6Ld52mTRlAmwxZTxGFawR2OPWBw0yjbfejk81ZZoC4TEgGNCnI+BbEh3JXxHpzNyEl65zh4YNdKrYpHerCWlao/Yh/kw7lAu6suaRya9eON03RXJDw83hPsoirnlc0FMe8RBLei3PnSvE1QIpAeevl/RdnJ8T6uq5z/y10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778053510; c=relaxed/simple; bh=/SSiiVNcG6Dr70JSz9aZJkOI5mbAtoVtckNTE0FlKY8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fSTj4kRtGPFfGSWtJDTbe+CzI1yhibnIPkoB0USHAIk9R1XKYueGmE/YF0IvpYdnCx30sETEtFz/Xdjsf5eEyUVdEwl0tgutd9C5f2u6dmiQH3OZzgKNU/qEhqO5M04o551SzlxxRelJtQ1wnyF0IkgkREdVqilBGpv+avmquCk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=DUX5hekG; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="DUX5hekG" Received: from ideasonboard.com (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A658378E; Wed, 6 May 2026 09:45:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1778053500; bh=/SSiiVNcG6Dr70JSz9aZJkOI5mbAtoVtckNTE0FlKY8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DUX5hekG/CQLhLakH0Pjl+6O0Fu8KM1hvEyjk0H45jER/AfAJUoccRNkxrWoKfF+o OkHbpUZRrpWD6NtqNk9ZZkRAdBgswqiyIzGZeCxyMbFd/mWsH/7h+NUD59RnSU8lR3 +omdbPDe5cwLhZG5KtX3EETLmwh7P2bQvGqZq4bk= Date: Wed, 6 May 2026 09:45:00 +0200 From: Jacopo Mondi To: Niklas =?utf-8?Q?S=C3=B6derlund?= Cc: Jai Luthra , Mauro Carvalho Chehab , Kuninori Morimoto , Jacopo Mondi , Laurent Pinchart , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v8 01/14] media: Add RPP_X1_PARAMS and RPP_X1_STATS meta formats Message-ID: References: <20260504010556.2796398-1-niklas.soderlund+renesas@ragnatech.se> <20260504010556.2796398-2-niklas.soderlund+renesas@ragnatech.se> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260504010556.2796398-2-niklas.soderlund+renesas@ragnatech.se> Hi Niklas On Mon, May 04, 2026 at 03:05:43AM +0200, Niklas Söderlund wrote: > From: Jai Luthra > > Register V4L2 metadata fourcc codes for the Dreamchip RPP-X1 ISP > parameters and statistics buffers. These formats are used by the driver > to exchange ISP configuration and 3A statistics with userspace through > the extensible parameters framework. > > Signed-off-by: Jai Luthra > Reviewed-by: Jacopo Mondi > Reviewed-by: Niklas Söderlund > Signed-off-by: Niklas Söderlund As pointed out in the review of the previous version you need to add documentation for the formats in Documentation/userspace-api/media/v4l/metafmt-dcc-rppx1.rst (or similar) > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ > include/uapi/linux/videodev2.h | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > index a2b650f4ec3c..cd3f4a86e27f 100644 > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > @@ -1471,6 +1471,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) > case V4L2_META_FMT_C3ISP_STATS: descr = "Amlogic C3 ISP Statistics"; break; > case V4L2_META_FMT_MALI_C55_PARAMS: descr = "ARM Mali-C55 ISP Parameters"; break; > case V4L2_META_FMT_MALI_C55_STATS: descr = "ARM Mali-C55 ISP 3A Statistics"; break; > + case V4L2_META_FMT_RPP_X1_PARAMS: descr = "Dreamchip RPP-X1 ISP Parameters"; break; > + case V4L2_META_FMT_RPP_X1_STATS: descr = "Dreamchip RPP-X1 ISP Statistics"; break; > case V4L2_PIX_FMT_NV12_8L128: descr = "NV12 (8x128 Linear)"; break; > case V4L2_PIX_FMT_NV12M_8L128: descr = "NV12M (8x128 Linear)"; break; > case V4L2_PIX_FMT_NV12_10BE_8L128: descr = "10-bit NV12 (8x128 Linear, BE)"; break; > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index eda4492e40dc..1f78b5378b3b 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -889,6 +889,10 @@ struct v4l2_pix_format { > #define V4L2_META_FMT_MALI_C55_PARAMS v4l2_fourcc('C', '5', '5', 'P') /* ARM Mali-C55 Parameters */ > #define V4L2_META_FMT_MALI_C55_STATS v4l2_fourcc('C', '5', '5', 'S') /* ARM Mali-C55 3A Statistics */ > > +/* Vendor specific - used for Dreamchip RPP-X1 ISP */ > +#define V4L2_META_FMT_RPP_X1_PARAMS v4l2_fourcc('D', 'R', '1', 'P') /* Dreamchip RPP-X1 Parameters */ > +#define V4L2_META_FMT_RPP_X1_STATS v4l2_fourcc('D', 'R', '1', 'S') /* Dreamchip RPP-X1 Statistics */ > + > #ifdef __KERNEL__ > /* > * Line-based metadata formats. Remember to update v4l_fill_fmtdesc() when > -- > 2.54.0 >