From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Maxwell Doose <m32285159@gmail.com>
Cc: "Salah Triki" <salah.triki@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: humidity: ens210: Fix missing I2C functionality checks
Date: Wed, 6 May 2026 11:53:29 +0300 [thread overview]
Message-ID: <afsBieJ3u2onJVyp@ashevche-desk.local> (raw)
In-Reply-To: <DIAX965B07NK.16AH0B7XEZSUN@gmail.com>
On Tue, May 05, 2026 at 12:33:36PM -0500, Maxwell Doose wrote:
> On Tue May 5, 2026 at 12:22 PM CDT, Salah Triki wrote:
> [snip]
> > if (!i2c_check_functionality(client->adapter,
> > - I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
> > - I2C_FUNC_SMBUS_WRITE_BYTE |
> > - I2C_FUNC_SMBUS_READ_I2C_BLOCK)) {
> > + I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
> > + I2C_FUNC_SMBUS_WRITE_BYTE |
> > + I2C_FUNC_SMBUS_READ_BYTE_DATA |
> > + I2C_FUNC_SMBUS_READ_WORD_DATA |
> > + I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&
> > + !i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_EMUL)) {
> > return dev_err_probe(&client->dev, -EOPNOTSUPP,
> > "adapter does not support some i2c transactions\n");
> > }
>
> This alignment doesn't look right. Probably should be something like:
However the end result is wrong, this one...
> if (!i2c_check_functionality(client->adapter,
> I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
> I2C_FUNC_SMBUS_WRITE_BYTE |
> I2C_FUNC_SMBUS_READ_BYTE_DATA |
> I2C_FUNC_SMBUS_READ_WORD_DATA |
> I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&
> !i2c_check_functionality(client->adapter,
> I2C_FUNC_SMBUS_EMUL)) {
...is also wrong.
if (!i2c_check_functionality(client->adapter,
I2C_FUNC_SMBUS_WRITE_BYTE_DATA |
I2C_FUNC_SMBUS_WRITE_BYTE |
I2C_FUNC_SMBUS_READ_BYTE_DATA |
I2C_FUNC_SMBUS_READ_WORD_DATA |
I2C_FUNC_SMBUS_READ_I2C_BLOCK) &&
!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_EMUL)) {
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-05-06 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 17:22 [PATCH v2] iio: humidity: ens210: Fix missing I2C functionality checks Salah Triki
2026-05-05 17:33 ` Maxwell Doose
2026-05-06 8:53 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afsBieJ3u2onJVyp@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m32285159@gmail.com \
--cc=nuno.sa@analog.com \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox