From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4DD43ECBEA for ; Wed, 6 May 2026 09:46:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778060768; cv=none; b=pYOVKxRzJQIhAydPOGB1yeLsBLowSdYVunP6GZb684veIlXDl/ySUOlsXXBqasG8b6OnXQ/YUbw85kiX7ZfNKDhMCI4uqI0y+EFdJtkdQOsgm4uIY0FFNeMXriop7jK4K3JYOqdrRtzUmwTVg8kqj63JwFFt3ZveF6XcvJwDqEU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778060768; c=relaxed/simple; bh=UfLP1tUzO3A3YXd/nCpoke2Vqju/wUSSq/yG/FR+WW0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WD3PcdNXp4CCB9KJZAxrT7wlbfuaOrbBaqFZk9fFnP/Q1uFhEOHplTmFZrak9N2W8ejzT3DTCeroAwlPLL634UWX3mRTe0OvwuzVmIEUz2sfkfDkgX5VI8lNDPaDYNbS1cppOAuqwzyEOOR+Eq4Pyjc/9kgQVheLhRKv8ZXkLRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=qf95NCfx; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="qf95NCfx" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48a7fe4f40bso66539395e9.0 for ; Wed, 06 May 2026 02:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1778060765; x=1778665565; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jvO5cR5xwJ6Wruq4xsZ8UnvszQRGf9f2UYLH+AJmPFY=; b=qf95NCfx8eT8q+22AmgDAhodGtcSDNymauOoWGWblOztJb5IKvE6NaVvy3K+b+D8i/ c9Y8lg72wraLqzTH0qEnVPAtIfQOJlUlSZCIq1gMShmOkMHVvMfQ0VQYeFpRAzmQssk9 vIerJMRrg66l8fQCySh2uxli7IpQszcZahsyJ/8YYthhm6qj1wkLXF1n8R3uCUXWFj5o lkJlUgz5frR5fjSYlmyuQV/P96ZyqGmzZsPvfp64RCJ6JdKDd/HpNqBUTb0el0RcvyuW Hia7rf2sTxsMoiE2s0SGV20z2+TzaHiSq+H4zCrxtAffDGsZeaO7KtkcgYhqTsNyRvps 9GlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778060765; x=1778665565; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jvO5cR5xwJ6Wruq4xsZ8UnvszQRGf9f2UYLH+AJmPFY=; b=itjIORspj0UmevzkibYitS7ZndtFiohTzvoDabX+pkdDZo6brmhq1aXhecZ3THUUui veuwfMHw2lSJi8AzFOXLIxbYJT3NjdLdecsGv3691ZlknCGSuUgKdTwQpexab6LtVQCn h0UhamUXNI8Tmh4sXubBjbmmDVjuvOzb5radCzcktQDKwd0zBoEuLect9FfdfriP6oBc eZJGPOhy26ghQCZXvtq+24hMFQZs5n3Me+quGKZHTKH2YP9lMejiWumr7CtKDy8pC4dT ICWBIblGO3GbvnsniD8RMqXt+vqwSaVL6nFqBmYRH8GKd/jpit3V/hbI2YiooslItYru V5sw== X-Forwarded-Encrypted: i=1; AFNElJ8pzvzD/0zJj13gha6nTKDTKTyl50Mksee6gnynKF5+H8TlgrycNA+4cOFDGtH9aqTS1sQf0saFKnrjuCE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxv6Cdx+rsL6oi3kcCYPKxRtxA5oeN93mw+mSLNlqW2XH+NlP3l 21HNXywse81JnjCSPErST1jopH3HsS3/ceYgV26pr5t+eq1xmfD/FhQMS5h1xsbBLVU= X-Gm-Gg: AeBDiesmmf1XMlRhEoWxrBchG6NfBjc+OQ3/rW6AYLTW7mCQG0SnLCFyFSnc1Rc2WQa 8HOonS6WjrtMftwANFgwCvD0I4ZCsIdAUeJCY/9O5DMY75ysocjdawEqVGO3CBvYHkglnrGkQbo sGXaSTLjy1F6dlE/9X/k0YG/ym1FSiKsrWf1u+PZJUFUiUkCnOg11ES05rPrVR9cdrzNYghj1Iu AMPpQXZZQVjrHVym1iTPgPNr4yDV02wb6uzzo3Cb3yaR5d0opvuYQC8okoguxS2H9aZfNnpT3d0 WWsSCe1ySjHJlwkleDmq1HJ6DD4pYSzVuLA8521/xxx8ePJLEL4kJDFLfI5ZUfb8ONaFMC1IgEc wP15dgXOtOhx/YuGBfV6Rifef18KjfS3ciDzDm14MdOuvK9VhzkYOa49VpWVQSZnIvtOCOf9ocm +31bq4B2DdodCtJwBwaXScmer5OUqlLBaArXgQVEhiB3fjSVDrCviUWh2f0awl78L/6qbBOmygC TiGciiyROdwEQZTpDYfFqDb8S5sI8CZzeeCKl5EwoXBmEIu8/P2v4GrAb8KLEd6xznTcRVVs/6b XP0WyzUBfc4OjVMA4Q0= X-Received: by 2002:a05:600c:a305:b0:48a:5970:2005 with SMTP id 5b1f17b1804b1-48e51e08362mr31054235e9.2.1778060764831; Wed, 06 May 2026 02:46:04 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e5313b023sm19233185e9.5.2026.05.06.02.46.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 02:46:04 -0700 (PDT) Date: Wed, 6 May 2026 10:46:00 +0100 From: Daniel Thompson To: Andrew Lunn Cc: Alex Elder , andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com, rmk+kernel@armlinux.org.uk, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, mohd.anwar@oss.qualcomm.com, a0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org, boon.khai.ng@altera.com, chenchuangyu@xiaomi.com, chenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org, hkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com, julianbraha@gmail.com, livelycarpet87@gmail.com, matthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc, prabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com, rohan.g.thomas@altera.com, sdf@fomichev.me, siyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com, wens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 03/12] net: pcs: pcs-xpcs: Preserve BMCR_ANENBLE during link up Message-ID: References: <20260501155421.3329862-1-elder@riscstar.com> <20260501155421.3329862-4-elder@riscstar.com> <91332fc1-11ed-444e-a211-699420cf0108@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <91332fc1-11ed-444e-a211-699420cf0108@lunn.ch> On Fri, May 01, 2026 at 07:06:15PM +0200, Andrew Lunn wrote: > On Fri, May 01, 2026 at 10:54:11AM -0500, Alex Elder wrote: > > From: Daniel Thompson > > > > Currently the XCPS found on Toshiba TC9564 (a.k.a. Qualcomm QPS615) > > is unable to operate at 1000base-X and slower with a PHY connected > > using SGMII/2500base-X (in our case a Qualcomm QCA8081). The link > > negotiates speed correctly but the MAC can't get any packets out. > > We need to break this down into its components. > > I assume you are saying the PHY negotiates the media speed with the > link partner. That is PHY talking to PHY. > > But we also have the PCS talking to the PHY. There can be inband > signalling here, for SGMII and 2500BaseX. But not for over clocked > SGMII, which is how some vendors implement 2500BaseX. SGMII signalling > does not work when overclocked to 2.5G. > > > This attracted attention to the ANENABLE bit and we observed that the > > bit is currently set during config and cleared during link up. > > Here we are talking about the PCS ANEBNABLE, not the PHY ANEBNABLE. So > this is negotiation between the PCS and the PHY. > > > Preserving the bit during link up allows the system to work as expected. > > > int ret; > > > > if (neg_mode == PHYLINK_PCS_NEG_INBAND_ENABLED) > > return; > > Think about this. > > > ret = xpcs_write(xpcs, MDIO_MMD_VEND2, MII_BMCR, > > - mii_bmcr_encode_fixed(speed, duplex)); > > + mii_bmcr_encode_fixed(speed, duplex) | an_enable); > > And mii_bmcr_encode_fixed(). Thanks for highlighting that... and for being gentle with the clue stick! This patch will be gone the next time this patchset is published and I'll get the phylink configured properly. Daniel.