From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DA23330D50 for ; Wed, 6 May 2026 13:19:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778073588; cv=none; b=s17wjXdo/inPnySKSEzjTBC6mrjDCGdiBnUesk2+r8Nclg83I3wnF6egxC6krcm6tLaCvWBUn6h4twYmkzNZGYgJxZWxavFfxX5wtdTHHAIW+fT69/BxXBREjZ6o78rFs5N/wHoFbYLSjLmgqNtQi1zDFbMwWhcopCgBSunLH/0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778073588; c=relaxed/simple; bh=2RDWB3a4ibe3jXpjt+mEzvFJ+Gcn0n0crbbGfOKe9cs=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aZA6fRcBNewXdtgl2pZEOJtblIzr1DbjxMgUdKg+sFACYErLEHcJNqRkJ2nPyLCVjtL23/KadvfI6YKCO43bnxsmA3gng605FhRJZLLoT2ymMijvM0kYVzJucmRl61BqmNXt3wGpovbaXR1aNKqiJk8jRH2Z45nZlA1yvhjVic8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PdE5VVbE; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PdE5VVbE" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4890d945eb4so5853005e9.0 for ; Wed, 06 May 2026 06:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778073584; x=1778678384; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xGV26fxWeaXiY9rUme+lA6RZN5rDKEIrxGsO7OEUy+c=; b=PdE5VVbEmU1P9sC/wELiqmG7kpcfYuSXYrs57JbeshN8Vi3mvvTAzCfs4aR1v4CAag jEptRL0aB89Lm5+STkss8Lye7uHPtpg7poZ1dAOvrFW6Kdh1wq9NeOvz3P3+9eIq7KoH JVjH/RIKTmcqSkUQx/cOSXJS2qsLfWJovM7BzLZVzzIdQJceixbXRuMYea2kBiYVo02g bZ1tgnPSwvMte0JmWDal3Bte0Q7w8VEoZNQrTwybPYI4RizzMMmxgnEgSgSXqArKZsfL xNjYMlFUiZ7GR9ym7P3a5zdbtyKOSQy40NGN7Xl77ox3zOfrgQwtyJnrZSkP1WjiJ21u mZQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778073584; x=1778678384; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=xGV26fxWeaXiY9rUme+lA6RZN5rDKEIrxGsO7OEUy+c=; b=Swc+e6gdYotS9ZH4b5qfr7ixPolu81CO57aBwHIs17F62PbPMqFRnANqFhKjoC9aJB rnIuWijZE0+Y1wrtzJe6x7ZKakSn7JIqnQlj+PfbrvVA+3JtN6eph2pju5J0hZzQr3zf hRn8TSGKYF5RBRfVAoMyKp7EOL9ICuAuLhzPZgRp64iDEJWuceB5DAMGZNVaHNNwIy0X Ry+jsrzXB1N5yXUrjHBauVjnzzNhU9kUO6THj9hN2Aqp2uC1ahEnQR49dP9lSft91JTO Yb+xy616EAHcNluu16cnbqFHzlq6m53DRwojCGSsm4TgSz2lA2F8yNFMKcNPRL0OM4Rx gJHA== X-Forwarded-Encrypted: i=1; AFNElJ8eVuZ7q1fWpxG/WJFpysNuQay38a+Zurhy0wXjTDC89mZcnLhlAG/jF45RBMwG9CgTdKqYjkpqM+82Txg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+akBkpvXYIOgtdOMZ/kMJzhZzRqD7Ozotyhkh2Fm9g9mUWHgO fewAfx77EvCKvttdZpjT6GcvCGDkx8eW0cATsAiX5NAEOrAHsyhwcqlJ X-Gm-Gg: AeBDieuV4iw2vcK7It5+o9NZvNs7/tvzac2BNZUN+4kyYAc8XoBl4AEhqxP2JglN5Xy WDy29i/SMX7R/ohEB7sSU9o8GEdicSduHfsDY+OG87Uzbslo6Sokd720jTCr0guE2VAKiJDqWcb xurhcuvi/tpt9BrUGSgk+pvGpulOl5zQG/UVPBkmpBt842u6UeBVbhMGZkuCHsyiEZ3K7nnEh8W XT9sIKkWIH84KycsS7CCf+2tqjS1dLCF4dJB+XaOcWRp69ANjJ8dJY12VBogGa2v5kAz9PLsazx qKklvz8iGKdo7OnwtXBZKFkDcMr4TaBpqbyhEaisF7djzo32UtnNFaYFH2+qZqgzsEPgHFgBxz0 o80tdHt/QF1dC8TzLxlzq2/ujdwYOx/xGQnYj+ERvZsA4GN7E4LgfQR2zz9Dle/qqJ51ISezDlg vC9C30b9Yz2yQ1GMzB8d7NdAhaheHYImfXExqFy45pqG7eRWfkf9u+y3eOGaNytRd0jeT3Jz5u0 d7Yse0= X-Received: by 2002:a05:600c:348f:b0:485:3cef:d6ea with SMTP id 5b1f17b1804b1-48e522c0854mr52865865e9.13.1778073583834; Wed, 06 May 2026 06:19:43 -0700 (PDT) Received: from osama ([2a02:908:1b6:8980:89b3:e462:e9ca:df27]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e538acbfcsm44485185e9.8.2026.05.06.06.19.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 06:19:43 -0700 (PDT) Date: Wed, 6 May 2026 15:19:41 +0200 From: Osama Abdelkader To: Catalin Marinas , Will Deacon , Ard Biesheuvel , Ryo Takakura , Breno Leitao , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: panic from init_IRQ if IRQ handler stacks cannot be allocated Message-ID: References: <20260326225755.50297-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260326225755.50297-1-osama.abdelkader@gmail.com> On Thu, Mar 26, 2026 at 11:57:52PM +0100, Osama Abdelkader wrote: > init_irq_stacks() and init_irq_scs() may fail when arch_alloc_vmap_stack > or scs_alloc return NULL. Return -ENOMEM from both and call panic() once > from init_IRQ(), covering per-CPU IRQ stacks and shadow IRQ stacks > consistently. > > Signed-off-by: Osama Abdelkader > --- > v2: > - Add return -ENOMEM from both init_irq_stacks() and init_irq_scs() > - Call panic() once from init_IRQ() if either init_irq_stacks() or > init_irq_scs() returns -ENOMEM > --- > arch/arm64/kernel/irq.c | 29 ++++++++++++++++++++--------- > 1 file changed, 20 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/kernel/irq.c b/arch/arm64/kernel/irq.c > index 15dedb385b9e..9fafd826002b 100644 > --- a/arch/arm64/kernel/irq.c > +++ b/arch/arm64/kernel/irq.c > @@ -10,6 +10,7 @@ > * Copyright (C) 2012 ARM Ltd. > */ > > +#include > #include > #include > #include > @@ -32,34 +33,43 @@ DEFINE_PER_CPU(struct nmi_ctx, nmi_contexts); > > DEFINE_PER_CPU(unsigned long *, irq_stack_ptr); > > - > DECLARE_PER_CPU(unsigned long *, irq_shadow_call_stack_ptr); > > #ifdef CONFIG_SHADOW_CALL_STACK > DEFINE_PER_CPU(unsigned long *, irq_shadow_call_stack_ptr); > #endif > > -static void init_irq_scs(void) > +static int __init init_irq_scs(void) > { > int cpu; > + void *s; > > if (!scs_is_enabled()) > - return; > + return 0; > + > + for_each_possible_cpu(cpu) { > + s = scs_alloc(early_cpu_to_node(cpu)); > + if (!s) > + return -ENOMEM; > + per_cpu(irq_shadow_call_stack_ptr, cpu) = s; > + } > > - for_each_possible_cpu(cpu) > - per_cpu(irq_shadow_call_stack_ptr, cpu) = > - scs_alloc(early_cpu_to_node(cpu)); > + return 0; > } > > -static void __init init_irq_stacks(void) > +static int __init init_irq_stacks(void) > { > int cpu; > unsigned long *p; > > for_each_possible_cpu(cpu) { > p = arch_alloc_vmap_stack(IRQ_STACK_SIZE, early_cpu_to_node(cpu)); > + if (!p) > + return -ENOMEM; > per_cpu(irq_stack_ptr, cpu) = p; > } > + > + return 0; > } > > #ifdef CONFIG_SOFTIRQ_ON_OWN_STACK > @@ -109,8 +119,9 @@ int __init set_handle_fiq(void (*handle_fiq)(struct pt_regs *)) > > void __init init_IRQ(void) > { > - init_irq_stacks(); > - init_irq_scs(); > + if (init_irq_stacks() || init_irq_scs()) > + panic("Failed to allocate IRQ stack resources\n"); > + > irqchip_init(); > > if (system_uses_irq_prio_masking()) { > -- > 2.43.0 > ping.