From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73D5C3ED5D8 for ; Wed, 6 May 2026 13:16:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778073409; cv=none; b=u3t068alFhT12jXUz791c1QSPXuSI67QqJTzvekz4j/Vp14LtJAKSySyw7DpKkbMX4eJfFpc0DiYQKDSWTlRQZxnj4YbbrC6K+X1wRDZXhrVs70UN8yVjzwkXsSP0n7Mk35I8gVMqyox/1l46fFihlWWurz3aIPOfY9zhAZ4Fmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778073409; c=relaxed/simple; bh=j1HlkD2KFQ0LpjIdHwENx/yDkeBZoC+Rn9YG0B68tk8=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gi+m6PIEcFKI3rHBKmVvGZSgSN0eHiw1dXgAnl3PSCw6GzzEjcnebvtdgW2E//E/YZ2BPh0eLO5Cevo0TSz0hXen/AvNu14p9RDHLrayUEcpu4uuPiHgBXe2PIN634LdXjDynHliBZYLRNuijPw8woOanYguEFsA0WmG0BzxaHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nk9z1dDv; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nk9z1dDv" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-44a74032ff8so3623993f8f.1 for ; Wed, 06 May 2026 06:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778073407; x=1778678207; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zkLthMXBD6rHNtZ6kKIiz/VN62oSAEzmoivCWMdRkvc=; b=nk9z1dDvHW5ZaW48iHRuda82sj7pWYP6ezugkroTkGRTXIoq+rw102/ktaXF2xhVxI VdgGRcqQz48432a9lwQa3FWTqxDCPCx1aKUx7ijRTdJ4gNbDx031KnqHTKNcXOuVFpdo z6p7lP00WRxMxjxSc0U2fi75luShPUuN7jA8cv2EwnrryJutfaITEdZbLLiPlX5RzJ04 F2qgCD7c4CL3F9f0kIK+NYFSBk609b8ESLBsGsYsXOGwnfZ6sQd7+b5I+aUvRPmdeOQ8 9m3jv4pW+A7X0Rf2vfGLPs0VF8K5S6WuMboyzth9oCk1bTsVvqw6YS2aq0XrqoOTuHKa 67Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778073407; x=1778678207; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zkLthMXBD6rHNtZ6kKIiz/VN62oSAEzmoivCWMdRkvc=; b=My+5xysAdlHZecgSq9sOT/1T1Qf8+nGkRM+J8pMeEmWFsvcNRMcKcIbx2X6gV2r06L goElD/yPjByLa+4u7ZWsQOlhDmRV/pYNwDA5MbmR8UDw0JpId8BffycRZbMrzAHg0hIZ jfRmjgVd1miTFGIG4bzEXQMWXiHqvXIvap2uI4c+QaPNNkAl4F18WhnhKoHuZsegaxNk +mqBGf2/SrY9+BQGsxjnOV3DNF/gIhXdFG51kNuh/TRf8Onp+jxmJk/VgyzGbCOoY2DS vBe2JhOGLRcVlj/a195Hk7DrWfs2kylKxQF3KdB72zTpmJ7y38xQZ+WUHmJVtBWXqCMG m7QQ== X-Forwarded-Encrypted: i=1; AFNElJ8uMWwCC/9XjJtNjqGBM1vjfajOljBTLdK0pA6g9a1KXhGmvMFhSM4QCA2dOO0T3O4OxpE/YwMOa5uFHeg=@vger.kernel.org X-Gm-Message-State: AOJu0Yyf0sw/ngZVyvfTHZZnYLndvSlprXqaMwR7d6tzJS9HHInoZIAu RNfTcrqgeZclOnjuHaDeT2FtUieJK9+tORn6rT2EZcEsfVPXsehR23H8 X-Gm-Gg: AeBDietUhEJDisHcMWu/Q+AxwdaFVvJIKThPo0iTX54HjfFfomJUH7mq02L+QVR9l39 snad+/4SXq0BS+bci0/IwB24+DXPazvMjn0u/KXnwDLqshDf+67e9UEWNdLUOwKTPJzel+jM8jV U57ydrypDu03QkwJbdUqa8swXq8fqcmOgamD3LUeNBu4YZju/u7WuCDsjPOuNOa5eTa+2TaBezR Uudd2bGSY0cjkPgmccgbI878cq5W+cWLQ6pFwuaDJ7nQ8ZisE89ycdwdWsNrogdjjl3ZuEP0BHF nRSadHZveO/7v3Tsswa8IlmOv/Ii1QOzfuFyECprL0rUGHldeZ4A1BGc2aQGi/TaZIEagVn38KS xF3iVIwIXWFHbmj/YnyIfJRtFHwY8PDRPZjtVA1Y+nJVTDlpoC7rP1q10sGWjFuNrPZw0uowCOa sbUOcZLFf6h320fIr9xiKJk3By2cG2zjPOlYCleGSJaXtw+FoK4dQGGPhUUyGUxvVBtXSw X-Received: by 2002:a05:6000:2dc8:b0:43c:fc5c:aa0b with SMTP id ffacd0b85a97d-4515df65d9fmr6043762f8f.42.1778073406730; Wed, 06 May 2026 06:16:46 -0700 (PDT) Received: from osama ([2a02:908:1b6:8980:89b3:e462:e9ca:df27]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45054b03df9sm12187126f8f.24.2026.05.06.06.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 06:16:45 -0700 (PDT) Date: Wed, 6 May 2026 15:16:43 +0200 From: Osama Abdelkader To: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Vladimir Kondratiev , Thomas Gleixner , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] riscv: panic if IRQ handler stacks cannot be allocated Message-ID: References: <20260404185522.21767-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260404185522.21767-1-osama.abdelkader@gmail.com> On Sat, Apr 04, 2026 at 08:55:20PM +0200, Osama Abdelkader wrote: > init_irq_stacks() and init_irq_scs() may fail when arch_alloc_vmap_stack > or scs_alloc return NULL, call panic() in this case. > > Signed-off-by: Osama Abdelkader > --- > v2: > - call panic() in place instead of return -ENOMEM > --- > arch/riscv/kernel/irq.c | 22 ++++++++++++++-------- > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git a/arch/riscv/kernel/irq.c b/arch/riscv/kernel/irq.c > index b6af20bc300f..017d42e778be 100644 > --- a/arch/riscv/kernel/irq.c > +++ b/arch/riscv/kernel/irq.c > @@ -75,28 +75,34 @@ DECLARE_PER_CPU(ulong *, irq_shadow_call_stack_ptr); > DEFINE_PER_CPU(ulong *, irq_shadow_call_stack_ptr); > #endif > > -static void init_irq_scs(void) > +static void __init init_irq_scs(void) > { > int cpu; > + void *s; > > if (!scs_is_enabled()) > return; > > - for_each_possible_cpu(cpu) > - per_cpu(irq_shadow_call_stack_ptr, cpu) = > - scs_alloc(cpu_to_node(cpu)); > + for_each_possible_cpu(cpu) { > + s = scs_alloc(cpu_to_node(cpu)); > + if (!s) > + panic("Failed to allocate IRQ shadow call stack resources\n"); > + per_cpu(irq_shadow_call_stack_ptr, cpu) = s; > + } > } > > DEFINE_PER_CPU(ulong *, irq_stack_ptr); > > #ifdef CONFIG_VMAP_STACK > -static void init_irq_stacks(void) > +static void __init init_irq_stacks(void) > { > int cpu; > ulong *p; > > for_each_possible_cpu(cpu) { > p = arch_alloc_vmap_stack(IRQ_STACK_SIZE, cpu_to_node(cpu)); > + if (!p) > + panic("Failed to allocate IRQ stack resources\n"); > per_cpu(irq_stack_ptr, cpu) = p; > } > } > @@ -104,7 +110,7 @@ static void init_irq_stacks(void) > /* irq stack only needs to be 16 byte aligned - not IRQ_STACK_SIZE aligned. */ > DEFINE_PER_CPU_ALIGNED(ulong [IRQ_STACK_SIZE/sizeof(ulong)], irq_stack); > > -static void init_irq_stacks(void) > +static void __init init_irq_stacks(void) > { > int cpu; > > @@ -129,8 +135,8 @@ void do_softirq_own_stack(void) > #endif /* CONFIG_SOFTIRQ_ON_OWN_STACK */ > > #else > -static void init_irq_scs(void) {} > -static void init_irq_stacks(void) {} > +static void __init init_irq_scs(void) {} > +static void __init init_irq_stacks(void) {} > #endif /* CONFIG_IRQ_STACKS */ > > int arch_show_interrupts(struct seq_file *p, int prec) > -- > 2.43.0 > ping.