From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 992DD4C0439 for ; Wed, 6 May 2026 17:47:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778089664; cv=none; b=CLNCliCXOiLcOGBkmUFajPsD3zI1J227rbyRhgn355nMWrZRt140xGHIh/Xau4KeqpxCaQ0FdY+7DIWCQ6G+HByXU8gSqWYTsYx5lRMlmRqtVq/VvIGL3NPI9DJuF9phRZvw2Yq/WL0jaYwWK6n30xQMMEI8rSgMdqo89WVVZD0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778089664; c=relaxed/simple; bh=aik4UUSHAC8a5AGO/wN4zQeig4UP3Zc7cMBUEntTcWU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Lmd4wW5JLix0uFJBa1/Ip+WWDDP9rKov3MPwQ6s0S4bZ6gqlxrmhOOl05qs9tcJYHU/KVXf+dQYnXIkEewH3b778P0zbgIDBJqKcXAsIlrHp7iPVFDN9oQXMDTSsiZJ2PtkzT8YJUv85kywfFH3JoTw0QVDu73aogg10miZ8vUA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=fih7KiYS; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fih7KiYS" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ba3b9bcf69so13325ad.0 for ; Wed, 06 May 2026 10:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778089656; x=1778694456; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KybkGyEAPJd/UFSLc8blkH8y2mvfwlowve0vuV+Is5U=; b=fih7KiYSXX9hlIV2Uh05XbUoQwE2PMMEFhdhJ5yyfiyxe+DXbc8CqchYWDEu98QuSv VPlXX/KBw+IA2qMjLfo6iHmR3V8X2Y0CB6NBkuxzy8sK6Nwg7t+kCwHXu5nCDUfJwgpH D36dcrVGX/a77YULvmGHdsOl7s+pM/CymyMbROPHJMePjmM+dkZC174u5QE5DDbZNBjZ povshuGYmUNq8dLofuV5WwayOFfk7Kjjg2uliPBxW9O22jlTq+YSCBtrdnn5jPeh2a5a xeELuJ91Y4ARplhJzclwFZ0vEAgr22DK66QddkZO0/8W0r3Qndwz6kKVJth0cM8OgXwt oXbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778089656; x=1778694456; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KybkGyEAPJd/UFSLc8blkH8y2mvfwlowve0vuV+Is5U=; b=sPNGqnzukMLCuT+298r1/cnwckdGe7d9e3Hbgm13W/0HdheTeVbshSbmnS+y/8nndO bRXYyNbtB7B2ipExDaQQ+K7Ri65X7Bh4GwnPDfC138x2SZjZSi8302q6KG9KbUT3KbDg O9z/YtAPsOVAD8udJeCuryXuqaV2SJiMA7qtWgFvxcXmUERmVQu4UFAJBSNh3hwWt9T1 +qBpO28OA0TatGwh26e9bQfXcOQWoJkDEKPoau/VkUSSAYtCExuK4PsoIrwlR89W1ZTO +aqPPBlTajjszGnreP0+VZSN9NGIgUVgHrgmCvdRRShDkyOS6zotq28IC+Oq2WlcM9Tr D6Hg== X-Forwarded-Encrypted: i=1; AFNElJ946WAkkwzKgJbOAYdlM718mrw1EhAlcZzNeHklSVpMH7lkEPNtTSjFGfZfhcePi8DlXlApdvTxyNjVvkk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz84Ht7/B/+fAFPqhrh8DTfpZcKGp5bJH1okR1uv74CZ/gyzaZw OTuvNtR01L4b7IZ5OssTxKr6HQ7hOJqm+ruOOYy7wkHO2noyraTOXirz8uRGb+KbEQ== X-Gm-Gg: AeBDiesG3IjFurbwWjSwhhM5FDW76WhuVc4KyNpyLk6+kMEFgZKLfm9+IfUmifDkUpX jVS/b43KpfOe3yWm1Ylq/dD/SysYFxYKcUUEV8aS9gocD+rSKMB1H3gKLTobWdgTrBE/7eSz3Gj /b5yHkHEMpm/Z/fe7f7IPL43Lej4UInzTdSpDhOCZ5IVwHY8VquXfuTAGPVNJwE1oy9uD6EE7+W 3+rEY/iVA5Zo8pVTqwuB8qhmHugF/oD8ZkqsNN7xIiR8HbeUkRYa7A9Qx3CsYZMw5p4EcGqzoIq VYyYUpUR1Ag5tuYe7Ew0Zc7lZkB3qms6e8Pk39A0BoeU/kg840K/RcCLswHzmSpng0P2Gb0J3k4 G00/XUIMPApzGL3ZXT9j0wB7LR/A+BJLqDdJcNNxPNUTJL9FnVIFEHwjD1dYUzvdsdznHyPiihT hz6VMqt/myk+44i9PIgL7Vhfw7y60Jl/ee3GKuRjjtMNyCramoK2rV/pkfqHDHtQgOvzGJC2AL/ DHzSYwH X-Received: by 2002:a17:903:1a24:b0:2b4:6153:e541 with SMTP id d9443c01a7336-2ba7cc54db5mr4362405ad.3.1778089655109; Wed, 06 May 2026 10:47:35 -0700 (PDT) Received: from google.com (153.46.83.34.bc.googleusercontent.com. [34.83.46.153]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-365c25f8cf9sm3409281a91.4.2026.05.06.10.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 10:47:34 -0700 (PDT) Date: Wed, 6 May 2026 17:47:31 +0000 From: Samiullah Khawaja To: Leon Romanovsky Cc: Marek Szyprowski , Robin Murphy , Jon Mason , Dave Jiang , Allen Hubbe , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, ntb@lists.linux.dev Subject: Re: [PATCH v2 3/6] dma-debug: Remove unused DMA attribute parameter Message-ID: References: <20260501-dma-attrs-debug-v2-0-8dbac75cd501@nvidia.com> <20260501-dma-attrs-debug-v2-3-8dbac75cd501@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260501-dma-attrs-debug-v2-3-8dbac75cd501@nvidia.com> On Fri, May 01, 2026 at 09:35:07AM +0300, Leon Romanovsky wrote: >From: Leon Romanovsky > >debug_dma_alloc_pages() always receives a DMA attribute value of 0, >because dma_alloc_pages() never receives any attributes from its callers. >As preparation for upcoming patches, remove this unused attribute from >the debug routine. > >Signed-off-by: Leon Romanovsky >--- > kernel/dma/debug.c | 5 ++--- > kernel/dma/debug.h | 6 ++---- > kernel/dma/mapping.c | 2 +- > 3 files changed, 5 insertions(+), 8 deletions(-) > >diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c >index 1a725edbbbf6a..3b53495337f5c 100644 >--- a/kernel/dma/debug.c >+++ b/kernel/dma/debug.c >@@ -1567,8 +1567,7 @@ void debug_dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg, > > void debug_dma_alloc_pages(struct device *dev, struct page *page, > size_t size, int direction, >- dma_addr_t dma_addr, >- unsigned long attrs) >+ dma_addr_t dma_addr) > { > struct dma_debug_entry *entry; > >@@ -1586,7 +1585,7 @@ void debug_dma_alloc_pages(struct device *dev, struct page *page, > entry->dev_addr = dma_addr; > entry->direction = direction; > >- add_dma_entry(entry, attrs); >+ add_dma_entry(entry, 0); > } > > void debug_dma_free_pages(struct device *dev, struct page *page, >diff --git a/kernel/dma/debug.h b/kernel/dma/debug.h >index da7be0bddcf67..24b8610850fbd 100644 >--- a/kernel/dma/debug.h >+++ b/kernel/dma/debug.h >@@ -47,8 +47,7 @@ extern void debug_dma_sync_sg_for_device(struct device *dev, > int nelems, int direction); > extern void debug_dma_alloc_pages(struct device *dev, struct page *page, > size_t size, int direction, >- dma_addr_t dma_addr, >- unsigned long attrs); >+ dma_addr_t dma_addr); > extern void debug_dma_free_pages(struct device *dev, struct page *page, > size_t size, int direction, > dma_addr_t dma_addr); >@@ -113,8 +112,7 @@ static inline void debug_dma_sync_sg_for_device(struct device *dev, > > static inline void debug_dma_alloc_pages(struct device *dev, struct page *page, > size_t size, int direction, >- dma_addr_t dma_addr, >- unsigned long attrs) >+ dma_addr_t dma_addr) > { > } > >diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c >index 23ed8eb9233e5..6cbefbd4158c8 100644 >--- a/kernel/dma/mapping.c >+++ b/kernel/dma/mapping.c >@@ -733,7 +733,7 @@ struct page *dma_alloc_pages(struct device *dev, size_t size, > if (page) { > trace_dma_alloc_pages(dev, page_to_virt(page), *dma_handle, > size, dir, gfp, 0); >- debug_dma_alloc_pages(dev, page, size, dir, *dma_handle, 0); >+ debug_dma_alloc_pages(dev, page, size, dir, *dma_handle); > } else { > trace_dma_alloc_pages(dev, NULL, 0, size, dir, gfp, 0); > } > >-- >2.53.0 > > Reviewed-by: Samiullah Khawaja