From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Maxwell Doose <m32285159@gmail.com>
Cc: "Salah Triki" <salah.triki@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] iio: humidity: ens210: Fix missing I2C functionality checks
Date: Wed, 6 May 2026 18:43:23 +0300 [thread overview]
Message-ID: <afthm7L0j8VZdkUk@ashevche-desk.local> (raw)
In-Reply-To: <CAKqfh0E+4WUBsMHH0Rj1UH0MFdGo7E1crmHzJ+E6c0XXz3qvCw@mail.gmail.com>
On Wed, May 06, 2026 at 10:02:29AM -0500, Maxwell Doose wrote:
> On Wed, May 6, 2026 at 3:40 AM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > On Wed, May 06, 2026 at 11:39:11AM +0300, Andy Shevchenko wrote:
> > > On Tue, May 05, 2026 at 06:49:43PM +0100, Salah Triki wrote:
...
> > > > + !i2c_check_functionality(client->adapter,
> > > > + I2C_FUNC_SMBUS_EMUL)) {
> > >
> > > This one is now wrong.
> >
> > I meant this *indentation* is now wrong.
>
> Did something happen to that when I sent the email? Or maybe I'm just
> going insane...
Sounds like latter one? :-)
> slightly confused,
In short this is `if (foo(A) && foo(B))`, and foo should be indented on the
same column while their parameters on different but still same. In your example
the foo(B) is indented as A parameter on previous call instead of indenting as
foo(...).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-06 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 17:49 [PATCH v3] iio: humidity: ens210: Fix missing I2C functionality checks Salah Triki
2026-05-06 8:39 ` Andy Shevchenko
2026-05-06 8:39 ` Andy Shevchenko
2026-05-06 15:02 ` Maxwell Doose
2026-05-06 15:43 ` Andy Shevchenko [this message]
2026-05-06 16:03 ` Maxwell Doose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afthm7L0j8VZdkUk@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m32285159@gmail.com \
--cc=nuno.sa@analog.com \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox