Re: [PATCH 0/3] iio: light: tcs3472: devm conversion, wait time, locking cleanup

Andy Shevchenko
2026-05-06T15:45:56Z

On Wed, May 06, 2026 at 05:35:42PM +0200, Aldo Conte wrote:
> On 5/6/26 12:21, Andy Shevchenko wrote:
> > On Wed, May 06, 2026 at 11:43:08AM +0200, Aldo Conte wrote:

...

> Thanks a lot for the detailed review. I'll address all the points in v2.
>
> Regarding the series structure, I need to clarify the correct order:
> 1) Guard (mutex) conversion

Since this most likely wants a new cleanup.h to be added, the 2) Header sorting
should go before even this one.

> 2) Header sorting
> 3) Devm conversion (with the new TCS3472_Powerdown using Guard (mutex)
> directly)
> 4) Wait time implementation
> Would this be OK?

Otherwise sounds good, but I can't be 100% sure until I see a v2.

--
With Best Regards,
Andy Shevchenko