From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2BF73F0744 for ; Wed, 6 May 2026 16:21:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778084500; cv=none; b=IOcuNq1RVXU0MX5hWJuky7/LyMP6Qto4FYN4LnTATnE0jq/j+pggs8wHlBAoWJIL0wi2HQttQ1HJRgIFw/jO3Y25HqwHSZL6oyycIKgvTj2sqsjg1wztIDC+ikSZdCVDKXo9sYMx4kOA662Tmw5WoLVrqjbAPJhdopwoZps+sh4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778084500; c=relaxed/simple; bh=xq0ncLQqbBgMKmiqv0iCAyodq62iUAP3pn+orp6uLWc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eTGRyUdx3ColnGqj1uurzJcU9lFZKW9u9KZuXSt4kC/Xrmaz1tdsB0wZuYs3LrXk1B6yOeleU/Ap/dmJ4R4KKZsAcD44C8rLO1a6TR5h2mOaIkeATmgT8zomzgaDt9atY1CLYDZUctpyPU2h3Z+EV/Ictpw9Pit/oDuQa36KYMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mTHr2St8; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mTHr2St8" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4891e5b9c1fso64438315e9.2 for ; Wed, 06 May 2026 09:21:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778084497; x=1778689297; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CRMNJQwpy4JLabii5FgqNhMAFtCk786EvStmSIccUWs=; b=mTHr2St8Br0Kfq1WYhl35C20KtE4sj7z1HFpFiD7uXDI34QiKIwNcf4yhReyWPagT+ a31KLi6Mr8yAdJeSV8rUfaGAWRCeEIv+0xoUupIHKRSK8EfHiur5nDua3rM5vogDUzQs DjKg/XBvxacZYQsUDfYuOhfIgPPGCNQX3VjNrGhBSszI2mv/7nngQ5DG+KxgBddb4PJ/ GdxsZ6ItB8J7ie4spA0aJyq5mQpxhsE1lKMf32EYtFgkVENR2yPQh8lgfp9ZmpKsTe/s OAmkFTHiUqTLTHUf1/5Am6VeV5RbnOydb+G/P5mwx/gAosCSzuTKQ0U9OjmERe2K/RX/ /mzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778084497; x=1778689297; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CRMNJQwpy4JLabii5FgqNhMAFtCk786EvStmSIccUWs=; b=NzUBlcMkDHaSEd3WNzvTvaf+pqf8DdpROfwrZA3gwNu4gm+FS5KshVI6Zm8Ee3owZC lpgWlH6ecAnkxijTAidoFahozSL4J10RHuyGCoXj0H/ao9IprGccvreR6jYr6K0Fcbj5 5NrEkpDT5SOzB3u0udFVxY2BkZUYfm+NGQq+4EfDMdRngzHDYnkF+hkKDSDzofQu63qt C9K+8KcWICGF1QeAWTY5DQyijOn3ZqqKdQ2nwEK9lMMZ/6x+6Mvdh8ctn7sF0buxUOp2 P7C4/655kEKt/uc9acU1xEhiBq6Y28QOhrLSzJDmG8xaTWtNTrq5GAWt6yBDhOw0ZnvC 74XA== X-Forwarded-Encrypted: i=1; AFNElJ8jzbAd0FjCp7gjTxdhJnHuNqrHaOCltokmAkoLuI5tPbMFd4cR1XSKuIH6pOnQbCbmQFODHW5TpZ7q/hI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2fJmGWwaBTaVNY/UrHN567eDz7lVUKFzYIDdis3fpt8Okvthp cxMgYj5Fa/LevGLPTqtjjuY+N4ci85Tc/txVBeXtdEeB/ReHKCU//yyu X-Gm-Gg: AeBDietc9B1BIYSqMnGy45EFHPrCksLxYQRYIyzskNx76e1ElU+Yf+ivfLyFoAqmzRK R6weuQQ93orYQHQb1cGlEmTNuq89Zlr+PH8LS8lIDAgkVP+ByEYSFpV5HEho6oVxPOHNvjCU6WM tN694W9bG9jNqSFG/cTq8txK/iu2lYL5rM+3gpHftuVLXtcqnQF+LDKaUg0fK6lRn9xtnY1GHRv WsYu/23Nb6rHi25rxxs0Qos4EFbhzWkDCJwOMHT29AfENK1eRA4z34nkx7XBzLWETftyp6Uirow PS7Rdca/U8PspEzvFT3tGMpEXSlGw6+tSVgI+gBUIvuGHHNXG3EN+GJZlZQZNGCv/RT56Nt8FNq fj4gLzUeoF0/8Gf7cLZbwSy7Xp5dnH6oeWYOuP8oQ1BEvF18os+aVLqDYXVRQZ0q2pcGpBNEeoq tK8wHy93tHG36MZ1fCYXkGPbI9eiNbjXwNnkw= X-Received: by 2002:a05:600c:3548:b0:48a:7aad:4425 with SMTP id 5b1f17b1804b1-48e51e097fcmr71523485e9.3.1778084496987; Wed, 06 May 2026 09:21:36 -0700 (PDT) Received: from gmail.com ([51.154.251.79]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4505285e765sm13179992f8f.10.2026.05.06.09.21.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 09:21:36 -0700 (PDT) Date: Wed, 6 May 2026 16:21:34 +0000 From: Vaibhav Gupta To: Harshitha Ramamurthy Cc: Joshua Washington , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , Ankit Garg , Tim Hostetler , Alok Tiwari , John Fraker , Matt Olson , Praveen Kaligineedi , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] gve: Use generic power management Message-ID: References: <20260504182139.604925-1-vaibhavgupta40@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: > > - .suspend = gve_suspend, > > - .resume = gve_resume, > > -#endif > > + .driver.pm = &gve_pm_ops, > > Thanks for the patch! A minor suggestion: could you wrap this in pm_sleep_ptr()? > > Also, please include the net-next prefix in the subject line when posting v2. > > With those changes, feel free to add: > Reviewed-by: Harshitha Ramamurthy > > Thanks, > Harshitha > Thanks for your input Harshitha! I have made the suggested amends, and I will send the v2 in reply to my v1 patch, as I have to include the review tag of Alexander as well. Thanks Vaibhav > > }; > > > > module_pci_driver(gve_driver); > > > -- > > 2.53.0 > >