From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DABB4C0418 for ; Wed, 6 May 2026 18:16:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778091396; cv=none; b=SpHAOP6xf8o20/7YTH2m8Od3UuhOEBCzWZ3brfNsIqQj3NEP+Vg6dFbMcMDQhwNOp7p4IxHtQQwM0D+fXf8j4UvhBrnUJUqbIy4A+cK3D4QxkIJgRny8Rympy4zhOnFQ6+kWoFd3aBtQ82ioInCFp6s87N23ZHUVjG/Q39JS5UA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778091396; c=relaxed/simple; bh=S9mvrWt8MHwjrniC+5hfqEcZPJwFH1boXGZmNPTls+Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N5eB0A9wXRyEQSYh8ZLGnt6P9hFQQNXMzX3aD/C8WyKm8iCBgvNtFuy/i8bHZH75jSAIxBqbrko2wxNEY6tBa0ZyQ4vmHmsIx2FrTN8YyhbD1T4N4Pzc5lL57JMECtMJxur8x2SmYemA/CaBwV7B1j9WWYZx1in8NFeDXmujqF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gNmtP2c1; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gNmtP2c1" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2b46da8c48eso124515ad.1 for ; Wed, 06 May 2026 11:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778091391; x=1778696191; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=e7Y9JqHzZKULv50XrRzWAnOBKFiT4J2l9mPMNIlCT3Y=; b=gNmtP2c1wvszP7NaBpOBSItINMWeurg9v7K835TG+1ZQd8OhpTzt2zTshYaJbcKHIN m082o4ICHc2LDGujJ+WCv2NxFMgm3+0R3ZpfoZIN2NkyILif0bYf3BLaMyd8bIiXf3xT vgp+UQvpolW9g2qR6gxXT97ZpWkm5sIIdtFCRCOi7TdEEQUpecFdtKLR3HH38Tadofyx ktaqgrh/Req9f16XMdBPVoJABqkWZ5uWVMeGSFjqvyMpkLLnvA0KHavYm7v3zgLUQ762 CRShREtqSkjDN/d698VvXk9872gMpwVU3qOM8CKuqMCvhJjOy8iM9CmBAS3gEg0LPPkU g+dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778091391; x=1778696191; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e7Y9JqHzZKULv50XrRzWAnOBKFiT4J2l9mPMNIlCT3Y=; b=poQguCTwWIJOjZD9OOgyvW0FfcdXxet7/xh5gu3O7uDvTP0go16Wdfx1zHeDAmCAt7 w3MMJzsAqQh0ZBVcIMRXOFkSsixRyZjslnTgr1jZwaReMuPlKjBXo7nELuBwRHwmGQ5B pcYiyggZ4IN2jK9DrguTFo5oxlEtpnnXWcBtDWBVk1buKWVvnfbKivDnVxi7/EI+Js+r fU7Btidtbn4/GyLKAN6QIIuopDZxPpD5u2484KCh0AhbiZWY3Jpgz2JxC1iIuJe0QL1e f6laf5W/I3kZ7TmvkPRIwceohsQHNrrZjiM2YGa4pp9AMUZrQxGV5aJorRKr7fXULIkC 4uog== X-Forwarded-Encrypted: i=1; AFNElJ9YS+0mNAKe1MAgWEz0IZXg2Ba2jNymOguV6sRQCXQQMToLIwNuiZ9WzM/iv5hXbID6pc+NP0yZ+I4heW8=@vger.kernel.org X-Gm-Message-State: AOJu0YxaIVO4IFG42a15nLCOIplt0yfYDydeaAKL/d0la6Ut5LpNTdLU HMmaWrsDm1i7wf3AKIhW39PnH+h0/RSMeOV7nDsIdF193B/rjrJ3ITwsudtVBmTkAg== X-Gm-Gg: AeBDies7pfnsjt6J57bUp2oQ6i8hiMlICfGnPh4gdQmyS2vUUrNRLbxXbPtQKzV+kVZ h0xBn08KgW4sXCxrTz4IkAgl9UzSkkPzzHbf7JQnaWFDMU7OfGtU6LRizQWzBAkrwElFZh+5vPE T7wYxmrngHmXew7y5B4Ykf7E3xn7cckwv0QoNu4Z5MbfEl6InHawFYY+aly1dKZ7v5vq4V35Gmr pPZgdTlaEEJS+T7oixOagfjuj/jYyyxHb3vjF51M1nic2WhUajrYJUCqcxHMG7errbOci69vV0N glNZEAj8q6/GDg8p91y4ezgeSxKU3ajS1W9/T9D6peeWJT2/Ja3SLaYNyXwwH1+QW+C9782+9yx dBxu7FK66Ly6LYEvCFtnDm1hEPse4KWeBeXb19YY9tTINMleBEJNISF/CGMzdkBbOgWJrwP8xyP AT2Guh0k+cPH6jzli7d+JWsV7/YZdP76r+5bqPL7JgxpL7aKgA41QiFB034wpgK3CUHQri2Q7qh iU/dLgT X-Received: by 2002:a17:903:3887:b0:2b7:b03d:9847 with SMTP id d9443c01a7336-2ba7cecf689mr4399065ad.7.1778091390466; Wed, 06 May 2026 11:16:30 -0700 (PDT) Received: from google.com (153.46.83.34.bc.googleusercontent.com. [34.83.46.153]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-365b4c196ecsm3120637a91.6.2026.05.06.11.16.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 11:16:30 -0700 (PDT) Date: Wed, 6 May 2026 18:16:27 +0000 From: Samiullah Khawaja To: Leon Romanovsky Cc: Marek Szyprowski , Robin Murphy , Jon Mason , Dave Jiang , Allen Hubbe , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, ntb@lists.linux.dev Subject: Re: [PATCH v2 6/6] dma-debug: Ensure mappings are created and released with matching attributes Message-ID: References: <20260501-dma-attrs-debug-v2-0-8dbac75cd501@nvidia.com> <20260501-dma-attrs-debug-v2-6-8dbac75cd501@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260501-dma-attrs-debug-v2-6-8dbac75cd501@nvidia.com> On Fri, May 01, 2026 at 09:35:10AM +0300, Leon Romanovsky wrote: >From: Leon Romanovsky > >The DMA API expects that callers use the same attributes when mapping >and unmapping. Add tracking to verify this and catch mismatches. > >Signed-off-by: Leon Romanovsky >--- > kernel/dma/debug.c | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > >diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c >index 3dfed51c3d9aa..c38efc1ac8d6c 100644 >--- a/kernel/dma/debug.c >+++ b/kernel/dma/debug.c >@@ -1074,6 +1074,29 @@ static void check_unmap(struct dma_debug_entry *ref) > type2name[entry->type]); > } > >+ /* >+ * This may be no bug in reality - but DMA API still expects >+ * that entry is unmapped with same attributes as it was mapped. >+ * >+ * DMA_ATTR_UNMAP_VALID lists the attributes that must be identical >+ * between map and unmap. Any attribute outside this set (e.g. >+ * DMA_ATTR_NO_WARN, DMA_ATTR_SKIP_CPU_SYNC) is allowed to differ. >+ */ >+#define DMA_ATTR_UNMAP_VALID \ >+ (DMA_ATTR_NO_KERNEL_MAPPING | DMA_ATTR_FORCE_CONTIGUOUS | \ >+ DMA_ATTR_MMIO | DMA_ATTR_REQUIRE_COHERENT | DMA_ATTR_PRIVILEGED | \ >+ DMA_ATTR_CC_SHARED) >+ if ((ref->attrs & DMA_ATTR_UNMAP_VALID) != >+ (entry->attrs & DMA_ATTR_UNMAP_VALID)) { >+ err_printk(ref->dev, entry, >+ "device driver frees " >+ "DMA memory with different attributes " >+ "[device address=0x%016llx] [size=%llu bytes] " >+ "[mapped with 0x%lx] [unmapped with 0x%lx]\n", >+ ref->dev_addr, ref->size, entry->attrs, ref->attrs); >+ } >+#undef DMA_ATTR_UNMAP_VALID >+ > hash_bucket_del(entry); > put_hash_bucket(bucket, flags); > > >-- >2.53.0 > > Reviewed-by: Samiullah Khawaja