From: "José Guilherme de Castro Rodrigues" <jose.guilherme.cr.bh@gmail.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Corentin Chary <corentin.chary@gmail.com>,
"Luke D. Jones" <luke@ljones.dev>,
Denis Benato <denis.benato@linux.dev>,
Hans de Goede <hansg@kernel.org>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] platform/x86: asus-wmi: fix camera key led on Zenbook S14
Date: Wed, 6 May 2026 19:29:16 -0300 [thread overview]
Message-ID: <afvAvE-yhB6L53H8@djouze-zen> (raw)
In-Reply-To: <cd3fc0ef-c15a-8f41-9162-c042daa44969@linux.intel.com>
On Wed, May 06, 2026 at 04:18:39PM +0300, Ilpo Järvinen wrote:
>
> So if I understood you correctly with LED_NEG (unknown if it's just on
> your device or generally with it),
>
> This doesn't work: set
> This works: set+get
Yes, that is correct.
> The extra get shouldn't be that harmful so doing that always if
> CAMERA_LED_NEG is being used is okay at least with me (make sure to add
> add a comment though so it can be known later why it's there even 10
> years from now).
Ok! Once again, thanks for the direction. I'll work on this as soon as I
can and then send a v3.
Best Regards,
José Rodrigues
prev parent reply other threads:[~2026-05-06 22:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 23:45 [PATCH v2] platform/x86: asus-wmi: fix camera key led on Zenbook S14 José Guilherme de Castro Rodrigues
2026-04-28 8:22 ` Ilpo Järvinen
2026-04-28 23:20 ` José Guilherme de Castro Rodrigues
2026-05-06 13:18 ` Ilpo Järvinen
2026-05-06 22:29 ` José Guilherme de Castro Rodrigues [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afvAvE-yhB6L53H8@djouze-zen \
--to=jose.guilherme.cr.bh@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=denis.benato@linux.dev \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox