The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Shawn Guo <shengchao.guo@oss.qualcomm.com>
To: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Luca Weiss <luca.weiss@fairphone.com>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com,
	trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com,
	linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Gokul Krishna Krishnakumar <gokul.krishnakumar@oss.qualcomm.com>
Subject: Re: [PATCH v5 4/5] remoteproc: qcom: pas: Add late attach support for subsystems
Date: Thu, 7 May 2026 13:04:11 +0800	[thread overview]
Message-ID: <afwdS5euY8bxxA16@QCOM-aGQu4IUr3Y> (raw)
In-Reply-To: <7bd01424-e611-449f-b5e0-7c823ad3b978@oss.qualcomm.com>

On Tue, Apr 14, 2026 at 12:56:11PM +0800, Jingyi Wang wrote:
> 
> 
> On 4/11/2026 10:59 AM, Bjorn Andersson wrote:
> > On Thu, Apr 09, 2026 at 01:52:27AM -0700, Jingyi Wang wrote:
> > > Subsystems can be brought out of reset by entities such as bootloaders.
> > > As the irq enablement could be later than subsystem bring up, the state
> > > of subsystem should be checked by reading SMP2P bits and performing ping
> > > test.
> > > 
> 
> Hi Bjorn,
> 
> > 
> > I still don't understand.
> > 
> > Are you saying that devm_request_threaded_irq() will succeed and then
> > calling irq_get_irqchip_state() will not work? Or are you saying that
> > SMP2P driver isn't reliable and we're loosing the ready or fatal bits?
> > 
> 
> This says the ready state is getting from irq_get_irqchip_state()
> instead of q6v5_ready_interrupt(like what rproc start do)

Hi Jingyi,

I guess Bjorn is questioning "performing ping test" part. Is that really
required?

I'm testing this patch with Nord ADSP which is brought up by bootloader.
I have to remove the ping test to get the ADSP attached, as it appears
that Nord ADSP doesn't support pong. Are we good to just check ready bit
for telling whether a subsystem/dsp is already running and remoteproc
should attach to instead of powering up it?

May I ask you to copy me on the new posting of the series? I would like
to make sure it works for Nord ADSP as well. Thanks!

Shawn

       reply	other threads:[~2026-05-07  5:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260409-knp-soccp-v5-0-805a492124da@oss.qualcomm.com>
     [not found] ` <20260409-knp-soccp-v5-4-805a492124da@oss.qualcomm.com>
     [not found]   ` <adm37MruBfXAjLpZ@baldur>
     [not found]     ` <7bd01424-e611-449f-b5e0-7c823ad3b978@oss.qualcomm.com>
2026-05-07  5:04       ` Shawn Guo [this message]
2026-05-13 12:51     ` [PATCH v5 4/5] remoteproc: qcom: pas: Add late attach support for subsystems Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afwdS5euY8bxxA16@QCOM-aGQu4IUr3Y \
    --to=shengchao.guo@oss.qualcomm.com \
    --cc=aiqun.yu@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gokul.krishnakumar@oss.qualcomm.com \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=mani@kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=robh@kernel.org \
    --cc=tingwei.zhang@oss.qualcomm.com \
    --cc=trilok.soni@oss.qualcomm.com \
    --cc=yijie.yang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox