From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F87F40DFA3 for ; Thu, 7 May 2026 05:32:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778131930; cv=none; b=uil2vQ7aMahZD6myZsi0Hio/+QmxsW5S6VYJBcs193s6e/49e5+agsh3/HnLqyVsxk1Zu2S7PD89jTFwws8aO8oLJt36JzA927Tzf7YOllIsae32oqczwnVYRpRKhWyn8yOuRAforSW7GghGlgZZMXPmq0RM1Cj9dvVWTlFlmUA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778131930; c=relaxed/simple; bh=0ks2kcyaXSjNxjHYK0fN7d2EPaCjwCZXMKBO9GkikG8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WsA+HMNlkZfVLJhdIw2KPQNxTRinuKMpeUgEimA9rj41UgfZnwrDd6Gh547S8oo1oq9IoNfCmfTtahUBwueY8yvaXDUatzmshG+As2o1uCbM7JGSCQjbbwt+xnChkfDrKJit+XuLSg5VwBeHGvs8XjunsawixLInl/us6XWc1oQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=mVylKK7i; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="mVylKK7i" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XNaQFH//cJrpTIackHAQ5WQip+Cq9ZPeCoMkbCq/r7w=; b=mVylKK7iu/7JVfsaM1Mp5mmEL2 NVy/ehewtaeQ3g3F+P7LjjKaQEsSoc+zgxxVn3DhDr0XJKC+OJ52WTQh6f0gmgUHLuuvGDz9YeMxE 8gBybZ6V9W5hOVeVLxSTxIyABe3rdgQsK2whtcTHil2TnPOXsqn/HnaEc+jkQIoJEct5xPagXcJrW zSHbv0dAXNOgWOL02g6+nsK28G0Al3BjNIfLHPIQyTA+MJZS3/CZgKvb28mmLyXlpz7rwpTfezadT 9dz5BVxCUVRUPcOrvqKfugY6f4nkp/lnMsPSJ6t0Q31LXE6NwT8LM+yUNlyi/qgy6MmxPCzI9wy7d iz06DuJw==; Received: from hch by bombadil.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wKrLB-00000002oU0-48qQ; Thu, 07 May 2026 05:32:05 +0000 Date: Wed, 6 May 2026 22:32:05 -0700 From: Christoph Hellwig To: Rohit Chavan Cc: kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: use str_enabled_disabled() for digest mismatch messages Message-ID: References: <20260504123555.1741525-1-roheetchavan@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260504123555.1741525-1-roheetchavan@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Mon, May 04, 2026 at 06:05:55PM +0530, Rohit Chavan wrote: > pr_err("queue %d: data digest mismatch host: %s ctrl: %s\n", > nvme_tcp_queue_id(queue), > - queue->data_digest ? "enabled" : "disabled", > - ctrl_ddgst ? "enabled" : "disabled"); > + str_enabled_disabled(queue->data_digest), > + str_enabled_disabled(ctrl_ddgst)); I can't really see how this is considered an improvement.