From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from flow-a2-smtp.messagingengine.com (flow-a2-smtp.messagingengine.com [103.168.172.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FA0D38E5C4; Thu, 7 May 2026 09:33:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.137 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778146394; cv=none; b=CvK6oG9z/Ybtrx6mnfn/8G9oGbeTYb9QppPbGwNQCt7ngYNVaGkmGDgiSCn/+P1ISysENlHEfaWVmX4oc0g15Dnzv7mt7hpiJPmKNvct10v4xcxBHxlf8CxCjO4t/6B3BIocrlvFcPEYast5xArgW6d0mnum+YlB7QdMfNSeZ8A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778146394; c=relaxed/simple; bh=qTI+rCfckoAaQfgJ9BckzMl347yOt6lcc7PBTWgdJiA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Kd72DBK2RY5o1lLtYaD4hkV31pq05QsXs/tOcJSFkcz2Z2w2/l1Y9hOE+k7tvbTSHxf4SQk2+/U6PUtt5rN75GY9lRTyaUqbnTQljN5uFARrFDL6nWTSUk6fOxlEGcD8pxURAdSpifoBWlZ0RIb9pBvwpGXBwIYa5bgin2eLdVY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=GjG6WYOa; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=lSmAboNV; arc=none smtp.client-ip=103.168.172.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="GjG6WYOa"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="lSmAboNV" Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailflow.phl.internal (Postfix) with ESMTP id AC061138003F; Thu, 7 May 2026 05:33:11 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Thu, 07 May 2026 05:33:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1778146391; x= 1778153591; bh=7b++wZS149+bDBFrMI31xSpECQLGsVLRHFUW6GY5gX8=; b=G jG6WYOaJRcFkli26MfJAoVLrOMn58VQLv0VWjQX/gc4dmIL6ameL6f5lRVdnO2Sa Bbpkb/MAwc49daRKCBRsPHOxtMMK4DdHFqNpMHOBEAHanrkYW/zlgLo21LUk4vZ8 FjqhiwgHq37jxMgnagl86tnfaNE03pbF/U4SKPsWpqd1xIUNNUd9nNZbnE3/DjmZ ltMEpvZMY+YJZ18mHq70obxVITywgnsVW28F07DmuBX3X7ZCt7EiRfzJ2mhxFSBa l9Z53I8nY3PDPcqE9u0ORPGCkkHfm85vZbUmYDluPcQu0xObQt+rLXMDoqCcT2Oc YPNiJO5WhiMn7On446bxg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1778146391; x=1778153591; bh=7b++wZS149+bDBFrMI31xSpECQLGsVLRHFU W6GY5gX8=; b=lSmAboNVt6YB3O2pN62qiwXYnv4z+/OziUfFk2YpdY5d6iJR5sW Df5O+5+0Hq58YNjImPuyscSKGkZ0qm4XD/2YQDum7tB/ucBBtxWuySjwLaHszQe/ oJMNG9ZHJ5y2BMJKc7OBGOGl0sb+u9+O45XN81clGxICFZEK/qISHtxypUb6DaZM BgFyc+yWaNrlv1Zcia4pKBlSOUuLta5A3Zv1mcSO941YpTDOnLxl4lsJHOnwgOr8 O+byfKXW3YlEMIpwE1TRbvIEX3XfvdlW7EjYxebcewm/wokgXHv3zTsl3xGHU70h +bjwpEKP00hzmq5bbPbFQbLrSsOXOiVU+/g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddutdejuddvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtjeenucfhrhhomhepufgrsghrihhn rgcuffhusghrohgtrgcuoehsugesqhhuvggrshihshhnrghilhdrnhgvtheqnecuggftrf grthhtvghrnhepuefhhfffgfffhfefueeiudegtdefhfekgeetheegheeifffguedvueff fefgudffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshgusehquhgvrghshihsnhgrihhlrdhnvghtpdhnsggprhgtphhtthhopedvvddpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtoheprghnthhonhihrdgrnhhtohhnhiesshgvtg hunhgvthdrtghomhdprhgtphhtthhopehsthgvfhhfvghnrdhklhgrshhsvghrthesshgv tghunhgvthdrtghomhdprhgtphhtthhopehhvghrsggvrhhtsehgohhnughorhdrrghprg hnrgdrohhrghdrrghupdhrtghpthhtohepuggrvhgvmhesuggrvhgvmhhlohhfthdrnhgv thdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrdgtohhmpdhrtghpthhtoh epkhhusggrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehprggsvghnihesrhgvughh rghtrdgtohhmpdhrtghpthhtohephhhorhhmsheskhgvrhhnvghlrdhorhhgpdhrtghpth htohepughsrghhvghrnheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 May 2026 05:33:10 -0400 (EDT) Date: Thu, 7 May 2026 11:33:09 +0200 From: Sabrina Dubroca To: Antony Antony Cc: Steffen Klassert , Herbert Xu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , David Ahern , Masahide NAKAMURA , Paul Moore , Stephen Smalley , Ondrej Mosnacek , Jonathan Corbet , Shuah Khan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, selinux@vger.kernel.org, linux-doc@vger.kernel.org, Chiachang Wang , Yan Yan , devel@linux-ipsec.org Subject: Re: [PATCH ipsec-next v8 04/14] xfrm: fix NAT-related field inheritance in SA migration Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: 2026-05-05, 06:32:43 +0200, Antony Antony wrote: > During SA migration via xfrm_state_clone_and_setup(), > nat_keepalive_interval was silently dropped and never copied to the new > SA. mapping_maxage was unconditionally copied even when migrating to a > non-encapsulated SA. mapping_maxage should be harmless (0/unused on non-encap), but I think migrating nat_keepalive_interval should be considered a fix: Fixes: f531d13bdfe3 ("xfrm: support sending NAT keepalives in ESP in UDP states") (maybe even split out of this series, but that would cause a conflict with the previous patch) Reviewed-by: Sabrina Dubroca -- Sabrina