From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f74.google.com (mail-ed1-f74.google.com [209.85.208.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E68FE3C65FF for ; Thu, 7 May 2026 10:00:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778148060; cv=none; b=K6mydBucKzXeT5bCXe8s0aZFULoKXBmOsC1Iklva81Ao/7xyqJFlahK6AJVK9ZSZd95NL6Ssfhp899ZtY4Ko18LLBPo2/Hn+/oed7rpX6uidZDruEefIc9x9KueVbaKKM88fpQg5ka5UiNQTx+DAENyTnR20SucV0qnaRs96Vpw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778148060; c=relaxed/simple; bh=Fad51TK8t7LXJcIA8vGRouxTYYfBGTrwnyV5+Q+CSjs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=d3DzbtfTrh8SRKsN8a9rIz5Xcftx4J1ziY8koODj64s091owkGQkHlae6Cz9aHw255LQ73AmCQZCUjxKjnitMN4GEWiOO+s6mQvVZu8ZznuT/06MXRuDUVYoSIongkpeeLRVx2kxAG8pJa+Lvv/6Lv5UCA96ck/BQGQlMKgV/ik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=a2Q0CLe4; arc=none smtp.client-ip=209.85.208.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="a2Q0CLe4" Received: by mail-ed1-f74.google.com with SMTP id 4fb4d7f45d1cf-671495fcedcso483147a12.0 for ; Thu, 07 May 2026 03:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778148055; x=1778752855; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=WH9SSo4GccpYaiPiSUekopeXssDOSRO2Zrgq3dTy8No=; b=a2Q0CLe4xRjVWz9SJRBUaALcvX669IX929RFY0svustiCS0Bnh0wnGpoQgPRdytQdt dtsG+WeQRg5E/vBfnCGYCMgxqFnxqh6fIY6m0bs6ty/AFR0dpRzTd7e/7Tdmy17cDsVP KAMTtOArJa/ldQhY2lrHAYdmLrEQX5yuaQcnlBqiUJ9hnCLNdv/LjZex1ymjcEypJq2P MFsjaI7e8VjTaYpECGrUqnx+V8lCFiTh3NIyb5Gjcl30aJNvhfsEwh9Kfb5eoVtJ5PNU buq4qY6/4ayGRvLZi6HICBzx0A/0vQ2iplUxjqlgBm2JUpZbVNS3LlHkKAHOhArgQVtc B5NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778148055; x=1778752855; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WH9SSo4GccpYaiPiSUekopeXssDOSRO2Zrgq3dTy8No=; b=Ur8d9XeBCoF6AZExbtISeFT23U5hVOlt0IjEG0CKs+P/m2wGR7gWY01ZylPlUjb2Qy 5APtmKoTwReBh7kHMqXArqrfqCdFvY3gdHjOTOssad6e3vhihYGwLoHsvdN8ebbVEI93 hpiZ5N9I2GpjYLki/meorqqgGaoL4mb0HQZeCfGqzaGsXKAPvs6vkMZABVxvM1KSIozH ZPSx9Oo/weTLR+1KdrLTPxQGvfHWanrJLqZptixtjy8XRoo1zETLLSgxqhZ3kmbwPDz1 DejXnrDof4RKgnmag2t1Dm3YfDOTfKXBFJjmshnlqeWKbD8dLCnTFK3ux43AoXvLr3q2 vmIQ== X-Forwarded-Encrypted: i=1; AFNElJ90eNbMY3EHWLWRUD8lQMz47aWeB7rk2xzwDLE9rpTSio1Nn5Zl0IJge/57iVQGpJB2SpW2gYVQ9WcMask=@vger.kernel.org X-Gm-Message-State: AOJu0YyUnf9xB53gg9MxcbAwXznqnpMp9o0RFBKzwtoI6ektf2oPT7WH cc/FPQMy2N3yMlLtgKSegrUQKVYWnFiAFZUilx/p1tuyCg/+Ng9bojDDk/qKAMOsxGtnIjXRgJH ROVMeVmqEshuFFkz1Cw== X-Received: from edcm9.prod.google.com ([2002:a05:6402:4309:b0:67d:50a7:9bdd]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6402:50cf:b0:670:64fd:2301 with SMTP id 4fb4d7f45d1cf-67d642b0556mr3796978a12.15.1778148054012; Thu, 07 May 2026 03:00:54 -0700 (PDT) Date: Thu, 7 May 2026 10:00:52 +0000 In-Reply-To: <20260505171637.17e20b98@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260504-binder-netlink-v4-0-601b41cd25b2@google.com> <20260504-binder-netlink-v4-2-601b41cd25b2@google.com> <20260504165858.4882730b@kernel.org> <20260505171637.17e20b98@kernel.org> Message-ID: Subject: Re: [PATCH v4 2/4] ynl_gen: generate Rust files from yaml files From: Alice Ryhl To: Jakub Kicinski Cc: Carlos Llamas , Greg Kroah-Hartman , Andrew Lunn , Donald Hunter , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Matthew Maurer , Miguel Ojeda , Boqun Feng , Gary Guo , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Christian Brauner , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Tue, May 05, 2026 at 05:16:37PM -0700, Jakub Kicinski wrote: > On Tue, 5 May 2026 09:10:17 +0000 Alice Ryhl wrote: > > On Mon, May 04, 2026 at 04:58:58PM -0700, Jakub Kicinski wrote: > > > On Mon, 04 May 2026 09:04:55 +0000 Alice Ryhl wrote: > > > > tools/net/ynl/pyynl/ynl_gen_c.py | 139 ++++++++++++++++++++++++++++++++++++++- > > > > > > No. Rust. In. This. File. > > > > > > Just commit the artifacts. I truly hope that this is the only Netlink > > > family we will have in Rust. > > > > There's no reason to react like this. I have not ignored your concern. > > Last time we discussed this, the discussion ended on splitting the file > > into ynl_gen_c.py and ynl_gen_rust.py, which you did not reply to, and I > > actually spent some time working on that. However, I felt the change was > > non-trivial and I wanted to discuss whether that was the correct way > > forward before spending more time on it. Therefore, I kept this patch > > as-is for now and noted why it was non-trivial (sharing of CodeWriter) > > in the commit message, until we could discuss further. > > > > I think you are probably right that just comitting the artifacts is the > > simplest way forward for now. Especially since Donald is apparently > > working on splitting up the file for strace [1]. On the off-chance that > > a second Netlink family is ever added, hopefully Donald's work has > > already completed and we can easily add this support in a new file when > > the time comes. > > > > I guess another way forward is to commit a copy of the python script > > with the Rust support to drivers/android/binder/ and I can run it > > manually if the Binder yaml file is ever updated. > > Could you _please_ do what I'm asking you to do instead inventing your > own solutions. Just commit the generated files and leave the script out. > We lived without Netlink code gen for 30 years. I will drop the patch in the next version. Alice