From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DCFE34DB72 for ; Thu, 7 May 2026 11:08:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778152090; cv=none; b=L7uQVngeND+eBAS0g6fI3daP/vpBtN/a3yK7KpF+YUhp2nvptHGv/i5SBH+bN8pLBE/LrlAlOCwDKL5xk42TYBDvRk/ssPLV5kLOZveUKThjkO5S4mOmkvjxp0oExutDuTptG4Y58EqFMIb7rXD1y/z+TcYg3a/C4XnEa+KydgI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778152090; c=relaxed/simple; bh=Nsrc00XMPyX354SuXe3nqx7fE5fihqR3ZqDdgpTbxkw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ufCjZZtxI6lC7onmN/KNUUYZQgX+TZmsr+WmcykcA+hqHmbuhmUoap8Z0TLRDb1+LxW547pfhOwaoX84dnhwZCZHl/ZB/Wcf/HeU05hHc+a8F+aoTEJUy4Z1vJ3D8ceTcAQOSJMozzV9MogJl9jq62U7iZpFdpOj+Aqbmi4vUDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20251104.gappssmtp.com header.i=@resnulli-us.20251104.gappssmtp.com header.b=vjhgEdP4; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20251104.gappssmtp.com header.i=@resnulli-us.20251104.gappssmtp.com header.b="vjhgEdP4" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-44985f4ab0fso415043f8f.0 for ; Thu, 07 May 2026 04:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20251104.gappssmtp.com; s=20251104; t=1778152088; x=1778756888; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Kgrq7ox95689Ig8vha0xiBqXHGOC+ZuPbRsEee974HA=; b=vjhgEdP4XA6KSiKerw/89U6Z3XXtAo8tQ78KeMc9QWmjVF4e6YVKYWxt5tYkBJnFaU P2zcDqAQdZfRk/Z3MbZAi0Ypr6nkx6IzwgYMAvy7/fwPWXFSV3eRc5pT5bqYyLlofl8O uq8AnIAklk5MLvi6DQeEEtPXtnmIDL8dr8HADz2DAhE4QRJl7Iv3gjmHWJfwzn7QBzmx FSwGSsV26p+a2GVUXVjhGKFT7c7igFfu/FIn+sObWqLJw5M0GU+JqBwkWwFjd/gTCJmm mxT7IX3+uZKfWeN8x/7GjGrUlY3eyiJceB65Soe39Iqh0l+FPVIhauFzr/o7oL/G30lA GBrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778152088; x=1778756888; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Kgrq7ox95689Ig8vha0xiBqXHGOC+ZuPbRsEee974HA=; b=hzGNH0N6vRrQllDmyCxHxE/Z8OBeyq8Zj3IVliJ0QjgUAaxhIOkzrFpJOqy5oHFhE5 aqU20DD9pVd4TryG+m1/yfLb1pKemSGaYLStjYKFA6+QNd+DZ4mpD8W8UWfyvf8YsX3a co6LdnBS4dIMU98YjIkS4XACcFi8AWwUuFpg23UsE5uIA59PwnCCeN9BSBVhLgl6e+os uHl1YLw19uOL+E+hjoYtyYRWhsNbGfpHI8mzq0TXC/b+YfqKS4e8Ip8ruELMGUZmQhpy hMd6w4LjmLrR8vFemn08wBX+S5znH3xhDl0J2cJTPYMal3fXoqPqDS6tV1lqDQCSZqaG Kjjw== X-Forwarded-Encrypted: i=1; AFNElJ9rPT7i0Ezv/Sv1EmRAL2hbubmiohiIrilpIf2C2PpMMAC8gR6ZSC2kdZU8FZ2ajVJ7jLuDRr6OF4bs45E=@vger.kernel.org X-Gm-Message-State: AOJu0YzNyDBF04iTADl7poFr1d7xRXTpr1JtkrSsIXNb6D7yD4E1Dexd 76YrnI0DWIU1IyO1CoZNzVa8O/ZupeE4quT67NuTdzXx6aWLT92jRx95XpaPFy7SmBg= X-Gm-Gg: AeBDiesnu8sDq0qsYw9XCoCvNc5jvVXBbL1/VXnugKSOxnhoq0XFoSkwlsa7yz6qnlc EuQqCJbSr9p1w7wgvukejHJggUQI8CTY1GB52NnItzidiqAdmfGc4A+T0dnDW6sm4pOjcZRQtUi m+KxAXjV1Zfx6+7GOw+9SRSAjhMCtQ65txS0Tb/HMWyswzrGjuHh4KAH1F9h1UZCco6im13DrOi HAYVTWHCFK1reSM63Or49cDxOtJdIyVG2+hVbXomSJhizxPSN5ZjngplQ8v4//hAPiNIpG/nSsi CWZFkb4bPcBbObAn9aJBahydN06ptO0LEQNnZl1Twq8ggKK3kEzZr9PRYN0OVnU+Zg3xNWJ0vMK 2aGAZnbg2OcZsIRiHk9X6nvTFsqcnsVFW+SeXv7PNS4SSBO9lIMjdhn3rIfd5g+4hODpwuTIQ8p V7gj7OowIKDF7Y+t9am/GQHjXFN6M8tYEOwaQPrj2dh+CXD6yHzZlpDw== X-Received: by 2002:a05:6000:2c05:b0:44a:aa3c:5927 with SMTP id ffacd0b85a97d-4515d5c69b6mr12915400f8f.29.1778152087145; Thu, 07 May 2026 04:08:07 -0700 (PDT) Received: from FV6GYCPJ69 ([2001:1ae9:6084:ab00:6064:31aa:7680:7221]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45054b02abbsm18552017f8f.18.2026.05.07.04.08.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 04:08:06 -0700 (PDT) Date: Thu, 7 May 2026 13:08:04 +0200 From: Jiri Pirko To: Jakub Kicinski Cc: Ivan Vecera , netdev@vger.kernel.org, Andrew Lunn , Arkadiusz Kubalewski , "David S. Miller" , Donald Hunter , Eric Dumazet , Jonathan Corbet , Leon Romanovsky , Mark Bloch , Michal Schmidt , Paolo Abeni , Pasi Vaananen , Petr Oros , Prathosh Satish , Saeed Mahameed , Shuah Khan , Simon Horman , Tariq Toukan , Vadim Fedorenko , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH net-next v3 1/2] dpll: add fractional frequency offset to pin-parent-device Message-ID: References: <20260504155340.411063-1-ivecera@redhat.com> <20260504155340.411063-2-ivecera@redhat.com> <20260506183342.767b5fbc@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260506183342.767b5fbc@kernel.org> Thu, May 07, 2026 at 03:33:42AM +0200, kuba@kernel.org wrote: >On Mon, 4 May 2026 17:53:39 +0200 Ivan Vecera wrote: >> + At top level this represents the RX vs TX symbol rate >> + offset on the media associated with the pin. > >Isn't this a hacky hack? I'd think that pin is in or out. >Having a freq offset between two pins or pin and parent's >ref lock makes sense. This new interpretation sounds like >we are trying to shove a difference between two pins into one? The pin is in, but it is associated with SyncE port that has RX/TX symbol rate offset. As the doc says, the "offset on the media associated with the pin". Why is that hack? > >> @@ -299,6 +299,10 @@ zl3073x_dpll_input_pin_ffo_get(const struct dpll_pin *dpll_pin, void *pin_priv, >> { >> struct zl3073x_dpll_pin *pin = pin_priv; >> >> + /* Only rx vs tx symbol rate FFO is supported */ >> + if (dpll) >> + return -ENODATA; >> + >> *ffo = pin->freq_offset; > >It's easy for driver authors to forget this sort of validation. >We should fail close, so it's better to have some "capability" >bits or something for the driver to opt into getting given format >of the call.