From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ABD13F23AF for ; Thu, 7 May 2026 13:15:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159720; cv=none; b=Oin+9jUhNzdcrsrzHpAo15YDtSwsbLAyCgP/JPx7cPR9xs5kTbe6L80xWGuOyYNmjmDLbP40pdATkAIIf42eU/ZJN3BwiB5t9RT1x6rR+5SBaXkLc8fnkXxGIgwJ9OTlUyIVW/ueRTmpFkvgF/QsACUoxq0zJp5XWHKo/2AXY7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778159720; c=relaxed/simple; bh=TJ0W6FAj31MR3dvN8d50sBuasX/e1T3Sfw51y9p35pI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=RPWHTs1I6qHCOZrE5X9guNSM4Egtc4lFnpRQ6JRgtLMv4WVxB/LYX6BsWxaAiPPGCy0FxUhrllat/EwNcqCwLmNT8SP64SvxvA1l4WI4eQ8QXVqGzxEFK89kLPEopJ+U9vTToVLoXpe7OWx1KPJjdwCni8gJFDuCVfKMiuCjyQ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Uga1GR8T; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Uga1GR8T" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c7948640854so483566a12.1 for ; Thu, 07 May 2026 06:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778159718; x=1778764518; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ieS6nKC0vkJ+fsaqZW4LZNoV5kL2RHdXCSYZo6FgAl8=; b=Uga1GR8TjgztUCTln4ry+JZT6SPApuSj79zy0gxM1l4sG/wyraeqV8bDMLcGd2a9GD osr9aB2DLwMUm78zfwApSH2yhStUipxq38+obL36+qMdDTxLQd2ZnOAKF+2eZLVH/8Th 0VK2QWYW2gjfcy4bPg9x7uXJEOuuSeSV1srt4tQQaLbGoBPqyWyepKzAZOV47OT/lxsW PE3JXDPUZRnblrTQyfmNz2obMtTalz/8KpDA6bLRjeGUuDsczACBmk7EI/mti1ZaJ+wF et1Lwel8//Ao6Xk7wBKy8A7fvwjcjIeOKdozjZkiMl4vljaxUug7kP3VDgCKWgUfkZVa 6Zvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778159718; x=1778764518; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ieS6nKC0vkJ+fsaqZW4LZNoV5kL2RHdXCSYZo6FgAl8=; b=nFxowgyGvEvwG5hKffEAgDu5FZkMG0uTWIBTh34UEcT6R6KBTwS2QvvvlbewdVJ3Od 4NxpnAo9z3++tvDkdkXyBOdS40+v8CJFp6od5NTtIzqHcsDGlmbqJQ/XI76GhYvO4Asg l0qZJ4ohDGBQ2yTwa1fQlT3E/ikxQP6HFpjwl3Ip8pJqqsgC4dji9i22cebzFB+QS+ZA o8XyRfLdJ28RbtWosM16tmx1czKbZnV7E+jnV+sx/4FfOaHVETtxXnj/Go24ZhOz++Zb A+Ev6Y3cU1M+MyqVf3n/zy18SYq7KDUomQllTn0iA629TyLZUhH6UqY6Nju4UBZ6CSw8 bmUA== X-Forwarded-Encrypted: i=1; AFNElJ8vFdk6fq8kgVW5y7hRHYlEG0Q0y18xHe8fKfDIxDRkhB5gKbx25UMiPRJ+xCK1cWF7Kjm4d1KS1Eoy3q4=@vger.kernel.org X-Gm-Message-State: AOJu0YwFI7vPpt3dtcpVyGnQxeUJAZgslXPzdOb6bp9imqOj60hbhEVp JwE6EVN51sx6ghJ+FURNY7xu3eUJemjczw4hDf0bp0e2k2nFcruH3GOGhv10nkbZ4F/JMMcrk6N f1F58tQ== X-Received: from pfbld11.prod.google.com ([2002:a05:6a00:4f8b:b0:839:5556:c979]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:140e:b0:824:afe1:f7e3 with SMTP id d2e1a72fcca58-83a5badc168mr7568181b3a.15.1778159718060; Thu, 07 May 2026 06:15:18 -0700 (PDT) Date: Thu, 7 May 2026 06:15:16 -0700 In-Reply-To: <20260507003613.1784851-2-vannapurve@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260507003613.1784851-1-vannapurve@google.com> <20260507003613.1784851-2-vannapurve@google.com> Message-ID: Subject: Re: [PATCH v2 1/2] KVM: x86: Introduce arch specific has_protected_pmu state From: Sean Christopherson To: Vishal Annapurve Cc: pbonzini@redhat.com, dave.hansen@linux.intel.com, rick.p.edgecombe@intel.com, dapeng1.mi@linux.intel.com, mizhang@google.com, kai.huang@intel.com, jmattson@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Thu, May 07, 2026, Vishal Annapurve wrote: > PMU state for TDX VMs is virtualized by TDX Module [1]. Introduce > has_protected_pmu state to track the pmu state for such scenarios. Disable > KVM's PMU virtualization framework if pmu state is protected as > additional enlightenment is needed within KVM to control/manage the > visibility of PMU state to such VMs. > > Additionally disallow userspace VMM to toggle PMU state using > KVM_CAP_PMU_CAPABILITY if pmu state is protected. > > [1] Section 15.2: https://cdrdv2.intel.com/v1/dl/getContent/733575 > > Suggested-by: Sean Christopherson > Signed-off-by: Vishal Annapurve > --- > arch/x86/include/asm/kvm_host.h | 1 + > arch/x86/kvm/x86.c | 8 ++++++-- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > index c470e40a00aa..8371dcaaed1a 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -1422,6 +1422,7 @@ struct kvm_arch { > bool has_private_mem; > bool has_protected_state; > bool has_protected_eoi; > + bool has_protected_pmu; > bool pre_fault_allowed; > struct hlist_head *mmu_page_hash; > struct list_head active_mmu_pages; > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 0a1b63c63d1a..4836e206f64a 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -6910,7 +6910,8 @@ int kvm_vm_ioctl_enable_cap(struct kvm *kvm, > break; > > mutex_lock(&kvm->lock); > - if (!kvm->created_vcpus && !kvm->arch.created_mediated_pmu) { > + if (!kvm->created_vcpus && !kvm->arch.created_mediated_pmu && > + !kvm->arch.has_protected_pmu) { Align. > kvm->arch.enable_pmu = !(cap->args[0] & KVM_PMU_CAP_DISABLE); > r = 0; > } > @@ -13375,7 +13376,10 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type) > kvm->arch.default_tsc_khz = max_tsc_khz ? : tsc_khz; > kvm->arch.apic_bus_cycle_ns = APIC_BUS_CYCLE_NS_DEFAULT; > kvm->arch.guest_can_read_msr_platform_info = true; > - kvm->arch.enable_pmu = enable_pmu; > + if (kvm->arch.has_protected_pmu) > + kvm->arch.enable_pmu = false; > + else > + kvm->arch.enable_pmu = enable_pmu; kvm->arch.enable_pmu = enable_pmu && !kvm->arch.has_protected_pmu; > #if IS_ENABLED(CONFIG_HYPERV) > spin_lock_init(&kvm->arch.hv_root_tdp_lock); > -- > 2.54.0.563.g4f69b47b94-goog >