The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Thorsten Blum <thorsten.blum@linux.dev>
To: Lee Jones <lee@kernel.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Andreas Werner <andreas.werner@men.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: menf21bmc: inline i2c_check_functionality check
Date: Thu, 7 May 2026 16:14:43 +0200	[thread overview]
Message-ID: <afyeU6WEl-TLVVj6@linux.dev> (raw)
In-Reply-To: <20260507134708.GN305027@google.com>

Hi Lee,

On Thu, May 07, 2026 at 02:47:08PM +0100, Lee Jones wrote:
> On Tue, 28 Apr 2026, Thorsten Blum wrote:
> 
> > Inline the i2c_check_functionality() check, since the function returns a
> > boolean status rather than an error code.
> 
> This my well be a personal thing, but I don't generally like functions
> being stuffed into if () statements.  So this one is a no I'm afraid.
> Please leave it as it is.

Wolfram (cc'ed) asked me to change the call sites before applying this
patch:

https://lore.kernel.org/lkml/20260421161607.61314-3-thorsten.blum@linux.dev/

Also, nearly all i2c_check_functionality() call sites already use it as
a boolean value. There are only 2-3 call sites left where it's still
used as an int.

Should I send a v2 with a local bool variable, or would you reconsider
inlining it?

Thanks,
Thorsten

      reply	other threads:[~2026-05-07 14:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260428165800.590496-3-thorsten.blum@linux.dev>
2026-05-07 13:47 ` [PATCH] mfd: menf21bmc: inline i2c_check_functionality check Lee Jones
2026-05-07 14:14   ` Thorsten Blum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afyeU6WEl-TLVVj6@linux.dev \
    --to=thorsten.blum@linux.dev \
    --cc=andreas.werner@men.de \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox