From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E4C3313539 for ; Thu, 7 May 2026 17:21:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778174520; cv=none; b=ag8iJ74hEXAR0LxQpfmCoYvcG4nwO1V1KWXoYsfvdyBluq3+xki9ik2OoXShwN5WuI6uGRavb79Ax7YIGGpffVE5VpgYG1q00qD3ySx6k1pWtYusq+z68BpZgcWSBOO+4+93C2j5pA2EFrKVx316chOhIaBtWYaQSy6ynyl2BnM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778174520; c=relaxed/simple; bh=YAY3+X/ZmNNgeGMeqRFumBfRnR00uiwCTRTDUaSfth0=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KpzehqpDfqFenRo4nJzMNQhbnMZxDuGzCJ2cMjZIFPhf0Ms++quSnyCxoP2jCHyreuRCX0N125z8jDWT3O2qbGd9B4SktrYLruERf8CdBNBUkHio5/alceBIo/FlaJEV9MD6495eFgkOAvgIUDDRYjxbaIfl7ufoL24qfftc2Gs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XJqncaSo; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XJqncaSo" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5a0ff30b240so1612126e87.0 for ; Thu, 07 May 2026 10:21:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778174517; x=1778779317; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=N0BFdmnbQQLTsb2DZYRMYZ7jk/pd1z0d1fxF0EQZ8kI=; b=XJqncaSon8ebISNceV1xzdoilXSN6hQXRxSF3DAulOxwI3fK+SNGkVlg6z4BEXAvt0 premdar6G1OmtGUFZ62wqvGO1D5FJ+fOKhtSZfyoQHPiYaldMqoNSb4Znq7pSedkE/Kc TzcSwV7Qv2hoZrhDz73pttLI1gpEuDH2Pyv2KrpkXZfsNKl/xMwceXUjngPTPOnw8mjq tCajRjHiyi5NP4jhYNhMZVJ1jgTtdLRfLgrF28OUKBRuQk3oUvg+vyTSk9Uq00V55ouw k8aEdCWXyzMU677tTTnyz2ItE5Dj3Ezl55d6W25nYco++8N9PyAl+BSOSNAMgOl8ctyP r26w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778174517; x=1778779317; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N0BFdmnbQQLTsb2DZYRMYZ7jk/pd1z0d1fxF0EQZ8kI=; b=YkYjCGo5+hR+LnLMdA8av8y7B0yr15nFBCE1TwjraGemFw6yfRf6k5QcEp6exAfhsH oPR2S7EaF6gfPYjuhhgTPMFSlGGQ+ER2WO/mYouWlGZhK4GFbxGtUVusmXsuIXiKOTGU SmEc3WQXBzBysiOSzhF7EzcKXsyrZRK1uyvnPV65Mkfhn229oy78sEJL87HvrKRaxQBh I1xOLQAq5NHqzV7wodeJkRonp5YjOTM7jAYaAxv25K3nzS+1D44heTJh0ItdueDs2Pnk odYdJElZZsnS1Of3WFdCfbW1zIuB4Cvmi8a4GvU9nTmUsv8aQbZJP/gIlQgKUU5Pb2vK XY0g== X-Forwarded-Encrypted: i=1; AFNElJ+ybnwwXQxxFw/QPPVFqVBlLabwKjf47wz++su4jgw9cfW0htbHA7tXVy6pukvpTzThAHv/z5d2R38x3S4=@vger.kernel.org X-Gm-Message-State: AOJu0YzgXh+2tKPcccz9fx+F7bT2gFC9fuM+KZWr2tRLtAPbZNQlzhSH gkNMRoqU7flVyEiXRblnnavaEYmaPgS1DKLy9WJNBCkDqrVZ+wxZC+l8 X-Gm-Gg: AeBDiesH3H7RfoziG8T6PEaiDA0p/8yjLFLQrehXS529fQlPSrAgq2YyFHqEM65t9tO kdynw4s1/DXhN5neYVdafnN6ayV11LZQ4Vh5DaMC9tb0YK0E9X+zWF0LhRm83ISMu+Fh+xdDA0G J38pZ6Y/C+Nd5GOFMB4NPK13nGmckq7zgtsOEJl+pYVGD+sNPkDODvZjgDuG5I1mH1CSA8fwzB+ D9rv0v3NzIIE4MpXDoeLQGkBmDvynagH2sHPnN6No9H8f46OsJTnYhIh9JnJcQ7ENEDmAr7Vwgd rLh/sZ8Xu6z98nrtOy/FkI4ZyKFGLsyvdxrR+A2Fwd/hHqLHcCE5uOWbGXOCJB2KK0BqLCFuMDV aCszBso0GbgArSF04/OabYIAnLlPtWOP33E+WIAj/sXhf3FOQKCEjuxm77obiJX2T X-Received: by 2002:a05:6512:3e14:b0:5a8:65c8:dd87 with SMTP id 2adb3069b0e04-5a887adcd10mr3268132e87.3.1778174516997; Thu, 07 May 2026 10:21:56 -0700 (PDT) Received: from milan ([2001:9b1:d5a0:a500::24b]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a8a481a114sm84164e87.83.2026.05.07.10.21.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 10:21:56 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 7 May 2026 19:21:55 +0200 To: Shivam Kalra Cc: Uladzislau Rezki , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alice Ryhl , Danilo Krummrich Subject: Re: [PATCH v12 2/5] mm/vmalloc: use physical page count for vrealloc() grow-in-place check Message-ID: References: <20260428-vmalloc-shrink-v12-0-3c18c9172eb1@zohomail.in> <20260428-vmalloc-shrink-v12-2-3c18c9172eb1@zohomail.in> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, May 07, 2026 at 01:13:35AM +0530, Shivam Kalra wrote: > On 07/05/26 00:17, Uladzislau Rezki wrote: > > Maybe we should consider Fujunjie approach and borrow his idea to shrink VA also? > > In that case, we do not need to switch to vm->nr_pages? And we do not > > need > > > > [PATCH v12 3/5] mm/vmalloc: use physical page count in vread_iter() > > > > ? > > > > -- > > Uladzislau Rezki > I didn't want to change the va in this patch series and wanted to keep > it simple. > If we change the va, we will also need to rebalance the rb tree. > I can work on a followup patch series if VA space pressure is critical. > Actually it is not critical. The idea is if we shrink VA then we do not need care much about the size thus keeping vread_iter() unchanged as well as [PATCH v12 2/5]? at least partly. I am find with it anyway. Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki