From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ilvokhin.com (mail.ilvokhin.com [178.62.254.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6873A43E9FF; Thu, 7 May 2026 18:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.62.254.231 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778177425; cv=none; b=j8c1QbyqCN83srVdrDZnQRRjclPk3UTtQ+nNHneogTTMi/gNrsVC5KlscehLzZurwBmClOD5iMzCLbvKJ8oRioUGME7jbbDCjvrv5gul8/bYMPOxfLlfIL9NrlAJSIXD7MaeMdRQ922HjT8Wa/c7ssx368b9m8klY91lOHjFbQU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778177425; c=relaxed/simple; bh=XlsJSkJu7uGWr4gtKsWIcp2zHFxisuJ0BEEM0g/h9Aw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ly9WhBtLZGtd/FJ7Vq//cYGL9PkxXSuV7cIlwyCzDohAs0pvR/Y9LJaM99QmtRQ6BR3DNwi92ofpH5hPh8tKIhHwP9OrVr+vOAr81FDyOepWybchwyDWoQHhRFlF8J7WePf7f5M/ZotSwl70J0QFHo0RK/U3Y2VkRde/OXtvKu0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ilvokhin.com; spf=pass smtp.mailfrom=ilvokhin.com; dkim=pass (1024-bit key) header.d=ilvokhin.com header.i=@ilvokhin.com header.b=OSEyMWuN; arc=none smtp.client-ip=178.62.254.231 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ilvokhin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ilvokhin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ilvokhin.com header.i=@ilvokhin.com header.b="OSEyMWuN" Received: from shell.ilvokhin.com (shell.ilvokhin.com [138.68.190.75]) (Authenticated sender: d@ilvokhin.com) by mail.ilvokhin.com (Postfix) with ESMTPSA id 7EBCBD011B; Thu, 07 May 2026 18:10:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilvokhin.com; s=mail; t=1778177416; bh=nY/8STcP17wypLqIMnvcBtkQl5e9XIg9NLgVj+cI2gI=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=OSEyMWuNxVXWFhRzBhkZDTBiz+5TltnQiEp5Uv3+bClIfu2NY4i9G4IT/BwShML1G qRv46qHsvjwY2h+iQ1OOD6RVQ06VSddnN0YKEQXKrQf922XlZEXHFLawKcbTLD66Um numpb/LiBz81Gq7Vs6DYAWpIO69zrYHpkPIjAUVo= Date: Thu, 7 May 2026 18:10:12 +0000 From: Dmitry Ilvokhin To: mike.marciniszyn@gmail.com Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Alex Deucher , Javier Martinez Canillas , Andrew Lunn , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Mike Marciniszyn , stable@vger.kernel.org Subject: Re: [PATCH] drm/fbdev-helper: Fix deletion of stub for drm_fb_helper_gem_is_fb() Message-ID: References: <20260501204313.127616-1-mike.marciniszyn@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260501204313.127616-1-mike.marciniszyn@gmail.com> On Fri, May 01, 2026 at 04:43:13PM -0400, mike.marciniszyn@gmail.com wrote: > From: Mike Marciniszyn > > When CONFIG_DRM_FBDEV_EMULATION is not defined this error results > when building amdgpu_display.c with CONFIG_DRM_AMDGPU: > > error: call to undeclared function 'drm_fb_helper_gem_is_fb'; ISO C99 and > later do not support implicit function > declarations [-Wimplicit-function-declaration] > > 1777 | if (!drm_fb_helper_gem_is_fb(dev->fb_helper, fb->obj[0])) { > > Cc: stable@vger.kernel.org > Signed-off-by: Mike Marciniszyn Just hit the same problem, thanks for the fix. Reviewed-by: Dmitry Ilvokhin