From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D2084218AF for ; Thu, 7 May 2026 18:40:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778179224; cv=none; b=hLivuXyRJqWnoY3avT/e4lwBZBl9OhB8Yp4r9Q62Z1zp9fhybXgTpS8Lq8GHtUyersM7+EKiyNTvi2wkS7AXq7X3ddl504AQcYrgHTiENyIaYm0AiG1yrf1O8HuMdXJZtmV2buBRT9dBegBpj2wWvw8clVBcrlzoQ69hQlwFOxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778179224; c=relaxed/simple; bh=ln5AjyNWfzYrFxuevowteUP8a6ELykKUVDzygksz2jU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DHKMh3+N+kjjTnvMe46h+MNW7fAJV3YsWoG1vHp9H8z+fy6wamsnTRvsjWDkKu0qNF+Gjp58nybP0NvGa3VrtPprZ89nphmnRafi1qQLD3iSOQNCBMwmS4yLhYv4lSdmDHr594iLs+KSxWtEULO0+bMaLIQ6G9MceDORZQHcdd8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hOsvQoeC; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hOsvQoeC" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ba180a022dso16785ad.1 for ; Thu, 07 May 2026 11:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778179221; x=1778784021; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NhP+n7DxEFBfq4ANgD7pXobqb+7/slgfnCpBlFNfz/U=; b=hOsvQoeCn3CnpDmRI6Plgx/Z66A1+NsQegAuRkT/ObJTzfmdv67gDdWmE3m3nVAwvo nfgiwDpG8v6QDvRHix+QeAJmqVKQgbt6O/rXg8Aiz7JSthorXs/MO4oyimwo2UA/OB9t LizuP63SAAMtNW3nmIaR7hKWrmw4wJAnTZgwHs0b1Ukz3B7ar8F68dGCLwvRNVAzbdzh JwfgI76EeFVh58rpZjs5pSOMZIjycE5ieY5vpxnXgGvzimhwyt55hqk0sqsiYSUXn1x8 XayGTwUFkgMUzlJFfEm5grDTCYpvajcDJPq6achSuY8e6Tj6hvBSgVYI10PICPoe7XxO px9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778179221; x=1778784021; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NhP+n7DxEFBfq4ANgD7pXobqb+7/slgfnCpBlFNfz/U=; b=SXlK90drJPrSb3kbWb87lNhdu/8/nYA2fQFeLEQE6v7shvFFGD93d2/kOcXlZhE9Lt Ss6siwVFuWYs0N6U8UanLYvkrtl+/TlGSJ4CGQ0x4960UqQpy5hHtaQF2tG6J7P5heJ8 o8JSdf7MNggsSXRF/IZHP3Tyt7XGt6v1PVEqh9gZooqP/N2rESKU+h6D6IeeZLAHDWPM WJmH0eL9EuXUhYv4m0J1RmK8pBdXPHAa025JwK/PT1BPkpdvLpSGmyVZuJOJZwWrrMB+ cafWs2YtGwwJGvYHiUI3/QHBkp3irYG5nYJXOsXOcVABRJoIgdL6f7HmH5ryz9Z9T8Wc ggLQ== X-Forwarded-Encrypted: i=1; AFNElJ996dJ+E8uDr2uRzQRKhFSgyWnP+eqvu6IRUhgillEhcv/YmowQq50fM09c6dbR+ItmMm912REk8k3fHSc=@vger.kernel.org X-Gm-Message-State: AOJu0YyUcNBpitGPvaVHy4OYt7LS6pj2G2U5NQWZh3f+TYqi+BFUP+QH JBaKQ6l2pGFzMhKKVe0M5ENUmQ94mtyHXTPPNmdc+xcYuNhl5a+nkBdaLaB558UsqA== X-Gm-Gg: Acq92OFJ8eeXZUSbn3GAIG0dsOaMs84II9H4rcyqWMMAXD9YprlTjFsYz+TM9H3PmgW M8o5xmQymcWAJa3ttYMcndk3UrLhXskbJGbo8WFaS3T7QdPelXyWtuJ9/YrspIzwiInP4Px0XRh Z99WyhPAIjfypttJBQcdREH/GXN9uSQzI7lId3rD+/xS+SgNDfWuVSDQHCHqz/GI0KGi900wU/n yfO1dNmAkwC4ybzRsXCVkqOQRtB/7F2lHpY/FXwWul4MQQy2AFV0fG4Zazi9f99Y3V5xTjcreGH glZuSQjc5dBdwZMTbs8HiCpNiuDoOjpGTRgV8o+9m4e+DJRUbREycOKnfhaGN8+ogelNtCLYlhI A7f6DzlsZjqi16keMTuwsKScNgO/jYQW0hRl6gOiIaMetYlssFNd8OxoKfeF9sp7cHLkoiZIJKT yRiuEFPc9NHKlMmQoFlvD66HbJ1KhPv2DqV4tK1oCniU8fQn9SsoQeWj0EKTs4HYZ7Hu9aYw== X-Received: by 2002:a17:902:fc87:b0:2b0:5c88:51e1 with SMTP id d9443c01a7336-2bae9e67750mr620315ad.14.1778179220958; Thu, 07 May 2026 11:40:20 -0700 (PDT) Received: from google.com (153.46.83.34.bc.googleusercontent.com. [34.83.46.153]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83965d314f7sm10033887b3a.23.2026.05.07.11.40.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 11:40:20 -0700 (PDT) Date: Thu, 7 May 2026 18:40:17 +0000 From: Samiullah Khawaja To: Baolu Lu Cc: David Woodhouse , Joerg Roedel , Will Deacon , Jason Gunthorpe , Robin Murphy , Kevin Tian , Alex Williamson , Shuah Khan , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Saeed Mahameed , Adithya Jayachandran , Parav Pandit , Leon Romanovsky , William Tu , Pratyush Yadav , Pasha Tatashin , David Matlack , Andrew Morton , Chris Li , Pranjal Shrivastava , Vipin Sharma , YiFei Zhu Subject: Re: [PATCH v2 06/16] iommupt: Implement preserve/unpreserve/restore callbacks Message-ID: References: <20260427175633.1978233-1-skhawaja@google.com> <20260427175633.1978233-7-skhawaja@google.com> <39a010b4-7099-434a-b8de-5d03a75f2a9f@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <39a010b4-7099-434a-b8de-5d03a75f2a9f@linux.intel.com> On Thu, May 07, 2026 at 10:55:42AM +0800, Baolu Lu wrote: >On 4/28/26 01:56, Samiullah Khawaja wrote: >>Implement the iommu domain ops for presevation, unpresevation and >>restoration of iommu domains for liveupdate. Use the existing page >>walker to preserve the ioptdesc of the top_table and the lower tables. >> >>Preserve top_level, VASZ and FEAT Sign Extended to restore the domain in >>the next kernel. On restore the domain has only the preserved features >>enabled and all the other features are zeroed. This is ok since the >>restored domain is made immutable and can only be freed. A kunit test is >>added to verify that the IOMMU domain free can be done with trimmed >>features. >> >>Signed-off-by: Samiullah Khawaja >>--- >>@@ -251,6 +252,12 @@ struct pt_iommu_cfg { >> #define IOMMU_PROTOTYPES(fmt) \ >> phys_addr_t pt_iommu_##fmt##_iova_to_phys(struct iommu_domain *domain, \ >> dma_addr_t iova); \ >>+ int pt_iommu_##fmt##_preserve(struct iommu_domain *domain, \ >>+ struct iommu_domain_ser *ser); \ >>+ void pt_iommu_##fmt##_unpreserve(struct iommu_domain *domain, \ >>+ struct iommu_domain_ser *ser); \ >>+ int pt_iommu_##fmt##_restore(struct iommu_domain *domain, \ >>+ struct iommu_domain_ser *ser); \ >> int pt_iommu_##fmt##_read_and_clear_dirty( \ >> struct iommu_domain *domain, unsigned long iova, size_t size, \ >> unsigned long flags, struct iommu_dirty_bitmap *dirty); \ >>@@ -266,12 +273,22 @@ struct pt_iommu_cfg { >> }; \ >> IOMMU_PROTOTYPES(fmt) >>+#ifdef CONFIG_IOMMU_LIVEUPDATE >>+#define IOMMU_PT_LIVEUPDATE_OPS(fmt) \ >>+ , .preserve = &pt_iommu_##fmt##_preserve, \ >>+ .unpreserve = &pt_iommu_##fmt##_unpreserve, \ >>+ .restore = &pt_iommu_##fmt##_restore > >Nit: would it look better if we put it like this? > >#define IOMMU_PT_LIVEUPDATE_OPS(fmt) \ > , .preserve = &pt_iommu_##fmt##_preserve \ > , .unpreserve = &pt_iommu_##fmt##_unpreserve \ > , .restore = &pt_iommu_##fmt##_restore Agreed. I will change this. > >>+#else >>+#define IOMMU_PT_LIVEUPDATE_OPS(fmt) >>+#endif > >Thanks, >baolu >