From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B617031353C for ; Thu, 7 May 2026 19:12:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778181128; cv=none; b=nTFa6MAJ9jtkPRXEQedFJaJyW6dwXiAZJjYH5BwSALK4fT6vX/hCfPc/56aD04KJTGEm8K/l2WST634WnY1VGGpmMT4VoCZSSwa82REoi9aMJj9OUpbggMJ942zWrt3M7vK+vYdNaeUkVWM40ykmvKcXabscDGN/salTEkf56Eg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778181128; c=relaxed/simple; bh=GnExnCN96tusnI/4GDcVJqBbsYkMmNCTv9z3zMspfAU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r06GlVCi94o7mWEWBTXBySB7D/DxdaJBFqMqmjBqibds0bLInWVfZHuWEipQLhv3xu9s9wgob8rw6kNUWASAuoF8/+julKuu3KLRonWD298ychmYp/Lef8TB0I/7cR5zw0eFgVK3YSXb6YzJq970iP38zJMOAeHaagcRh/V79TE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VHvZiAOZ; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VHvZiAOZ" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-8d65f4073bfso172942385a.3 for ; Thu, 07 May 2026 12:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778181126; x=1778785926; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f7FKxb1CAp+U4Z7LLr7KZwzqX75i0WeSOczd8bry7I4=; b=VHvZiAOZ+/QVp6x3EuXlDfPlo9wNLX8ATSuQqJIulvV5hs7ajQMrUE0y7Ceh1xQWJU 9IuSOsXaPxECuAWBCYh055dtYpnQ7D/wi6JvIuFeAO9ABZSKt2EwZ9cZEa9iEdzilLHZ uXYUyRynQgpZBRKLk47B42k9JzP33fjJAwP2Ta40T5ST3/RACYsWJkjQDvJ2zXNGzfRf U/FjwOkJdcBYOkS/iZTb2/rDVnOg5lTXEHe+V+2aro/UzDTKmHACOdiYQmVHKyvFIsTc jXswXUt3+NJ8+E94/0K/9tKiQf8Ues4b2HkZfPNChi0joRV9Y8DZMqWvWzTuXjdo/DC2 F8pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778181126; x=1778785926; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f7FKxb1CAp+U4Z7LLr7KZwzqX75i0WeSOczd8bry7I4=; b=q4ZFV8RQgObWVQ69Bj7GgzH5m3KuaN+xA7hGbdOj8zb2Cs0m/am2BVf24Fc7evWrqA vf4XIczQWBtx6AStPN7FbhWLlk4+kVPGhcoBmlW1KQZlnCm5SMPECXTueukyv2O8z0/v Sr4x4v08BzwVNv90nTdmwQ3l3UpQNRzm4SEj/2GmExLRDi4vrjlMpHDndbGbtxiJifRF 8VQf7xKBFtZQ7YywM7dpN1Z1nYx5gysw9gljISQEEGWQf/IXBzqZmy26PcBSLQ3fvgyU 8m91ShEn2j87jsFptH8QejSq+a6qdhwVzyv9IqrJYQIiI5879y0eGuNcgPBqhAQT9dNG MBVw== X-Forwarded-Encrypted: i=1; AFNElJ8lLcYkw2wxvCUgXeA8LHVrJWLAdcx/8UoRCsJ+OlT+/eBZprPTK8sttxD1LotxQiNjoLsoHAm8ahUtWZM=@vger.kernel.org X-Gm-Message-State: AOJu0YygTfgnZMoXxw4XM2ADLPYZroebv47oEjfShRdPfiSwpaXPy7KB 0VVXD2OzApbvHgZzT+MtkmO4knasr8SJgfwOeRHfKC8nNBn6TQupcGYo X-Gm-Gg: AeBDieu1dMup2lEFJfYI+KRSmHouvS6eGyOjw+Bk/U5zaxqusYCEyrjsRh/4wlaZD3e R3C17Jq9y4B3ov8H4RQvsLpX06iamxXVMRXQ36POrzYPxpkOHNWi0HEu7nMwD+kV22KTr8V1c4q vVVJSX3Cgxg2UCR4Iy34GxYinG3S4GAwQ8HypE9bBP5FRHBhkY4ptA4r+TqpMm/BhgeeglO9rvL IsTcqF3L66W9lVXdjg05+6e6/nSqz9EW7HWEbiwbxs05fspzSzvsZiKVFZM8q6Os/JhLBk49pXf CI5eWdyt330WN9W89ff+HFiAwe0KaqTxG94+hng3JEda7Ehv5DEKQ6LkgT6WFxiB67rQd7Q1LGz XoKoGp9213YHwCIe+yXfy4ajoEt5P3kKmoPiflDwXm+kDfIsGPTI3pDi81m8ZrSBuxszWzWeef4 HJGfsjsbk0ECLO1z1cqc+8ZzwjfLYKWgXX1hSqSHPQ8Duv8VG2bH2ysPNA X-Received: by 2002:a05:620a:3197:b0:8cd:926f:6470 with SMTP id af79cd13be357-904d74bbfd2mr1491810585a.59.1778181125418; Thu, 07 May 2026 12:12:05 -0700 (PDT) Received: from PF5YBGDS.localdomain ([163.114.130.6]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8fc29a80784sm2010560085a.12.2026.05.07.12.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 12:12:05 -0700 (PDT) Date: Thu, 7 May 2026 15:12:02 -0400 From: Mike Marciniszyn To: Dmitry Ilvokhin Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Alex Deucher , Javier Martinez Canillas , Andrew Lunn , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Mike Marciniszyn , Jakub Kicinski Subject: Re: [PATCH] drm/fbdev-helper: Fix deletion of stub for drm_fb_helper_gem_is_fb() Message-ID: References: <20260501204313.127616-1-mike.marciniszyn@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, May 07, 2026 at 06:10:12PM +0000, Dmitry Ilvokhin wrote: > On Fri, May 01, 2026 at 04:43:13PM -0400, mike.marciniszyn@gmail.com wrote: > > From: Mike Marciniszyn > > > > When CONFIG_DRM_FBDEV_EMULATION is not defined this error results > > when building amdgpu_display.c with CONFIG_DRM_AMDGPU: > > > > error: call to undeclared function 'drm_fb_helper_gem_is_fb'; ISO C99 and > > later do not support implicit function > > declarations [-Wimplicit-function-declaration] > > > > 1777 | if (!drm_fb_helper_gem_is_fb(dev->fb_helper, fb->obj[0])) { > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Mike Marciniszyn > > Just hit the same problem, thanks for the fix. > > Reviewed-by: Dmitry Ilvokhin Thanks, but actually there was already a fix. Take a look at linux.git/master: commit 927011b65a875302d08709bbe82eaf4d0d96c5d5 Author: Yury Norov Date: Mon Apr 27 22:49:41 2026 -0400 drm/amdgpu: fix build for CONFIG_DRM_FBDEV_EMULATION=n I encountered this in net-next, but the above has yet to be put into net-next. Mike