From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB8AE377017 for ; Wed, 20 May 2026 09:44:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779270271; cv=none; b=fZYrOEWv5KtDgOH18AinleFzhEclEqE/l4CeJ1FLE7P4dYHsaFDU3yKZA/uz4Ui/CwVStZSKcy9M8w2iM5es1MbPnmqoe0Iy49+q5fIODIvzoMMlrG31LucJ4csz+l09N1RsCOzMrKZvtqncdagNsWoInjwQ1hRnEIleJ3RG/54= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779270271; c=relaxed/simple; bh=JC4OaBpKhBtPdm9QeuJWowzK8e9ZlXbEdnf37aORo1c=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lJ8dsoNAQAfRNFS4rg18qaWiLIdb1t1vWJOW/VRIv9mtuJK2d5JjAu5FPHIwSxpwXiKSzOkYo5iUIbULW0DroZO7BFqlyoJY3n+RChThMj57tVOUYOSqJqeDZvkhBUTLmvIomFSmO5HPQZC9Hx16FAauW0c9Ak8P6xE+o1v4V5A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=siKk/g1J; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="siKk/g1J" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5a74ac8b40aso5239572e87.1 for ; Wed, 20 May 2026 02:44:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779270266; x=1779875066; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=SRg4MCwFnvrNqRvlPfGDLk8MzpC0OLCTk14CpKVfvfo=; b=siKk/g1J7Pgn1/V/bmJqTw5cms3WiaouGP2pzJeFX0vkNt9bHQpBh1KHI6rAr/Iymy IjRR0NDGwWFTBKOlxqfW+Tikh8oXCfPB0GX6XfvO6lRnm6JB/07OU4m6UNDoteDpkRoD mYtiSXZ8EVE6+s2GeEP99SSUmoWRtK1rhM8sRsF2PNFWSTdsJSVUDbDzNexXEudmrxCL gFierFEnLX0Ug16qwKGibSe/wf5nt73q4fB7wqx9JTMeg/3q5ExJa2H+14/bSKWUfOHO P9BCzQA4+o+zSd/1Tzh+l2WuxggvjoSj6QHO3iRH0pzw6lOcXWjOF5HEoqNHnCNi192C LVmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779270266; x=1779875066; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SRg4MCwFnvrNqRvlPfGDLk8MzpC0OLCTk14CpKVfvfo=; b=MfYw23idzR83xRjovBf/anjqQlBrs8xDSt1N1ltK9G5wTHqbWJCRU1nTslK/2tR6Q+ euWQ/S+FJtss4T8hS1ZnzmmIb2UKwCEE9Pe8g1BKP/K7zbK4+voV79gRWIWVrsXQrtsw pX8gTResIJNFW7aWO4ub4jdn/LeukiGL+/+vuczqFNO94vU3bxsfm/QKQZu1R3Na/2LG KrD7TOCJQeeFzneixPuDDz3iqEbQOgZHkNB1L9/JXbW5o34KBJnLRnE4SLxG8mKjRdol +s0Fp9WdzLjVNxXr6Mhlbwsj8nkGCwHcYFVQO/x7WgGmX2uXuare2HQKqEixtv5d8CkJ jFsQ== X-Forwarded-Encrypted: i=1; AFNElJ/GWhAP8kjaswWhiUZ1c42qLGi31gZwqvjt9oPtlHa13xuBawEKc+ybafgWTZ6FefaUYkQyubUfcPBC2hQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwR2gd9tbDACR/kDinUohD+OGiHcp98ihEwz9divJ99MaqLAXRT IC7h2qUbaUWGXFloR6o7Y8JpI/vUOUOeDFPZPQYuFxdngyqU/K9FMH6S X-Gm-Gg: Acq92OEYHSJzHhMXEHpGqliVtik2blAU97LlZG2OpaUn/oMc5trgaaIFX3x8zZ+HiQa rzio+aPu1Ms6oGJm6OOT9Onvbk8s7woTueNGpj9lBb2QJtr+NDZJDRmg6ioZdHQQrfjgjCkJCwT hXuY60FSUHj+DTgPKN6LbESP7mkTfvjaytVifMhClNJTKpgbaLy3xcK8tIMlocxvJyVgrG6KPKP ZEm3r3BKk3CtmqUmKHmSCRs1fRQKV6DAmojkJJNuVOzUsIEq4GuaOj0+x+SgpqJRL4L7VpzGyDc O7vGGBK2LrfcC8pimN18A97zIPkIVi+uyGKlRa69J1rpsYuV0lZ73sBoOOTCncLGf4cLPVTc5U8 lF4EdlWcpm6y8XJjfYQuYhDrQ9my1f34bES1sBLPClAhj7BX1MV6u0GM6UYUlE8YKt5Esh5qAMQ 0= X-Received: by 2002:a05:6512:318f:b0:5a8:8de0:4576 with SMTP id 2adb3069b0e04-5aa0e764a87mr7000628e87.25.1779270266285; Wed, 20 May 2026 02:44:26 -0700 (PDT) Received: from milan ([2001:9b1:d5a0:a500::24b]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a90f11a619sm4807804e87.27.2026.05.20.02.44.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 02:44:25 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 20 May 2026 11:44:24 +0200 To: Wen Jiang Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, urezki@gmail.com, baohua@kernel.org, Xueyuan.chen21@gmail.com, dev.jain@arm.com, rppt@kernel.org, david@kernel.org, ryan.roberts@arm.com, anshuman.khandual@arm.com, ajd@linux.ibm.com, linux-kernel@vger.kernel.org, Wen Jiang Subject: Re: [PATCH v2 7/7] mm/vmalloc: Stop scanning for compound pages after encountering small pages in vmap Message-ID: References: <20260514094108.2016201-1-jiangwen6@xiaomi.com> <20260514094108.2016201-8-jiangwen6@xiaomi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260514094108.2016201-8-jiangwen6@xiaomi.com> On Thu, May 14, 2026 at 05:41:08PM +0800, Wen Jiang wrote: > From: "Barry Song (Xiaomi)" > > Users typically allocate memory in descending orders, e.g. > 8 → 4 → 0. Once an order-0 page is encountered, subsequent > pages are likely to also be order-0, so we stop scanning > for compound pages at that point. > > Signed-off-by: Barry Song (Xiaomi) > Signed-off-by: Wen Jiang > Tested-by: Xueyuan Chen > --- > mm/vmalloc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index b3389c8f1..60579bfbf 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3576,6 +3576,12 @@ static int __vmap_huge(unsigned long addr, unsigned long end, > map_addr = addr; > idx = i; > } > + /* > + * Once small pages are encountered, the remaining pages > + * are likely small as well > + */ > + if (shift == PAGE_SHIFT) > + break; > > addr += 1UL << shift; > i += 1U << (shift - PAGE_SHIFT); > -- > 2.34.1 > Can we squash this patch with "mm/vmalloc: map contiguous pages in batches for vmap() if possible"? -- Uladzislau Rezki