From: Frederic Weisbecker <frederic@kernel.org>
To: "Uladzislau Rezki (Sony)" <urezki@gmail.com>
Cc: "Paul E . McKenney" <paulmck@kernel.org>,
Joel Fernandes <joelagnelf@nvidia.com>,
Boqun Feng <boqun.feng@gmail.com>, RCU <rcu@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next v2 07/11] rcu: Simplify rcu_do_batch() by applying clamp()
Date: Wed, 20 May 2026 14:26:47 +0200 [thread overview]
Message-ID: <ag2oh3MNOm-GTWLs@localhost.localdomain> (raw)
In-Reply-To: <20260519194524.158515-8-urezki@gmail.com>
Le Tue, May 19, 2026 at 09:45:20PM +0200, Uladzislau Rezki (Sony) a écrit :
> From: "Paul E. McKenney" <paulmck@kernel.org>
>
> This commit replaces a nested ?: sequence with clamp(). This does not
> reduce the number of lines of code, but it does simplify the line that
> it modifies.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
> ---
> kernel/rcu/tree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 55df6d37145e..e46a5124c3eb 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -2584,7 +2584,7 @@ static void rcu_do_batch(struct rcu_data *rdp)
> const long npj = NSEC_PER_SEC / HZ;
> long rrn = READ_ONCE(rcu_resched_ns);
>
> - rrn = rrn < NSEC_PER_MSEC ? NSEC_PER_MSEC : rrn > NSEC_PER_SEC ? NSEC_PER_SEC : rrn;
> + rrn = clamp(rrn, NSEC_PER_MSEC, NSEC_PER_SEC);
> tlimit = local_clock() + rrn;
> jlimit = jiffies + (rrn + npj + 1) / npj;
> jlimit_check = true;
> --
> 2.47.3
>
>
--
Frederic Weisbecker
SUSE Labs
next prev parent reply other threads:[~2026-05-20 12:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 19:45 [PATCH -next v2 00/11] Candidate patches for the v7.2 merge window Uladzislau Rezki (Sony)
2026-05-19 19:45 ` [PATCH -next v2 01/11] rcutorture: Fully test lazy RCU Uladzislau Rezki (Sony)
2026-05-19 19:45 ` [PATCH -next v2 02/11] torture: Add torture_sched_set_normal() for user-specified nice values Uladzislau Rezki (Sony)
2026-05-19 19:45 ` [PATCH -next v2 03/11] torture: Improve kvm-series.sh header comment Uladzislau Rezki (Sony)
2026-05-19 19:45 ` [PATCH -next v2 04/11] torture: Allow "norm" abbreviation for "normal" Uladzislau Rezki (Sony)
2026-05-19 19:45 ` [PATCH -next v2 05/11] srcu: Fix kerneldoc header comment typo in srcu_down_read_fast() Uladzislau Rezki (Sony)
2026-05-19 19:45 ` [PATCH -next v2 06/11] checkpatch: Undeprecate rcu_read_lock_trace() and rcu_read_unlock_trace() Uladzislau Rezki (Sony)
2026-05-19 19:45 ` [PATCH -next v2 07/11] rcu: Simplify rcu_do_batch() by applying clamp() Uladzislau Rezki (Sony)
2026-05-20 12:26 ` Frederic Weisbecker [this message]
2026-05-20 13:54 ` Uladzislau Rezki
2026-05-19 19:45 ` [PATCH -next v2 08/11] rcu: Simplify param_set_next_fqs_jiffies() by applying clamp_val() Uladzislau Rezki (Sony)
2026-05-20 12:31 ` Frederic Weisbecker
2026-05-19 19:45 ` [PATCH -next v2 09/11] rcu: Document rcu_access_pointer() feeding into cmpxchg() Uladzislau Rezki (Sony)
2026-05-20 12:44 ` Frederic Weisbecker
2026-05-19 19:45 ` [PATCH -next v2 10/11] rcu: Latch normal synchronize_rcu() path on flood Uladzislau Rezki (Sony)
2026-05-20 14:43 ` Frederic Weisbecker
2026-05-20 15:16 ` Uladzislau Rezki
2026-05-20 22:28 ` Frederic Weisbecker
2026-05-21 5:23 ` Uladzislau Rezki
2026-05-19 19:45 ` [PATCH -next v2 11/11] rcu-tasks: Fix possible boot-time tests failed for the call_rcu_tasks() Uladzislau Rezki (Sony)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ag2oh3MNOm-GTWLs@localhost.localdomain \
--to=frederic@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox