From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 257673C2BAC for ; Thu, 21 May 2026 11:52:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779364342; cv=none; b=Tc603HRM8KfvrwmWjnVmx+w5o4uMd7Ld6vzpMI1r/bTU5eCVi8kP7sq1l8xgDAN5D4rA1pRwq+KIJWc3NI34WCo6zyud0o5wfuxGfIj6aU8qfGRYC7Zb6RarI6KkvmNvAWJYOPssplZZV/UcfF47FLm/w5sJrtXsmDseY8V5xu0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779364342; c=relaxed/simple; bh=kKDVNTb8IC2azj9YrbcBGyI49nb0LYCPSPK8uzYhtSs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Fk9jYMXeqVvbq9RbzdFif/tb3g3APmvLZqz1FdQou15orvalQ1tyR12I4Mek9Y9UA26gvALdMLIglosTIUfPi62V25AJ4b0M+psLuJq/dczt0iaUOlhjho/KteWaDKC+U+r1s5bgfqNorWl2lt543OcsEpBMD59cgoOGwhbp3QA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Sl42YypD; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Sl42YypD" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-48d146705b4so66863905e9.3 for ; Thu, 21 May 2026 04:52:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1779364339; x=1779969139; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Yhi9sgDChYbtPGE3IsfQLsPhlj9C7gECgpXO/2Qbf/o=; b=Sl42YypD1sjmtTkona+7qj3TzBZ8Mmv50xEBpJ/4ZKD17M42ILNa6xqRD8yS5hIDEf BMx+DJdrhkQpF6ORZBTtYbbNERnZBFtX9aFE0N7UyvIChuzc/Hevx8MBmrg52yQxEKgX ASALiZG4ask53UVivc5RRgD/Sbl6DECrbBtIvBZafePUjHgtwQeiCoDo+1vf0+njDZCQ A/Tglt+CppeziFtZJiScQFeFNmgw5LQPt8HExX2LG7jLqKRPI+qabaotrnBmKf/mhYYW MVzJi55KQak3hpoklIVB7z40H4/Y2d6SwFaTR0nx29LPXcvBXiEC0pZGhfAf/TM0Gp8m b+ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779364339; x=1779969139; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yhi9sgDChYbtPGE3IsfQLsPhlj9C7gECgpXO/2Qbf/o=; b=qEzeHuEAvtphgn14uPD/NNw6YJXHFfhi/uwj63QWa098pkeGVOI3LJnVUmiMcFQPRc AYZE17EBxZGgH7zhROx+WZAbXDzED2Jag0IwTi55/JkM7BwEdDELcZKaFPutGGiZqECh expGmfDPULRZlR6A3czfMKpyn2ttgBWPRNgB8+UvrEUQVJ1dKUM7YtWEfzONg2aZ6bO1 dMx3Y5IxLhhEURQ8BtjOx2GOcR7M1S4yeJ8z0IOMRNLmMP8ZUvVCgPkhZFsqoEOA7H1n ZfTKuD7w1y+wzo1opp1tVt0+agooGlo+bxEsDcdXpAPSomI8LpBW2TW8gfQcueDhAL51 zCAQ== X-Forwarded-Encrypted: i=1; AFNElJ9zjB8lfl7Sk8TFZNjoZ/AvkFCAZWb/Dg8xsNL1ObznvxAve6KOBRBk1IFiZId/6IyMKaXSfORFz0TZc8Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwYu9U4mCIMyqMnARzXPvh3xtF2hY35oLRL5XNTVZTGsbgfbOPM qArUsHvV2HDI/o07UgdL+omyzYNs5h1rUQlXxysXP3vszhKKXmRH7ICZSjlBm6d1IRg= X-Gm-Gg: Acq92OErq4gfHqb+l7S/+XG2MEekAaLLyzjlsscYe2G6Dk0IZU1sRezYEk2u5FuwhiF 15Wm9WGsEAQjt4qXWMmKsbWv1uUX+rLqVu5hKEPJ7FXVZvvHAtsWDepSBzUMwo8FHBTVyn3LQIW XrMm3L/kCjkbb0YTatU0hmlDUmz7gFQAXECUJ8H2Pty9Xd62Vahka1ba+tPL/waUDZcbJM5Y61e 2sThorsHItp2z0zpM9whKS7+npz4Yn5wgK1/YCAPJYkS6Pp9opiZN2KdDjlWasAmAPIIGiAxXKw Pi+7eVxKZxktOb94HT2yFK7BqboztOUmG9GC1GTmaCgPf1dqzvC2y6QOEEfj4VTJiyzk7iUvM+b Roz5sfFsXQUXuVxW6ATHbz2ca3AUcbzxfjIpSJMT6/ZfqblumZ1PWUnaQVisvXCkpYkTmnUZzwd DwqfUO9BOZFzfiCAF6on4wO/1rSw== X-Received: by 2002:a05:600c:32af:b0:488:9ed3:1492 with SMTP id 5b1f17b1804b1-4903605e3damr23883145e9.10.1779364339229; Thu, 21 May 2026 04:52:19 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49035edbe84sm21494935e9.7.2026.05.21.04.52.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 04:52:18 -0700 (PDT) Date: Thu, 21 May 2026 13:52:16 +0200 From: Petr Mladek To: Kaitao Cheng Cc: akpm@linux-foundation.org, rostedt@goodmis.org, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, senozhatsky@chromium.org, linux-kernel@vger.kernel.org, Kaitao Cheng Subject: Re: [PATCH] lib/vsprintf: Require exact hash_pointers mode matches Message-ID: References: <20260519130117.48097-1-kaitao.cheng@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260519130117.48097-1-kaitao.cheng@linux.dev> On Tue 2026-05-19 21:01:17, Kaitao Cheng wrote: > From: Kaitao Cheng > > hash_pointers= accepts a small set of mode strings, but the parser uses > strncmp() with the length of each valid mode. That accepts values with > trailing garbage, such as hash_pointers=autobots or > hash_pointers=nevermind, as valid aliases for auto and never. > > Use strcmp() so that only the documented mode strings are accepted. > Invalid values will continue to fall back to auto through the existing > unknown-mode path. > > Signed-off-by: Kaitao Cheng LGTM: Reviewed-by: Petr Mladek I am going to queue this patch via the printk tree early next week unless anyone complains in the meantime. Best Regards, Petr