From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E009D349B15 for ; Thu, 21 May 2026 16:35:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779381356; cv=none; b=qHrb0E22g2R3nlv1AT7fDHDpkUVs+uqvC5Pk8bdwic3/KyxiAY0pd7b/iKVWZXh247DYWCCJZFg15cpJM8x01V9nAMvkZOv2n+EViiwSIZJsJiPZNeDg/FeCcxTZnI1ggBqKA5Ry292AYVZJaF6haCT6HJDfHDO+87BcckUc0FQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779381356; c=relaxed/simple; bh=jlfJeKJm1hTnJq4v7hEIhthbbG3WNZvPoQtYgMWg1gw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lUj2JQ20Wb0uXIu4rRLue+6afke/Pd9JGjDh/8qFnquRAhvcEuhn7KcAJg0ZaX/UQmssI9VT3Ctopz0DJHvMKGbBBQQ830woPrwuIv+BBULWTU0UiLVCJ/cWGd+I7XsE7JGQPpBdJLmzRyUoympIv8mI+LW2T3cp0Q31jMdGDV8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=CIIwLzUm; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="CIIwLzUm" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3F61A2681; Thu, 21 May 2026 09:35:49 -0700 (PDT) Received: from arm.com (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 062CD3F85F; Thu, 21 May 2026 09:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1779381354; bh=jlfJeKJm1hTnJq4v7hEIhthbbG3WNZvPoQtYgMWg1gw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CIIwLzUmpq7MmzvqVw16Yu78GwgTsuL9j/0etSfc8+L7Y1ukE/V4S07CZw9znmrcy MgciPkvdhNDpzqbu2C8z7XvTK8aXbwTiHba/K3LSNfEA9/nVhDLtXmhBAP+61MPqI8 xjCieJATeIg8qe28gwnIXxRsaE05QtQqUUz4cA1o= Date: Thu, 21 May 2026 17:35:45 +0100 From: Catalin Marinas To: Jonathan Cameron Cc: Srirangan Madhavan , will@kernel.org, mark.rutland@arm.com, lpieralisi@kernel.org, sudeep.holla@arm.com, conor@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, vsethi@nvidia.com, jevans@nvidia.com, raghupathyk@nvidia.com, srikars@nvidia.com, nbenech@nvidia.com, alwilliamson@nvidia.com, Dan Williams Subject: Re: [RFC PATCH 2/2] arm64: mm: add SMCCC-backed cache invalidate provider Message-ID: References: <20260521073047.320614-1-smadhavan@nvidia.com> <20260521073047.320614-3-smadhavan@nvidia.com> <20260521121812.2e4abd71@jic23-huawei> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260521121812.2e4abd71@jic23-huawei> On Thu, May 21, 2026 at 12:18:12PM +0100, Jonathan Cameron wrote: > On Thu, 21 May 2026 07:30:47 +0000 > Srirangan Madhavan wrote: > > MAINTAINERS | 1 + > > arch/arm64/mm/Makefile | 1 + > > arch/arm64/mm/cache_maint.c | 180 ++++++++++++++++++++++++++++++++++++ > > File location wise, this is a driver for a subsystem, be it one closely > coupled to arm. Arm maintainers, do you want it in there or in drivers/cache ? > My personal preference is always to keep drivers with subsystems but I don't > care that much. Yes, it makes more sense to keep it under drivers/cache/. We have many other users of the SMCCC interface under drivers/. > > > 3 files changed, 182 insertions(+) > > create mode 100644 arch/arm64/mm/cache_maint.c > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 2fb1c75afd16..33c35f8e6e40 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -25383,6 +25383,7 @@ M: Jonathan Cameron > > S: Maintained > > T: git https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/ > > F: Documentation/devicetree/bindings/cache/ > > +F: arch/arm64/mm/cache_maint.c > > I wonder if this should just have a separate maintainers entry? > We did that for the hisi driver. Not needed if the code is moved to drivers/cache/. > > +struct arm64_smccc_cache { > > + /* Must be first member */ > > + struct cache_coherency_ops_inst cci; > > + struct mutex lock; /* Serializes SMCCC cache maintenance calls. */ > > + u32 latency_us; > > + u32 rate_limit; > > + bool global_op; > > + u64 global_flush_gen; > > +}; > > + > > +static struct arm64_smccc_cache *arm64_smccc_cache; Nit: if these are all static, does it still make sense to use the arm64_ prefix throughout this file? -- Catalin