From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9C5C3806C1 for ; Thu, 21 May 2026 13:49:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779371358; cv=none; b=k5X/M+0AkBYnSAXAkb5O3twABiI2NaCiKw4ZGrRokK2m2f/2rZLsFYlYqOM6Zq2c9NNfRhIW6u14ksk6sQPun8vkgZJxYknoeFGdiSMM5t8mmqyFzhbsBQQXa6T35sW/IjDJuvA+R9g6X6zlUcnuBlIMk4u+fcz7zcxHp0lvBEg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779371358; c=relaxed/simple; bh=WgxPzYpKqDAOsBgRqwgdKlY/lqZxjoMUFDMkWOc+S64=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BdH0akHN6cBY6K6GPu+sDbE3XJ393MjdLM89P14ITBM48/oW2qrZ/nFvgv8GvlTFXloZVxMZEuHQxXpM68QWNUCEBe6gKhpWzqgfCwKOC37fKzZilm42KuzmuTAAojFgRAYiSiiKfIjNcdHMfjXlfDKRC8+ggw2kOu5epb7yk1I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=U2NhOrGM; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="U2NhOrGM" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-4526a8170ceso3015814f8f.2 for ; Thu, 21 May 2026 06:49:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1779371355; x=1779976155; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=59BwOwu72QOERYvdZLwZfBuikfeeRkvnyxsxRVrYW54=; b=U2NhOrGMFhuJlALujjERpQzU1Y/A+wv7pl1H8FLNwkWU/PzhaZngSfXy6Ehm3EH2PI BkWLOGjaUHq2AS+W2AsJjXilTkrfovglI2SNEjQDl3nvDElKAo0X5TJuwgLeEdg2DVIS POlEwO/2/pekHsWps5f52euUWnDslru65jJ+9/tPrxMBVGHslsnPqh1YXuO/QsLGANQy ew1YVx18MhZ/IdA4NhfzbGEFI8McrnJ4vxiifbnYu31nEB7J0NVrRm/tDigrRtuyd7xb RIkYf6MRr6CJHHnNUfif30OvbYC5BvFiCFbMpGxdWTCfMK7hvcDUrFBHaBExntvtSZLB ecDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779371355; x=1779976155; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=59BwOwu72QOERYvdZLwZfBuikfeeRkvnyxsxRVrYW54=; b=N/uX28FO/9LM8z1zFZ3/bxSD+ED9pj3B5iUvcHg/hNR3TeX+1LPecKpbZ9hwBrWhnX 0q08W+XHLNxZNZsPhYgNqWUzExz5URcgIpY1JKaqClUl8zUqMPOFvMGlM2A2gTXN35ef 3G3E8/LJnKEnaLvwABHC392f65RKrb3SiwL2Ubl+n9yhao/yXfaYYI9FTC12SIQuR2QU ik4KqcGJUlU4SOyTJAZeQJ7Jw48zgyAK4OeHDwM7l/oZfMQ+X1Hg9Zi0qOWMLTzI4pVW CRyjmkW7QAg5Jml7Tdv+ek3ZaTZ2hVvYVD3TTQ/deJVXfkb9hMZ4IugXuIXOAwOam1zd L/7A== X-Forwarded-Encrypted: i=1; AFNElJ9wg8vQby6r485RyoViOw7U2HIAtiZAgKDQWVqwD27ypUjHxawrUVixGfZ89m7Rk8YpX3XK4s4BzRF+gZg=@vger.kernel.org X-Gm-Message-State: AOJu0YxW9jlcwNUcxyZ0trr6CMhq4AAW0Qq+bv5FyzLweoxR1tZegKZV 9Xy5zGgE1PI3HCtsg1aXKoSgoweze8GUBrRtEOVlw72EEoAxy7R+Bk/zorH7Q1pSxKA= X-Gm-Gg: Acq92OEsSn79q2TuiVPhEktP5p+1US+nlG/jvxtWT5ddzt9rotGHiUAgl2z0xzpnAey +ybswO2bPSFL3EW7FyAaAJ93yCb9OS7YlIiJdQiIweUNskuO6jConcxo/CF+/QHur2eXaJbrh5T HM/bDLGdfvapijKrwYZHrt6ukdWCICdNN5NIRxAYk4aPRnbJ3Jmx9Nstk8mmNEXle6jPKmVV5+M OL8UN6TydRAjDbMspnsX/02Brq6cE8dxgCUFLONFAF82wpXVEWcKaQQSC+1QVkJU4Vgq5ut4hQ+ TpmcN0VLYkukB9/yOmNEDJh36/cKIOVmsnhMkhzxu+uivu4ZLaw+rHJH6LUdBmTQQdlxzbXoHpe MpvPDF2cZtNA/K3lXaYkmA8RoLIZIowSA0OCnAu2VYGFIHpgxn1hM2QSk/7+tQIHZBwWVXgvAWP DS2wU3nGtKASNq1vYmXxXPQAd9sA== X-Received: by 2002:a05:6000:29cc:b0:441:1fa5:4577 with SMTP id ffacd0b85a97d-45ea3ae68d6mr4047516f8f.26.1779371355201; Thu, 21 May 2026 06:49:15 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eaa92dea5sm2831675f8f.23.2026.05.21.06.49.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 06:49:14 -0700 (PDT) Date: Thu, 21 May 2026 15:49:12 +0200 From: Petr Mladek To: Thorsten Blum Cc: Steven Rostedt , Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] lib/vsprintf: replace min_t/max_t with min/max Message-ID: References: <20260518123145.79411-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260518123145.79411-3-thorsten.blum@linux.dev> On Mon 2026-05-18 14:31:47, Thorsten Blum wrote: > Use the simpler min()/max() macros since the values are all compatible. > > --- a/lib/vsprintf.c > +++ b/lib/vsprintf.c > @@ -1208,7 +1208,7 @@ char *hex_string(char *buf, char *end, u8 *addr, struct printf_spec spec, > } > > if (spec.field_width > 0) > - len = min_t(int, spec.field_width, 64); > + len = min(spec.field_width, 64); Honestly, I do not see any big advantage in replacing the macros. In fact, the min()/max() macros are even more complex because they check compatibility of the compared types. IMHO, this adds non-necessary churn into the git history without an obvious advantage. Best Regards, Petr