From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 825F6DDCD for ; Sun, 10 May 2026 12:46:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778417173; cv=none; b=Mpv7IWu4QDT14413b29ZHwIE+zELu1Q+7QQDvv8J8qxydfbA26re7e+Rn8RN1VLChNQRVtUAoZoi+hx1ZCwqnq95nllAkVKbT1/16agavXsI4D7By5kcXTEKg/z6mIHnm8wy37PMhYwO/ilkyMdxYjJYT3TmbiHyugFjuFdELtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778417173; c=relaxed/simple; bh=/U1OGiIhFyZSlKY7wTyol1P7vOiJDk7Vj7vPDCFCKgM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mAC+sgWKeO7zWhEOiIjR5Qa4HGKO3XvMlJfhBVNB7r0f9a6EQehEkIZtfidjOQ+5FFQeSKWn+FNYKbGGP/R7BGfBxGRcOaXa5DPmup91nMRFg/9cerqpqs802o+gcUj81D0mIE9VsglQeyvRnrMEyT/Oa4ITyUTsc69YRm2VBYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J8hTKKET; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J8hTKKET" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-44a5174670eso1900489f8f.1 for ; Sun, 10 May 2026 05:46:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778417171; x=1779021971; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9UiYX3DX2mOcITjXbonrx4I6NoJQHM2UHkbJQh3OAx4=; b=J8hTKKETJjc8eL73ki7wXrXCBvEu07QIoLgG2tQ7a5m+KtOMvmVC9bCyD2ibr6T0yK O8+FtAw7ex4vyQMq/woVcjUJRNblfNXs52mDsGE1POtuTkAa++CxOFktjjgHd6zMWXFW k2VMOr0Cp138EuM2IldfbX/65IvLKl2EpN1/ehGrFOnZiLKMexeMllglQORq4DYY6SQO RaU5wBOG5YfuTV4fz1M6Ax067ViN1bw7fJE06xNISICOVsUZ7bkuJRnArnFgeIK1TVep 2NzfQwyciqod0Ud8mhWL9mTJAgyQOPLWK3uU58IMMCenLa5fFx0VSLT85NtS4F9pEsi3 HvmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778417171; x=1779021971; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9UiYX3DX2mOcITjXbonrx4I6NoJQHM2UHkbJQh3OAx4=; b=UUQ2vYacLf8USU5idE271/yQQzByXu3CgLb8K9ZF5ZZcpmNaAY8+DC0p3aGA+KoaUI cx7bOMeHu02832mv9BXbmKbpudoXQKFM5/oFgmsoNT5dPsmu5dZLmU6dd8aeVeU+X3oU lH6PCBF/cgKXB6j7p6qK1fyhRQhtoWoO42FJ7aOeQ5tLCh/+XsNkbcucfIpLxUMMySeU j7ZqPsCtSvVLwSVVlNywsOmiWAUn9YElfxtty3uh80Wkq3lkOwTP1aQzbS++0j56H3N2 pljIEX+rGNxDdL3wsIspMWGCnEsmwSUnl6QyOguEAN4ek9lZChOnf17T6tJp7zb9YUNH yhIg== X-Forwarded-Encrypted: i=1; AFNElJ9GhETrf56Ni1bXIHrwcPEoZ3e/mZ/oa+fBv93FPkr5d1XXfts0ThsDG+TLY1ehHdJntINGUAX1ryHtcQg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywp9zLYKzb8gbcNMwfyVX4bnJcCOKMeU37p9C0BLmIC42FXMm7+ AL2Lvw+x03blGtJgCgP8vZgipAhWw9/JojPQytrW0Ljgbj+zWaI2up8J X-Gm-Gg: Acq92OGS7yx0JnI5dBeIMUiseqQ0CRrOCAGTB+/lhR6MsQ4LfIw0r4m9vaDshGZqddW 2/h55+s+VB6jpGT4z/eI/iLu8Ih6y4nfcURDtna946MzLSbeFrxeJICALK/qWamrL6SznVjjDxG v6ZeHr2Q41jaJjh5+aC3O7iGX1vMW3mtCCx39p92EQ3w7yqJfcpiOS3gu0tcVusEOtsBPP2AaHq X52g83FcDyIL6mLsIxCU6+KdG6+A3rIrCIq1fA7pcStYkLEjeR1aEsTig2ED1EaoBB9AYFsIYN3 +yu8Ew3JdlAUaSbFi3DRGJuKCjPaYGEhjcOdm4bzktZy878savfqGMKS4rdFKYbbM3VFAbtooC5 aAlhhg3BBW3Rj64uJkCsCHWcQM77o2Ex4eZVTY2WGl5pzZTE54EYDn2rxmTJKofUuB3RAMlWyXb 2Pi1wZkWLCr0W5domBEBl1RTOIX+V+LrVFj45brIt0dkn4X38Wkyy1aRQHujQ= X-Received: by 2002:a5d:5f90:0:b0:43d:6787:9933 with SMTP id ffacd0b85a97d-4515b52450cmr33701387f8f.13.1778417170769; Sun, 10 May 2026 05:46:10 -0700 (PDT) Received: from fedora ([94.119.44.3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45491f8d4c3sm17943645f8f.34.2026.05.10.05.46.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 05:46:10 -0700 (PDT) Date: Sun, 10 May 2026 13:46:08 +0100 From: Vishal Moola To: fujunjie Cc: Matthew Wilcox , Jan Kara , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Roman Gushchin , Haoran Zhu Subject: Re: [PATCH v3 2/2] mm/filemap: do not count FAULT_FLAG_TRIED retries as mmap hits Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Apr 28, 2026 at 01:59:44AM +0000, fujunjie wrote: > A fault that starts synchronous mmap readahead can return VM_FAULT_RETRY > after dropping mmap_lock. The retry may then map the folio brought in > by that same miss. > > Do not let this retry decrement mmap_miss. The retry still maps the > folio from the page cache; it just does not count as a useful mmap > readahead hit. > > Signed-off-by: fujunjie > --- Reviewed-by: Vishal Moola