From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 828CC37E30C for ; Sun, 10 May 2026 11:08:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778411319; cv=none; b=EcFnGpj42N768q/O/DUXIb8IsHO0Ete60x5l+4l/p1nvRSzCvCd/pl+cBHIqInCJQEsTaLQ3eL3yUAWauQUUgh7+XM+eeNou1QbhXGRLeYf5+TQpf7A0uSOIKrObBaP2mAdgqBbGR3RuECdvXnvo3/4Bb1ueYZ1Q00Rj6aN6bo4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778411319; c=relaxed/simple; bh=BodKKip1a0sHri6khxOyx6QjEAWs9RaclU4zoqa01m4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kYAF7UsMDb63w/zXAMldl39I83gmGsUjIxWV4BYFJ6HqT0n7k6tiDhBDtIUFQSYXUnQf8Bo2fA2VC/xq+mD1c8ktNsInM+7bjkj46zb9RAx3iRcGU8D1ctYx3R6Eu+rAuI1283vEy+tOGjv4gKnOk7Rtoj2Cwku/FBLRgvd2uUM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q91HnOAG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q91HnOAG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B264C2BD04; Sun, 10 May 2026 11:08:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778411318; bh=BodKKip1a0sHri6khxOyx6QjEAWs9RaclU4zoqa01m4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q91HnOAGdZ0neVjYBVBkwTff4LCvzsu88Q7FQrxMK++bk/xryhmwe9PAuhe3nm1h6 ebZ6d2mqWS/xARL7LIxJgFWIXd1m/xK44m8bIEBbVEy4/pR5WP+Yx7qwJrb5aO5KXC aT/azWod/xrNeGmTLIWNt0c/ikjJR4ecF1Y20hjARq4O0GyBMQ3tnkR0n7bK+UcgwG UUC4hxdl4gnFDjA+Q4Vhejb7XQnoHwEYHFlefNPR08GXCu8rI2C3KbZ+vq9DyOKqXX Q4BBHZ/ie/EMv6BPc2H5uwefetKRyUV7UTKs+jqEWLO164OT1dnRgL55PR0FkPfdkH t7ycZE82RVzaQ== Date: Sun, 10 May 2026 16:38:34 +0530 From: Vinod Koul To: Shawn Lin Cc: linux-rockchip@lists.infradead.org, linux-phy@lists.infradead.org, Heiko Stuebner , Neil Armstrong , linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: rockchip: naneng-combphy: Fix TX detect RX termination errata Message-ID: References: <1774423383-36599-1-git-send-email-shawn.lin@rock-chips.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1774423383-36599-1-git-send-email-shawn.lin@rock-chips.com> On 25-03-26, 15:23, Shawn Lin wrote: > Some PHY revisions may fail to detect the peer RX's termination > resistor (RTERM) under certain critical temperature conditions. > This causes TX detection failures on PCIe links. > > Add a workaround to force the RTERM detection ready signal for > affected PHY revisions. This ensures reliable TX-to-RX termination > detection across all operating temperature ranges. > > The fix applies to RK3562, RK3568, RK3576 and RK3588 SoCs which share > the same PHY IP with this hardware errata. Missing Fixes tag? > > Signed-off-by: Shawn Lin > --- > > drivers/phy/rockchip/phy-rockchip-naneng-combphy.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c > index b60d6bf..76d4994 100644 > --- a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c > +++ b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c > @@ -106,6 +106,9 @@ > #define RK3568_PHYREG18 0x44 > #define RK3568_PHYREG18_PLL_LOOP 0x32 > > +#define RK3568_PHYREG26 0x64 > +#define RK3568_PHYREG26_FORCE_RTERM_DET_RDY BIT(5) > + > #define RK3568_PHYREG30 0x74 > #define RK3568_PHYREG30_GATE_TX_PCK_SEL BIT(7) > #define RK3568_PHYREG30_GATE_TX_PCK_DLY_PLL_OFF BIT(7) > @@ -193,6 +196,7 @@ struct rockchip_combphy_cfg { > unsigned int num_phys; > unsigned int phy_ids[3]; > const struct rockchip_combphy_grfcfg *grfcfg; > + bool force_rxterm_det_rdy; > int (*combphy_cfg)(struct rockchip_combphy_priv *priv); > }; > > @@ -264,6 +268,17 @@ static int rockchip_combphy_init(struct phy *phy) > > switch (priv->type) { > case PHY_TYPE_PCIE: > + /* > + * Hardware Errata: TX fails to detect peer RX termination. Is there an errata number or links which people can refer to? > + * Some PHY revisions may fail to detect remote RX's RTERM > + * (receiver termination resistor) under certain critical > + * temperature conditions. Set force rterm detect ready to > + * fix it. > + */ > + if (priv->cfg->force_rxterm_det_rdy) > + rockchip_combphy_updatel(priv, RK3568_PHYREG26_FORCE_RTERM_DET_RDY, > + RK3568_PHYREG26_FORCE_RTERM_DET_RDY, RK3568_PHYREG26); > + fallthrough; > case PHY_TYPE_USB3: > case PHY_TYPE_SATA: > case PHY_TYPE_SGMII: > @@ -745,6 +760,7 @@ static const struct rockchip_combphy_cfg rk3562_combphy_cfgs = { > }, > .grfcfg = &rk3562_combphy_grfcfgs, > .combphy_cfg = rk3562_combphy_cfg, > + .force_rxterm_det_rdy = true, > }; > > static int rk3568_combphy_cfg(struct rockchip_combphy_priv *priv) > @@ -962,6 +978,7 @@ static const struct rockchip_combphy_cfg rk3568_combphy_cfgs = { > }, > .grfcfg = &rk3568_combphy_grfcfgs, > .combphy_cfg = rk3568_combphy_cfg, > + .force_rxterm_det_rdy = true, > }; > > static int rk3576_combphy_cfg(struct rockchip_combphy_priv *priv) > @@ -1231,6 +1248,7 @@ static const struct rockchip_combphy_cfg rk3576_combphy_cfgs = { > }, > .grfcfg = &rk3576_combphy_grfcfgs, > .combphy_cfg = rk3576_combphy_cfg, > + .force_rxterm_det_rdy = true, > }; > > static int rk3588_combphy_cfg(struct rockchip_combphy_priv *priv) > @@ -1418,6 +1436,7 @@ static const struct rockchip_combphy_cfg rk3588_combphy_cfgs = { > }, > .grfcfg = &rk3588_combphy_grfcfgs, > .combphy_cfg = rk3588_combphy_cfg, > + .force_rxterm_det_rdy = true, > }; > > static const struct of_device_id rockchip_combphy_of_match[] = { > -- > 2.7.4 > > > -- > linux-phy mailing list > linux-phy@lists.infradead.org > https://lists.infradead.org/mailman/listinfo/linux-phy -- ~Vinod