From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4440736604F for ; Sun, 10 May 2026 17:07:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778432857; cv=none; b=DO2ig7EWF4MXP+W9dtxfTAZ3jjLYgLGtkzrQdE65apE+d2l6/YJBqk22KqFab9B9fBgFY+fP+Tc+9/djXf6pQwg5vaf5JpNGHoSCkqYqguV5XtSSv8f0onvx5qNhCq1obTygKgNiAUz8Dr0JWMgaFyXk2JJy1SPt+Lrq44XrEgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778432857; c=relaxed/simple; bh=0TkiaQDCTCY1FoIXh71doV4G2A4Z9yQaHv+H2UwKgUE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s6UfVJRU/xcbm1Vy0lHG0L4dudygjzKCzpAt5bXmOTji5BSVRRLEL062qW/HjiIHNZbzEJUjC6KCDBBfdk3tkKRYUjh+feBzjKb1Q9mhFuOmIUE6IEdHSqrWTuIlafqJtn5s8D5eRnrEMY+BEaydum0KluQspUp53THt+xn5ZDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dSMFnFIh; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dSMFnFIh" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5a8891f0c51so3241828e87.1 for ; Sun, 10 May 2026 10:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778432854; x=1779037654; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=K0XcwMLZ/2Z3fZHXeSZCKnmGYaMss5K1mcWkWF6PnlI=; b=dSMFnFIh0HNjk0setzOOsfNce9Dwmyhje4wYErpvKXnKXx5XbOFBCgosNwn28I21Go PvvcxoYHK7+eBW0ZkPKQfo1BKoYYUcgFwxj1/Y/Jy/QuuIqaCowKQFBb/1BZPZnISdST BZwnKqH244VvcP1YJMg2UUBmnUiLVJScLfMamWGg4kmAg4Vwit7jnLXyzK7VnmGuai5O itecquSe/7+BrVs1l9GXzEGmSCHHrNFhPJfRt2tg2JHjGsy4B3Ep/pLk0RN5vIi0KTIv YM2Hp1F2DXek3jyD3xX7/jrt9dCKNIqg3UjJZTgYo67sFc2KXH0stz2KjPiKLignF1HA PEkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778432854; x=1779037654; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K0XcwMLZ/2Z3fZHXeSZCKnmGYaMss5K1mcWkWF6PnlI=; b=Xqz+O0SVrYlfTliaxOV1gXhmeTOOWyXy6hVnBckcx+AKluuSskxYQY2sXr3/hkkMfT z3gcWY067FQ6Ufo4Tf3lBYsozI0mKdGd3N48Fxe3Pb/blfwyBTiSzf5ac5ZQeyW9VdnR z17vwRVCRQIsKKyUk8feI1Gjtgpnnn2wKX5MQZAWrI86XRXZOzc5ifJ8jhbYVUx6IFHo pth6dRp/t3diVvaScyMZXSCpM1uGPhvTCY34QRMP8FMkJTpJG9i6jawwKvZlIJA/PLT9 IVXxNyDsmWVUbgpn4/UYRF4xJhqllLl5m4Clcs/BPgLDXY7hnvP0vX7b0gLaRhVGaGta ZbTg== X-Forwarded-Encrypted: i=1; AFNElJ/+/Ms7k77rCnM/cOlwpU3PQz/mKybRgxbpvqkTxYz9IZMZVpC8ipyBJpS6pewdpJShEVoJ0IKDg5kpuag=@vger.kernel.org X-Gm-Message-State: AOJu0Ywb6Qkm5oPRZL2gIGAp/7Oi56Y1zTgmlvQbZm15XhQapVKhZgiA vft+6mSklLAxRHu2iwHTdIa9G7f0C/4I2M68GL882zCBKuyJnsZd6RH2nbMrhDro X-Gm-Gg: Acq92OECSQrFq/YxRPcMHU2Q9+U4ve0adlDWuZgX2t9O+aD/eXnOMFlqrOnu8bziYwq HO46doo7/+DCZ+cqRLms7aVVWsbeDJowo7RqhBv1IfVVKoovzYaI7RV6B61hy/C3zysObEj+3gz BMHZSnB3vj56Z8qBplGaw7N0nBNlZyB4f+2U5vGvuO1WOvukG+ZGNibqY4fJPIZz0E+nmk+1Bum sBId4b0UZhdIbdUtpp0Q11/aKTJc2/p6sR8WhkxPmtoGmPMbKpiQInoDvJVuHZrjoHksvHpEypT 7Yzg5Px57AkURVwXbZJRC+fHE+HR51mG9K2wSW2HdfFM8WhV9Tb/2wC2M2q0kNtP948kb3JOOGq W9y4SYjRl3wXJ1LG+MFwqSfyvOTeWVM+mA60qsCir/bcXXX8retCKP+bZ8GUg2UlYbXEPNAQp3R XnSBnbqtRKGns+qNwnOwK9g16k X-Received: by 2002:a05:6512:3e25:b0:5a4:74e:5f75 with SMTP id 2adb3069b0e04-5a887add952mr8233622e87.1.1778432854342; Sun, 10 May 2026 10:07:34 -0700 (PDT) Received: from archlinux ([185.140.161.214]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a8c6f78bd7sm507558e87.74.2026.05.10.10.07.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 10:07:33 -0700 (PDT) Date: Sun, 10 May 2026 20:07:30 +0300 From: Nikolay Kulikov To: Pramod Maurya Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Giorgi Tchankvetadze Subject: Re: [PATCH 2/2] staging: rtl8723bs: Fix coding style in include headers Message-ID: References: <20260510151735.520685-1-pramod.nexgen@gmail.com> <20260510151735.520685-2-pramod.nexgen@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, May 10, 2026 at 08:01:37PM +0300, Nikolay Kulikov wrote: > On Sun, May 10, 2026 at 11:17:21AM -0400, Pramod Maurya wrote: > > Remove multiple blank lines and extern keywords from function > > prototypes in header files as flagged by checkpatch.pl. > > Please one patch for one logical change. > > > > > > Files changed: > > - rtw_wifi_regd.h: remove multiple blank lines > > - sdio_ops_linux.h: remove multiple blank lines > > - cmd_osdep.h: remove multiple blank lines and extern prototypes > > - rtw_ioctl_set.h: remove multiple blank lines > > - rtl8192c_recv.h: remove multiple blank lines > > - rtl8723b_dm.h: remove multiple blank lines > > git diff does this for you perfectly well, why repeat it? And you haven't added cover-letter (PATCH 0/2), you can do this with: $ git format-patch --cover-letter ... > > > Thanks, > Nikolay