From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B82031F9BB for ; Sun, 10 May 2026 19:58:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778443102; cv=none; b=UYWYAj3M9aEOyX8icbQoRxuQIdIyujtLirHYwLC3jvmMq8vK3GlvNHo+IenAR25aiCjZDIosu3vesdc8ONPqBMyZt37V4HPbirTplvsKStjsMkk2aXixDDQyMyjomxDhhyTN9DJNVUeFxWoMActttRKs0wvY63DGeKEA52xw+rM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778443102; c=relaxed/simple; bh=aCvVt43COjr4JGaeTBnYLPuYB+fK9Umf4KVPvVj9NnY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EnUTEXXGIlmIUBy7UgJaiCYfve6QpM8MGvXYvp8Bui6nf2zdEApQctTWbdlZYPafUG2P+mXgB0xbocMdwbp1Yt9/lqSZOMAwdrq2/DDVzvqKvPBEwfkaDZyCvQhE7xhycCLPEqcOqBVSwye2VBube+5YcRf9D5TvMTXTDoRYjjI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ABzZv3/+; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ABzZv3/+" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5a40cfab24dso3966933e87.2 for ; Sun, 10 May 2026 12:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778443099; x=1779047899; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7fsGpZWzj9soCD/1XAWhc0B3Eh71hdLD7XMEVCShBMM=; b=ABzZv3/+JizZgWoYewirYgC69CINzEZNRDyTsOgbMkBes8gvdjgp1ldYQf/toSCdZP bthBhHBMTEBgfUzNz5TIWePgqpNKIQTCQGl2UgH0Xj1nGuHuVbBYNONpOn5Z2RsqWArX RJP3ldABWnoWDMTbdSIfycQrxn/wFf8c74Is2YV6zLPpZzp/T9MJC+qOfELWGhLx0tJr guacARyrvdjVtkW2TW31o9FamotORP2WJiB5Cqq4oZkodsFwceFK3Gt5P3weC7byZI2G ZpGPabl0Z1Fx6jfLIXLUQ7xJVCn4bd/ML/LiyVWrJqkkCHoWXePRjedLGLKtVwrEbmjH xdUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778443099; x=1779047899; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7fsGpZWzj9soCD/1XAWhc0B3Eh71hdLD7XMEVCShBMM=; b=Ijdxe1n9/tMoU5HyoDBRSEEz9SZ9plCAeL0Mr3FeHvafms+w6G9f0jjZsFNFv2FPOV 3PdIzv+8zYod44UnGV7rKZNaF6jHz+Y5dfQ6lFEkJQPvWDBE8444j6TZ+N2MgG9K56ZO mHDpcP0vIdqu0dNtgxXxQgmSSeUs8zidlqNUA+HxTdVeKWc70L0J6cyrPvJ4RAkvDbye Tukwoc1qkIO6+K+rLLyMWW4+6cTmYxz7ncHTOJ3FknlSVaW+PwH1Ta+PgVED2rCRDLeU DWWZIpF0h4+25iVWNHKQprix/Q+TyBDU0kM9bN1f8oxGlIU+apKYuVcfylYq47+dcXel jVTA== X-Forwarded-Encrypted: i=1; AFNElJ9P/Tcvgyj0uR5ffaem/912IRL5zPwdG9LQNevhnjh+l39mzuiEUV9YIbNaPagCT1z6Pc0SBfhapjH44/E=@vger.kernel.org X-Gm-Message-State: AOJu0YyLdR8XrJQHhZypQ9Vf2W3676wwb/Q0umz4hduSNfEEOLEAlyn5 uo0qLhauOdKsmls5aLmp2WZlRF6Z9ROKid/8ynldDPnUh1vg3aC9ZIET X-Gm-Gg: Acq92OHuJm57IGwcq9RxDGzvlRB6dhqO6/4YJazrHqFJRwQAjXXpt8wdpDE2DKkJPhY EjxSPNPfizFUyg770dyfq3omzOBG0XfUl1a9R0oPaHWkiRufDOxCVhEocmDqLKuA0LQjLSdrGw5 MsB3c76H7h7z/TFT89Py/y/q1lZmYE7G4EJ0i4n4wv8u/c2HS9vDTyFbp+vbHP2kY5PXnN7D5jT 8Ya3yDr/3IbaOO6Y/5fSC1SCSCW36TUF0m/zEAUhD4aB5bDL0YjfYHdbQMWxjYHlQGSH9LNqoce Tf2LHjL8Pt0a8nRtMk7QrsyCNHhL2cHa/Tr2LPZdGbW0ErX3X2da7vg7UpeEpSBk+6nsOAidsNI VJAJhvntClQ3GfvcgnYP1yHzRhl+2b42fbg4kifRBMoVPEISILzeQaU0zKzMeX90xBBjfviB/zN vwHg5pFnLjyt7qrlXTmBo1i14GMkQbosL41uM= X-Received: by 2002:a05:6512:3d9e:b0:5a2:bedb:2119 with SMTP id 2adb3069b0e04-5a8a94bc40fmr4059959e87.26.1778443099115; Sun, 10 May 2026 12:58:19 -0700 (PDT) Received: from archlinux ([185.140.161.214]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a8a955e140sm2148289e87.48.2026.05.10.12.58.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 12:58:18 -0700 (PDT) Date: Sun, 10 May 2026 22:58:15 +0300 From: Nikolay Kulikov To: Pramod Maurya Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] staging: rtl8723bs: Enclose CHAN_ARG macro body in parentheses Message-ID: References: <20260510175207.563378-1-pramod.nexgen@gmail.com> <20260510175207.563378-5-pramod.nexgen@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260510175207.563378-5-pramod.nexgen@gmail.com> On Sun, May 10, 2026 at 01:52:07PM -0400, Pramod Maurya wrote: > Wrap the macro expansion in outer parentheses to prevent operator > precedence issues when the macro is used in expressions. > > Signed-off-by: Pramod Maurya > --- > drivers/staging/rtl8723bs/include/ieee80211.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h > index beee37041eeb..d1167d9ea846 100644 > --- a/drivers/staging/rtl8723bs/include/ieee80211.h > +++ b/drivers/staging/rtl8723bs/include/ieee80211.h > @@ -639,7 +639,7 @@ struct rtw_ieee80211_channel { > /*"orig_mpwr:%d\n"*/ > > #define CHAN_ARG(channel) \ > - /*(channel)->band*/ \ > + (/*(channel)->band*/ \ > /*, (channel)->center_freq*/ \ > (channel)->hw_value \ > , (channel)->flags \ > @@ -649,7 +649,7 @@ struct rtw_ieee80211_channel { > /*, (channel)->beacon_found*/ \ > /*, (channel)->orig_flags*/ \ > /*, (channel)->orig_mag*/ \ > - /*, (channel)->orig_mpwr*/ \ > + /*, (channel)->orig_mpwr*/) > > /* Parsed Information Elements */ > struct rtw_ieee802_11_elems { > -- > 2.52.0 > This macro is never used in the driver, why not just remove it? Thanks, Nikolay