Re: [PATCH] Fix possible strscpy() buffer overflows

[Geraldo Nascimento <geraldogabriel@gmail.com>]

Hi David,

On Sun, May 10, 2026 at 11:08:53PM +0100, David Laight wrote:
> On Sun, 10 May 2026 20:24:41 +0200
> "Alexander A. Klimov" <grandmaster@al2klimov.de> wrote:
> 
> > In the changed files, strings were copied like this:
> > 
> >      strscpy(DST, SRC, strlen(SRC));
> > 
> > A buffer overflow would happen if strlen(SRC) > sizeof(DST).
> > Actually, strscpy() must be used this way:
> > 
> >      strscpy(DST, SRC, sizeof(DST));
> >      strscpy(DST, SRC); // defaults to sizeof(DST)
> 
> Nak.
> 
> This is test code and deliberately doing things 'wrong'.
> 
> -- David

while the change to fortify.c is what you described, the other two look
like good catches to me.

Thanks,
Geraldo Nascimento
> 
> > 
> > Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
> > ---
> >   drivers/edac/versalnet_edac.c | 3 +--
> >   drivers/misc/lkdtm/fortify.c  | 6 +-----
> >   sound/soc/codecs/fs210x.c     | 2 +-
> >   3 files changed, 3 insertions(+), 8 deletions(-)