From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6AE32D2397 for ; Mon, 11 May 2026 06:25:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778480758; cv=none; b=PnHjb9dQF+gjl0/JMOJJH/V5EnZkfkVmx4ouyKa2Ccu0jXgghaGplJ3UKF5RfrbjfV5lNda0d80qjwC8L/CaJOKl9kDd+5Q7xWjGsSh47Ru7HDgCysODExNzfxH7LdNV0kr6lTdlrR1z4nW/9H+9lLmMGTfSLx2abPuwZDKGYbo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778480758; c=relaxed/simple; bh=K3PKz3PNnAlrvaVnyzIDAvi3nEtmGTO08GKMjjadSis=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p2GIHj/rYQLvaJF6NXIHcoq8RgskIl/pQBHL/eyj0AHHM+kAc6LMXZENHMyXbhrm35GFiPcrFHy0BnhYtzoARXWKNQj6LBypcO5lE9sCldBU4oZXhWb5/RTeTDcIFAYyk99UUXh0GbEAWJ0CTFgelgR3i98zMDSjZCIei9dKn6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SX/1EXEw; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SX/1EXEw" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5a74ac8b40aso3536347e87.1 for ; Sun, 10 May 2026 23:25:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778480755; x=1779085555; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Fffpl262R++oeuKMn20PIE/OHZwBhViyPAtPu+ftHVI=; b=SX/1EXEwIOMc8ypYad84BxAtbcsHvgw9GYO/LkDTnIDNlfbqF2VfEYoZC6TTF6Dada 9WZ4qZDUvbCvzObo4TKDZM7Xq0HkJ2ByiPdTymQ2aFvezrgLP7H0LpyvWgy7Se4LncOp FnUzozMx7mhPo4+TPNO5+VsfvozF3iT43ik4tOvVpI3yelw2KMp8lG3xiHr+mvZvzZlR 4XmqvIV30Gdujti9nAcmj6k7cJcpkmEf13K1IEcpL3UiLYMIBNd+81L3XtywXi8B3hOy mqsmjnZX2DYjiNR6waY3vstvNrStGQpPVK7HWGFL+5vfKPFV6e19TjUmu6JiuzoR6yC5 9UqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778480755; x=1779085555; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fffpl262R++oeuKMn20PIE/OHZwBhViyPAtPu+ftHVI=; b=SMpKK5lPAa1UFjq4i6RksrMNg3xsilmnilY3Dp34ZGzQz+IggxEyD8AGbxLLzCPVD6 pQKOrZUH8tew1Srv3D7BjgtrveQ8ZAuPezBCWPyvHZzeZJMH1rxvUsjj+QAuxaE52WOm BqsHYNPqw/J6h9TWN+EoLVsEA9QYazovypsAjW/IkuKsKYqh8UyuPcPMJf5QbQcKDSbs 9HLaPN0W28SOt7kuX7Fae/zhLE+1BGd4JQkKcUQmF4SgDbcdi6nPrXQNKjsp2iSwoQpL OuSw7jeMcSZduhwTmeNhuCiCxYf35gEG/LcpLe4qNGjywkFAoEEx3zmyJa07EXvEh0Cm 15OA== X-Forwarded-Encrypted: i=1; AFNElJ8ryWL1onvnmLrwWf1DL0k+Klv1ObRHNmVfRzwrOwBUcFOM4UhgKSx+gqhiJjiKiGh+6UTgszBF7f2sd28=@vger.kernel.org X-Gm-Message-State: AOJu0YydX6d+2aVPsb+ZJ20PakNcU0z/Dvd1/tDTWLhTwqkDOJYcaF25 d1XTGGAxxwjazYnIUwX0clk/LWeTic9zC7fSsIa7In5Zg/hWetfE6J7U X-Gm-Gg: Acq92OEJEn4vhAYcTYKxzI3AlZLlb3Yx2iPh0Ers6ksMywgLTqTfs8S1CCHZAZ4FleV sxRQ+o53Oc81LJT95//+tQiTwRunRXA5rZjTdeGcXJkPVcy0kMtAE3uMfanJom8g70Z/sVAOKHc cIdkFaRJUg/bj4K5uJvM3IWiCyELBF8Axe2/rCpy6u5f5FZynv31g+566K5zNaLAZTU04ue44JU nsXgNl5pE4Q7SHL0MCtqO6fw6r5WsQzJMDULKK8AOFmpKRxtpgnJiLh9GxeHG4/lP1ZgnkTBa9i zTm/y42qfx1hrAn97gyHFoCxNYQOoFE14WwuGfRDusuDfWFu8NemkQI9mDYV96Tu+t1FjQMJ8s4 r2V8PdDMUOop+AaD+8J010jDbljY1SdRLTwM9d2sU/GFSOLnAHTkxD+RivLC8F3hkuHsuMlMhtC p7IcT/CRJTLpkDQGdkvzvBJJMW X-Received: by 2002:a05:6512:10c9:b0:5a8:9909:50b4 with SMTP id 2adb3069b0e04-5a8b708e8d3mr2295577e87.21.1778480754589; Sun, 10 May 2026 23:25:54 -0700 (PDT) Received: from archlinux ([185.140.161.214]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a8a955e140sm2444883e87.48.2026.05.10.23.25.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 23:25:54 -0700 (PDT) Date: Mon, 11 May 2026 09:25:50 +0300 From: Nikolay Kulikov To: Michael =?utf-8?Q?Steinm=C3=B6tzger?= Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: fix type issue in DYNAMIC_BB_DYNAMIC_TXPWR Message-ID: References: <20260511044029.14839-1-m.steinmoetzger@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260511044029.14839-1-m.steinmoetzger@gmail.com> On Mon, May 11, 2026 at 06:40:29AM +0200, Michael Steinmötzger wrote: > Add explicit cast to fix -Werror=overflow warning for BIT(2) usage > in DYNAMIC_BB_DYNAMIC_TXPWR > > Suggested-by: Nikolay Kulikov > Signed-off-by: Michael Steinmötzger This does not apply to staging-next. It's better to do this in a series of two patches, where in the first, replace BIT2 with BIT(2) and add a type cast, like here: > diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > index d837738b9f40..943e199ede82 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c > @@ -1476,13 +1476,13 @@ void update_IOT_info(struct adapter *padapter) > pmlmeinfo->turboMode_cts2self = 0; > pmlmeinfo->turboMode_rtsen = 1; > /* disable high power */ > - Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false); > + Switch_DM_Func(padapter, ((u32)(~DYNAMIC_BB_DYNAMIC_TXPWR)), false); > break; > case HT_IOT_PEER_REALTEK: > /* rtw_write16(padapter, 0x4cc, 0xffff); */ > /* rtw_write16(padapter, 0x546, 0x01c0); */ > /* disable high power */ > - Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false); > + Switch_DM_Func(padapter, ((u32)(~DYNAMIC_BB_DYNAMIC_TXPWR)), false); > break; > default: > pmlmeinfo->turboMode_cts2self = 0; > diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h > index a4770f5eb75c..f832d77d7156 100644 > --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h > +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h > @@ -28,7 +28,7 @@ > /* ====== ODM_ABILITY_E ======== */ > /* BB ODM section BIT 0-15 */ > #define DYNAMIC_BB_DIG BIT(0) /* ODM_BB_DIG */ > -#define DYNAMIC_BB_DYNAMIC_TXPWR BIT2 /* ODM_BB_DYNAMIC_TXPWR */ > +#define DYNAMIC_BB_DYNAMIC_TXPWR BIT(2) /* ODM_BB_DYNAMIC_TXPWR */ > #define DYNAMIC_BB_ANT_DIV BIT(6) /* ODM_BB_ANT_DIV */ > > /* RF ODM section BIT 24-31 */ > -- > 2.54.0 > And in the second, remove the BIT2 macro and all the othere, like in v1: > diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h > index bd72edcb4259..2f5011a8210c 100644 > --- a/drivers/staging/rtl8723bs/include/osdep_service.h > +++ b/drivers/staging/rtl8723bs/include/osdep_service.h > @@ -14,7 +14,6 @@ > > #include > > -#define BIT2 0x00000004 > > extern int RTW_STATUS_CODE(int error_code); > Thanks, Nikolay