From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.formilux.org (mta1.formilux.org [51.159.59.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92970194C96 for ; Mon, 11 May 2026 06:29:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=51.159.59.229 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778480977; cv=none; b=PhO97cKuARAVEExi0B7VkZ62o8258G1WGcaco4K4ygt4M7fPdRzE3UMqDjYkUUqhkdOu7M5AH2h/MCnDNc4hhjp+L5c4aYFkqjIYgxWornv2Zs4DG67b0OktuO5ZexBeMeEJjbfaiQ5UNPPw9ZXeun+uuRAsQ5yO7cu6Lws4pp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778480977; c=relaxed/simple; bh=VVVExNCuwqYfUZ5bwBYo4FAw59EXelZoqMPom3b2wQA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jAq8p4/yNPVcI2X4P6A+sCKONgT1tJrKfx90ZNlplpKzoHDqhpycsxUUx/ZKQS/TM62hF1XedZPrvPcl+pk9Frrz4Dbg6TdWP5jl5v3cZZxD6v0+m3jIdZPyaXHgrWGY/eCF2pRkzAR3+07L1Q80xFJkX6ZzayQY9Ot8FlBpPdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu; spf=pass smtp.mailfrom=1wt.eu; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b=GCFEpFNu; arc=none smtp.client-ip=51.159.59.229 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=1wt.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=1wt.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=1wt.eu header.i=@1wt.eu header.b="GCFEpFNu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1wt.eu; s=mail; t=1778480972; bh=sqdj6yYoBdNFejk3knBFjsMm4e6wmdh91y78TvSWlak=; h=From:Message-ID:From; b=GCFEpFNuf2aZwYeiHMyvaBQfw40hxsWcBgi0xFUzoKVetVspDGu/E6zceSWZFYivu QiVYr8hIQv7oT6jbB9DBGwXHSHgaYQr8yVr8s0eYas1WFyHUTaA0LTw73208mATyex 530VwEmQRfw71yEd4SDtlx4tbByB0UEV3Hk7QjM8= Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by mta1.formilux.org (Postfix) with ESMTP id 92F50C0AAF; Mon, 11 May 2026 08:29:32 +0200 (CEST) Date: Mon, 11 May 2026 08:29:32 +0200 From: Willy Tarreau To: Daniel Palmer Cc: linux@weissschuh.net, david.laight.linux@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/3] nolibc: Add fallocate() Message-ID: References: <20260507090353.356764-1-daniel@thingy.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260507090353.356764-1-daniel@thingy.jp> Hi Daniel, On Thu, May 07, 2026 at 06:03:50PM +0900, Daniel Palmer wrote: > While poking around with my "static PIE for nommu" series I found > I needed fallocate(). Implementing it turned out a bit more > interesting than I thought it would be due to how the offset and > size need to be passed on 32bit machines. > > v4: > - Added statfs()... > - Reworked the test a bit to use statfs() to work out if /tmp > is a tmpfs or not and skip the test if it isn't. This skips > the test on sparc32 where CONFIG_TMPFS=n. > - Adding the needed bits to the sparc32 config to allow tmpfs > to be enabled allows it to run and pass the test. I will check > the changes and send a patch. > - Cleaned up the if() around deciding how to pass the parameters > for fallocate() based on the comments from David and Thomas. > - Test passed on all of the supported targets. (...) Thanks, the whole series looks good to me: Acked-by: Willy Tarreau Let's wait for Thomas who usually spots finer issues than me ;-) Thanks, Willy